On 11/4/07, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> This comments out a problematic section comprising a half-finished algorithm:
>
>  - The variable `ccid2hctx_ackloss' is never initialised to a value different 
> from 0 and
>    hence in fact is a read-only constant.
>  - The `arsent' variable counts packets other than Acks (it is incremented 
> for every packet),
>    and there is no test for Ack Loss.
>  - The concept of counting Acks as such leads to a complex calculation, and 
> the calculation
>    at the moment is inconsistent with this concept.
>    The problem is that the number of Acks - rather than the number of windows 
> - is counted,
>    which leads to a complex (cubic/quadratic) expression - this is not even 
> implemented.
>
> In its current state, the commented-out algorithm interferes with normal 
> processing by
> changing Ack Ratio incorrectly, and at the wrong times.
>
> A new algorithm is necessary, which will not necessarily use the same 
> variables as used by
> the unfinished one; hence the old variables have been removed.
>
> Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>

Acked-by: Ian McDonald <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to