[
https://issues.apache.org/jira/browse/DDLUTILS-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606786#action_12606786
]
Rick Riemer commented on DDLUTILS-211:
--------------------------------------
While investigating a bit further, I found that the DatabaseIO.read() methods
have some more issues:
* The {{read(String)}} and {{read(File)}} never close the opened file
* The {{read(String)}} and {{read(File)}} are rather inefficient when
{{_validateXml}} is set to {{true}}. In that case they validate twice.
I'd like to make some improvements to the code. What would be the best way to
go about? Would I be able to get committer status?
> DatabaseIO.read(Reader) broken
> ------------------------------
>
> Key: DDLUTILS-211
> URL: https://issues.apache.org/jira/browse/DDLUTILS-211
> Project: DdlUtils
> Issue Type: Bug
> Components: Core (No specific database)
> Affects Versions: 1.1
> Environment: Windows XP SP3, Sun JDK 1.6.0_06, DdlUtils SVN HEAD
> (r669848)
> Reporter: Rick Riemer
> Assignee: Thomas Dudziak
> Fix For: 1.1
>
>
> The DatabaseIO.read(Reader) convenience method is broken. It allows an API
> user to specify a Reader instance from which to read a model. However, when
> using it, it fails for files larger than 4096 characters, since it inserts
> new lines characters in the middle of the stream.
> The method should either be removed in favor of the other read() methods, or
> be fixed.
> Reproduction:
> * Read a valid XML model file larger than 4096 bytes using the
> DatabaseIO.read(Reader) API
> Expected result:
> * The model file can be parsed
> Actual result:
> * The XML parser fails with syntax errors due to the erroneous new line
> characters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
