Your message dated Mon, 16 Jan 2006 04:32:05 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#340761: fixed in apache2 2.0.55-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Nov 2005 18:19:26 +0000
>From [EMAIL PROTECTED] Fri Nov 25 10:19:26 2005
Return-path: <[EMAIL PROTECTED]>
Received: from chiark.greenend.org.uk ([193.201.200.170] ident=mail)
        by spohr.debian.org with esmtp (Exim 4.50)
        id 1EfiAP-0000hV-UW
        for [EMAIL PROTECTED]; Fri, 25 Nov 2005 10:19:26 -0800
Received: from [172.18.45.6] (helo=davenant.greenend.org.uk ident=mail)
        by chiark.greenend.org.uk (Debian Exim 3.35 #1) with esmtp
        (return-path [EMAIL PROTECTED])
        id 1EfiAN-00012E-00
        for [EMAIL PROTECTED]; Fri, 25 Nov 2005 18:19:23 +0000
Received: from ian by davenant.greenend.org.uk with local (Exim 3.35 #1)
        id 1EfiAM-0001AV-00 (Debian); Fri, 25 Nov 2005 18:19:22 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <[EMAIL PROTECTED]>
Date: Fri, 25 Nov 2005 18:19:22 +0000
From: Ian Jackson <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: apache2 debian/rules missing many set -e
X-Mailer: VM 7.03 under Emacs 19.34.1
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: apache2
Version: 2.0.55-3

The rules file has many many `for' loops in it, none of which have
`set -e'.  This means that if any error occurs, the build doesn't
notice and just blunders on.

Attached is a diff to correct this.  The diff was made against
2.0.54-5ubuntu2 but it should be straightforward to do the same thing
to any other similar package.  The basic rule is to replace
every occurrence of \n\tfor\x20 with \n\tset\x20-e;\x20for\x20.

Thanks,
Ian.

--- orig/apache2-2.0.54/debian/rules    2005-11-25 16:55:29.000000000 +0000
+++ apache2-2.0.54/debian/rules 2005-11-25 17:57:50.000000000 +0000
@@ -87,7 +87,7 @@
 
 configure: $(STAMP_DIR)/configure
 $(STAMP_DIR)/configure: $(STAMP_DIR)/source.make 
-       for i in config.guess config.sub ltmain.sh; do \
+       set -e; for i in config.guess config.sub ltmain.sh; do \
                for j in $$(find $(B)/ -name $$i); do \
                        cp /usr/share/libtool/$$i $$j; \
                done; \
@@ -98,13 +98,13 @@
 build: $(STAMP_DIR)/build-mpms 
 $(STAMP_DIR)/build-mpms: $(STAMP_DIR)/configure
        dh_testdir
-       for i in $(FIRSTMPM); do \
+       set -e; for i in $(FIRSTMPM); do \
                mkdir -p $(BUILD)/$$i ;\
                cd $(BUILD)/$$i && ac_cv_prog_AWK=mawk CFLAGS="$(AP2_CONFLAGS)" 
LDFLAGS="$(AP2_LDFLAGS)" $(REALCURDIR)/$(B)/configure 
--srcdir=$(REALCURDIR)/$(B) $(AP2_COMMON_CONFARGS) $(AP2_CONFARGS) 
--with-mpm=$$i ;\
                $(MAKE); \
                cd $(REALCURDIR);\
        done
-       for i in $(OTHERMPMS) $(PREFORKMPM); do \
+       set -e; for i in $(OTHERMPMS) $(PREFORKMPM); do \
                mkdir -p $(BUILD)/$$i ;\
                cd $(BUILD)/$$i && ac_cv_prog_AWK=mawk CFLAGS="$(AP2_CONFLAGS)" 
LDFLAGS="$(AP2_LDFLAGS)" $(REALCURDIR)/$(B)/configure 
--srcdir=$(REALCURDIR)/$(B) $(AP2_COMMON_CONFARGS) --with-mpm=$$i ;\
                $(MAKE); \
@@ -119,7 +119,7 @@
        rm -rf $(BUILD)
        $(MAKE) -f debian/sys-build.mk source.clean
        rm -rf debian/stampdir debian.diff
-       for i in $(FIRSTMPM) $(OTHERMPMS); do \
+       set -e; for i in $(FIRSTMPM) $(OTHERMPMS); do \
                rm -f debian/apache2-mpm-$$i.postinst ;\
                rm -f debian/apache2-mpm-$$i.prerm ;\
                rm -f debian/apache2-mpm-$$i.preinst ;\
@@ -135,11 +135,11 @@
 $(STAMP_DIR)/inst-mpms: build
        dh_clean -k
        dh_installdirs
-       for i in $(FIRSTMPM) $(PREFORKMPM); do \
+       set -e; for i in $(FIRSTMPM) $(PREFORKMPM); do \
                cd $(BUILD)/$$i && $(MAKE) 
DESTDIR=$(REALCURDIR)/debian/apache2-mpm-$$i install ; \
                cd $(REALCURDIR) ; \
        done
-       for i in $(OTHERMPMS); do \
+       set -e; for i in $(OTHERMPMS); do \
                $(INSTALL) -d $(REALCURDIR)/debian/apache2-mpm-$$i/usr/sbin/; \
                cd $(BUILD)/$$i && $(LIBTOOL) --mode=install $(INSTALL) apache2 
$(REALCURDIR)/debian/apache2-mpm-$$i/usr/sbin/ ; \
                cd $(REALCURDIR) ; \
@@ -161,7 +161,7 @@
        rm -f debian/apache2-mpm-worker/usr/bin/apr-config 
debian/apache2-mpm-worker/usr/bin/apu-config
 
 #install apache2 dev stuff
-       for i in $(PREFORKMPM) $(FIRSTMPM); do \
+       set -e; for i in $(PREFORKMPM) $(FIRSTMPM); do \
                if [ "$$i" = "prefork" ]; then \
                        TARGET=prefork;\
                else\
@@ -245,7 +245,7 @@
        rm -r debian/apache2-mpm-worker/usr/lib/cgi-bin/
 #      chmod +x debian/apache2-common/usr/lib/cgi-bin/*
        chmod u+x debian/apache2*/usr/sbin/*
-       for i in `find debian/a2-scripts -name .svn -prune -o -name .arch-ids 
-prune -o -type f -print`; \
+       set -e; for i in `find debian/a2-scripts -name .svn -prune -o -name 
.arch-ids -prune -o -type f -print`; \
                do install -m755 $$i debian/apache2-common/usr/sbin; \
        done
        cp debian/default-site 
debian/apache2-common/etc/apache2/sites-available/default
@@ -262,11 +262,11 @@
        mkdir debian/apache2-mpm-prefork/usr/sbin/
        mv debian/apache2-mpm-prefork/usr/apache2 
debian/apache2-mpm-prefork/usr/sbin/apache2
        # EOH
-       for i in $(THREADEDMPMS) ; do \
+       set -e; for i in $(THREADEDMPMS) ; do \
                cp debian/mpm-postinst-threaded debian/apache2-mpm-$$i.postinst 
; \
                cp debian/mpm-preinst-threaded debian/apache2-mpm-$$i.preinst ; 
\
        done
-       for i in $(THREADEDMPMS) $(PREFORKMPM); do \
+       set -e; for i in $(THREADEDMPMS) $(PREFORKMPM); do \
                cp debian/mpms.prerm debian/apache2-mpm-$$i.prerm; \
        done
        cp debian/init-script debian/apache2-common.init.d

---------------------------------------
Received: (at 340761-close) by bugs.debian.org; 16 Jan 2006 12:40:34 +0000
>From [EMAIL PROTECTED] Mon Jan 16 04:40:33 2006
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 4.50)
        id 1EyTWn-0003Io-5g; Mon, 16 Jan 2006 04:32:05 -0800
From: Adam Conrad <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.65 $
Subject: Bug#340761: fixed in apache2 2.0.55-4
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Mon, 16 Jan 2006 04:32:05 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: apache2
Source-Version: 2.0.55-4

We believe that the bug you reported is fixed in the latest version of
apache2, which is due to be installed in the Debian FTP archive:

apache2-common_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-common_2.0.55-4_i386.deb
apache2-common_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-common_2.0.55-4_powerpc.deb
apache2-doc_2.0.55-4_all.deb
  to pool/main/a/apache2/apache2-doc_2.0.55-4_all.deb
apache2-mpm-perchild_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-mpm-perchild_2.0.55-4_i386.deb
apache2-mpm-perchild_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-mpm-perchild_2.0.55-4_powerpc.deb
apache2-mpm-prefork_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-mpm-prefork_2.0.55-4_i386.deb
apache2-mpm-prefork_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-mpm-prefork_2.0.55-4_powerpc.deb
apache2-mpm-worker_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-mpm-worker_2.0.55-4_i386.deb
apache2-mpm-worker_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-mpm-worker_2.0.55-4_powerpc.deb
apache2-prefork-dev_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-prefork-dev_2.0.55-4_i386.deb
apache2-prefork-dev_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-prefork-dev_2.0.55-4_powerpc.deb
apache2-threaded-dev_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-threaded-dev_2.0.55-4_i386.deb
apache2-threaded-dev_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-threaded-dev_2.0.55-4_powerpc.deb
apache2-utils_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2-utils_2.0.55-4_i386.deb
apache2-utils_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2-utils_2.0.55-4_powerpc.deb
apache2_2.0.55-4.diff.gz
  to pool/main/a/apache2/apache2_2.0.55-4.diff.gz
apache2_2.0.55-4.dsc
  to pool/main/a/apache2/apache2_2.0.55-4.dsc
apache2_2.0.55-4_i386.deb
  to pool/main/a/apache2/apache2_2.0.55-4_i386.deb
apache2_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/apache2_2.0.55-4_powerpc.deb
libapr0-dev_2.0.55-4_i386.deb
  to pool/main/a/apache2/libapr0-dev_2.0.55-4_i386.deb
libapr0-dev_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/libapr0-dev_2.0.55-4_powerpc.deb
libapr0_2.0.55-4_i386.deb
  to pool/main/a/apache2/libapr0_2.0.55-4_i386.deb
libapr0_2.0.55-4_powerpc.deb
  to pool/main/a/apache2/libapr0_2.0.55-4_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Conrad <[EMAIL PROTECTED]> (supplier of updated apache2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 26 Nov 2005 19:06:32 +1100
Source: apache2
Binary: apache2-utils apache2 apache2-prefork-dev apache2-mpm-prefork 
apache2-doc libapr0-dev apache2-mpm-worker libapr0 apache2-threaded-dev 
apache2-common apache2-mpm-perchild
Architecture: all i386 powerpc source 
Version: 2.0.55-4
Distribution: unstable
Urgency: low
Maintainer: Debian Apache Maintainers <[email protected]>
Changed-By: Adam Conrad <[EMAIL PROTECTED]>
Description: 
 apache2    - next generation, scalable, extendable web server
 apache2-common - next generation, scalable, extendable web server
 apache2-doc - documentation for apache2
 apache2-mpm-perchild - experimental high speed perchild threaded model for 
Apache2
 apache2-mpm-prefork - traditional model for Apache2
 apache2-mpm-worker - high speed threaded model for Apache2
 apache2-prefork-dev - development headers for apache2
 apache2-threaded-dev - development headers for apache2
 apache2-utils - utility programs for webservers
 libapr0    - the Apache Portable Runtime
 libapr0-dev - development headers for libapr
Closes: 307921 330275 339323 340761 345922
Changes: 
 apache2 (2.0.55-4) unstable; urgency=low
 .
   * Add 050_mod_imap_CVE-2005-3352 to escape untrusted referer headers in
     mod_imap before outputting HTML to avoid XSS attacks; see CVE-2005-3352
   * Add 051_mod_ssl_CVE-2005-3357 to avoid a remote denial of service in
     threaded MPMs when making a non-SSL connection to an SSL-enabled port
     on a server with a custom 400 error document defined; see CVE-2005-3357
   * Clean up our use of trailing slashes on directories in debian/rules, so
     the newer, pickier, obviously very improved coreutils doesn't bite us.
   * Remove some cruft from apache2-common's postinst, dealing with upgrade
     scenarios from versions older than those released in Sarge or Warty.
   * Use "SHELL := sh -e" in debian/rules, so the build will stop on shell
     errors, instead of blundering on to later make targets (closes: #340761)
   * Recreate /var/run/apache2 and /var/lock/apache2 in our init script, in
     case the user has /var/run and /var/lock on tmpfs, which is fasionable.
   * Make our init script a /bin/bash script instead of a /bin/sh script, so
     we can abuse it with regex globbing (#348189, #347962, #340955, #342008)
   * Take patch from Adrian Bridgett to output errors from our config test
     in the init script, but only do so when we're VERBOSE (closes: #339323)
   * In the spirit of the LSB, make our init script exit 2 when called with
     incorrect arguments, and exit 4 when asked for status (closes: #330275)
   * Fix the default site to not mix configuration syntax (closes: #345922)
   * Mention apxs2 in the apache2-*-dev long descriptions (closes: #307921)
Files: 
 01501a6dd4111291920c974b0af4e5ae 806372 net optional 
apache2-common_2.0.55-4_i386.deb
 0656e2babab9ecbdc78d59bffe237710 214972 net optional 
apache2-mpm-prefork_2.0.55-4_powerpc.deb
 0d6643b5d7e227651c42df1d99964f99 170580 devel optional 
apache2-prefork-dev_2.0.55-4_powerpc.deb
 22e717e15276919bd68fb5bcb9bf8c41 212462 net optional 
apache2-mpm-worker_2.0.55-4_i386.deb
 265b56a335e9dc2234b16e577303f082 92672 net optional 
apache2-utils_2.0.55-4_i386.deb
 273312b083b1cb6fc903792c668b9f0c 103038 net optional 
apache2-utils_2.0.55-4_powerpc.deb
 2909d8aa6b57ffa0abb1846e309cc0ca 170570 devel optional 
apache2-prefork-dev_2.0.55-4_i386.deb
 30953595c4b56c44db9309e5093c59b3 280456 libdevel optional 
libapr0-dev_2.0.55-4_powerpc.deb
 317cd63f07cb37bd40fed7c6486246bc 266942 libdevel optional 
libapr0-dev_2.0.55-4_i386.deb
 38850ccae940e633852be1ab08efc5b4 171354 devel optional 
apache2-threaded-dev_2.0.55-4_i386.deb
 3a5aad7409067cca0d167b5b37d2b90a 218804 net optional 
apache2-mpm-worker_2.0.55-4_powerpc.deb
 3fdac5a0dd810227a6d0c6845a5faf05 219276 net optional 
apache2-mpm-perchild_2.0.55-4_powerpc.deb
 6e74b5b7438a011a284a35e614336afe 35392 web optional apache2_2.0.55-4_i386.deb
 88e3e55be774600ab46cbd0344f65f2a 137470 net optional libapr0_2.0.55-4_i386.deb
 897e5da766c1ee27c080b3cd43fb69eb 209030 net optional 
apache2-mpm-prefork_2.0.55-4_i386.deb
 8b190e18e94ceb14a02dbbfa2b90486e 2123842 doc optional 
apache2-doc_2.0.55-4_all.deb
 a41ec991f06a260b7d19127f06ff7d98 858630 net optional 
apache2-common_2.0.55-4_powerpc.deb
 a77979e4012d85d6e4058a267c7b6ab8 115301 net optional apache2_2.0.55-4.diff.gz
 c1eef4372d3e58201a55a3fe41d65c01 212866 net optional 
apache2-mpm-perchild_2.0.55-4_i386.deb
 bbbbaca2321dd3b7bfd5ca33fc3cbc65 1130 net optional apache2_2.0.55-4.dsc
 e52e1e75827892140511c1462177119f 171356 devel optional 
apache2-threaded-dev_2.0.55-4_powerpc.deb
 f0b0c2e2892763dbbf0c7a44311b88d4 140534 net optional 
libapr0_2.0.55-4_powerpc.deb
 f535aeec0eda0ec60716a88f6e5e11de 35398 web optional 
apache2_2.0.55-4_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDy4mJvjztR8bOoMkRAir9AKDsTkZ5R/zZykDgFiwjQvTlsdz8YwCgmG+B
w1HPgt5YkHBRJVhuJXhD4eg=
=+X+C
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to