clone 650414 -1 retitle 650414 grub-installer: stop using otheros.sh and just require os-prober? thanks
On Tue, Nov 29, 2011 at 01:51:58PM -0400, Joey Hess wrote: > Brian Potkin wrote: > > There is no error message when --set is altered to --set=root in the > > line above. --set=root is already in the 'search' line for the OS on the > > USB stick and used when os-prober is installed and run from it with > > update-grub. Would it not be consistent to have it also in 30_otheros? I agree with this and will make this change. Apologies for the delay. > grub-installer's use of os-prober seems overly complicated. If grub > uses os-prober itself, why does grub-installer redundantly use os-prober > to generate a grub configuration? > > The answer seems to be that, in normal operations with recommends > enabled and grub-pc installed, grub-installer does that, but then > throws the configuration away, since it sees os-prober is installed > and relies on grub-pc having used it. > > In the edge cases where grub-legacy is used, the configuration is used, > as grub-legacy (apparently) does not use os-prober. I tend to agree with this too, but it's a somewhat more substantial (and potentially controversial, IME) change. I'm cloning off a separate bug for that so that I can apply the bug-fix above without losing this discussion. > AFAICS, the grub configuration generated by otheros.sh is entirely > grub-legacy syntax. If it ever worked with grub-pc it was due to luck or > compatability hacks in grub-pc. So I suspect my patch fixes this bug, > and that modifying otheros to use --set=root is unnecessary, and > would break it when used with grub-legacy. This is mistaken, though. The "search" lines in question are unambiguously GRUB 2 syntax, and moreover they're in grub2_* functions as opposed to grub_*. No compatibility hacks in GRUB 2 are involved here. Changes to the grub2_* functions can't break GRUB Legacy. Cheers, -- Colin Watson [[email protected]] -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/[email protected]
