Philip Hands, le Fri 18 Sep 2015 09:46:43 +0100, a écrit : > The &&'s after the db_get's are about checking that the setting is set, > you cannot invert those and get a useful result.
Why not? AIUI, db_get is a shell function which returns true when it gets a value, which it puts in RET. Why shouldn't inverting the tests work? We still preserve the sequentiality of db_get call and testing for RET. Did you notice an actual bug? > One could restore the if statement, with an empty then, Yes, that's a possibility, but I still don't see why it's needed. > but I think that the real bug is that we don't have a test for the > DHCP provided preseed, so the real fix would be to add such a test to > the if as it was before. Yes, except that at that point of the d-i boot, we have *not* had the DHCP preseed, so it's impossible to test it. So we don't have any other choice than disabling locale & kbd anyway, so DHCP can be tried without asking any question. Samuel
