Dear Martin, Thanks for your feedback!
On Mon, Apr 11, 2016 at 8:43 AM, Martin Michlmayr <t...@cyrius.com> wrote: > * Roger Shimizu <rogershim...@gmail.com> [2016-04-06 01:29]: >> Hope you can accept these changes this time, because you had some >> concern last time [3]. > > Unfortunately I don't have time to review the changes right now. I'm > happy with the creation of orion5x-tiny (or orion5x-qnap) if that > helps you. > > However, I'm not sure about merging orion5x and kirkwood into marvell. > Does that actually gain us anything? I see several downsides (the > most obvious one is that it would break the installer links; others > downsides, which are easier to fix, are that several other udebs would > need to be updated). Do you see any advantages (apart from using the > same name as the kernel)? I was about to write a list on pros and cons, but I only find pros, with some reasons/explanation. - Main purpose is to get ready for screen support, which surely cannot fit into qnap's image. By creating marvell and marvell-tiny, we can easily and safely add screen-udeb to marvell target and keep it from marvell-tiny target. - If creating orion5x-tiny or orion5x-qnap, the result is almost the same, and download links need to be updated, too. - For "some udebs need to update" part, I guess you mean the device list in libdebian-installer.git [4]. From what I tested, It works well with my previous patch without touching that part of code. Maybe there's some other issues/cases I didn't meet. [4] https://anonscm.debian.org/cgit/d-i/libdebian-installer.git/plain/src/system/subarch-arm-linux.c - I'm going to add new target "netboot-screen" and "netboot/network-screen" in addition to current target "netboot" and "netboot/network-console", because I think the verification of screen support takes months, if not years, on different platform such as mips/s390x/sparc/...etc. I don't want to suddenly add screen-udeb and break a lot arch/platform. During the "transition" period, with new target "netboot-screen" and "netboot/network-screen", the download links have to be appended/changed anyway. After the verification period, if all platform confirms to work well, we can choose to A) rename new targets to old nearest ones; or B) remove old targets and keep only the new ones. The previous one can keep download links, though. - By updating the download links, YES, the manual have to be updated. Let's face it since screen is introduced in, and manuals have to be changed a lot anyway. Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 17B3ACB1
