Frans Pop wrote:
> On Tuesday 09 November 2004 00:34, Martin Michlmayr wrote:
> > +# mount proc since arcboot needs it to decide between IP22 and IP32
> > +mount -t proc none /target/proc || true
> 
> Wouldn't it be cleaner to test first if /target/proc was already mounted
> (with 'mount | grep -q "on /target/proc"')?

This shouldn't happen, AFAICS.

> >  apt-install arcboot
> >  chroot /target /usr/sbin/arcboot $bootdev
> > +umount /target/proc || true
> 
> This way you will umount /target/proc even if it was mounted before this 
> postinst was called.

The final version of this patch assumes /target/proc to be unmounted,
and does proper error checking if this assumption turn out to be wrong.


Thiemo


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]


Reply via email to