On Sun, Mar 18, 2007 at 03:26:59PM +0100, Frans Pop wrote:
On Sunday 18 March 2007 14:11, David Härdeman wrote:
Modified: trunk/packages/partman/partman-auto/auto-shared.sh
=======================================================================
--- trunk/packages/partman/partman-auto/auto-shared.sh (original)
+++ trunk/packages/partman/partman-auto/auto-shared.sh Sun Mar 18
@@ -84,10 +84,13 @@ }

 wipe_disk() {
-       cd $dev
+       local dev
+       dev="$1"

        lvm_wipe_disk "$dev" || return 1

+       cd $dev
+
        open_dialog LABEL_TYPES
        types=$(read_list)
        close_dialog

Shouldn't this include a test that $1 is not empty and that $dev is a valid disk (i.e. that 'cd $dev' succeeds)?

It will soon, I have some more patches to the same file that I want to commit first.

--
David Härdeman


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to