Your message dated Wed, 12 Jan 2005 20:53:28 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Bug#285739: [hylafax-users] patch for tiff2pdf reworked (Re:
Hylafax 4.2 + FaxNotify)
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Dec 2004 09:42:42 +0000
>From [EMAIL PROTECTED] Wed Dec 15 01:42:42 2004
Return-path: <[EMAIL PROTECTED]>
Received: from pd9e961e7.dip0.t-ipconnect.de (bodo.homeip.net) [217.233.97.231]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CeVg9-0005Fc-00; Wed, 15 Dec 2004 01:42:41 -0800
Received: from mei by hedril.private.bodo-m.de with local (Exim 3.36 #1
(Debian))
id 1CeVfa-0000vJ-00; Wed, 15 Dec 2004 10:42:06 +0100
Content-Type: multipart/mixed; boundary="===============0203043425=="
MIME-Version: 1.0
From: Bodo Meissner <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: hylafax-server: empty PDF mail attachments from notify script
X-Mailer: reportbug 3.2
Date: Wed, 15 Dec 2004 10:42:05 +0100
Message-Id: <[EMAIL PROTECTED]>
Sender: <[EMAIL PROTECTED]>
X-BadReturnPath: [EMAIL PROTECTED] rewritten as [EMAIL PROTECTED]
using "From" header
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============0203043425==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: hylafax-server
Version: 1:4.2.0-15
Severity: important
Tags: patch
I received empty PDF files as mail attachments generated by notify
script.
I found three problems:
In faxrcvd there is some code to avoid unset variables in case faxsetup
was not re-run after upgrade to 4.2.
Similar code should be inserted in notify and tiff2pdf scripts. (I did
not check other scripts)
$MIMENCODE is called with the source filename as command line argument
in notify. This does not work with MIMENCODE=base64-encode. It must be
called with stdin redirected from source file as it is done in faxrcvd.
The code to extract the resolution from a TIFF file in tiff2pdf wortks
only if the unit is pixels/inch and the numbers are integers. It does
not work with pixels/cm. For a file created by a scan program on Windows
I get this:
Resolution: 77.16, 77.16 pixels/cm
(This is 196 dpi converted to pixels/cm and rounded.)
After changing the scripts notify and tiff2pdf on my system a manual
call to notify with the parameters found in syslog I successfully
received a mail with the document attached as PDF.
I attach a patch containing my changes. It's only tested with one
successful manual call.
Bodo
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (900, 'testing'), (300, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.27-1-686-smp
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages hylafax-server depends on:
ii debconf 1.4.30.10 Debian configuration management sy
ii gs-afpl [gs-alad 8.14-3 The AFPL Ghostscript PostScript in
ii gs-esp [gs] 7.07.1-9 The Ghostscript PostScript interpr
ii hylafax-client 1:4.2.0-15 Flexible client/server fax softwar
ii libc6 2.3.2.ds1-18 GNU C Library: Shared libraries an
ii libgcc1 1:3.4.2-2 GCC support library
ii libpam0g 0.76-22 Pluggable Authentication Modules l
ii libstdc++5 1:3.3.4-13 The GNU Standard C++ Library v3
ii libtiff-tools 3.6.1-3 TIFF manipulation and conversion t
ii libtiff4 3.6.1-3 Tag Image File Format library
ii mailx 1:8.1.2-0.20040524cvs-1 A simple mail user agent
ii mime-codecs 7.19-2 Fast Quoted-Printable and BASE64 M
ii psmisc 21.5-1 Utilities that use the proc filesy
ii sed 4.1.2-8 The GNU sed stream editor
ii zlib1g 1:1.2.2-3 compression library - runtime
-- debconf information:
* hylafax-server/configure_note:
hylafax-server/start_now: true
--===============0203043425==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="hylafax-patch"
--- notify.orig 2004-12-15 10:24:14.000000000 +0100
+++ notify 2004-12-15 10:21:34.000000000 +0100
@@ -64,6 +64,8 @@
NEXT=${4:-'??:??'}
ENCODING=base64
+MIMENCODE=base64-encode
+TTYCMD=tty
. etc/setup.cache
@@ -443,7 +445,7 @@
return # cannot do much more without a file
fi
if [ -x "$MIMENCODE" ]; then
- $MIMENCODE $FILENAME 2>$ERRORSTO
+ $MIMENCODE <$FILENAME 2>$ERRORSTO
elif [ -x "$UUENCODE" ]; then
if [ "$ENCODING" = "base64" ]; then
$UUENCODE -m $FILENAME $FILENAME \
@@ -456,7 +458,7 @@
else
# Do not use "-x" for backward compatibility; even if it fails
# this is last chance to encode data, so there's nothing to lose.
- $MIMENCODE $FILENAME 2>$ERRORSTO
+ $MIMENCODE <$FILENAME 2>$ERRORSTO
fi
}
--- tiff2pdf.orig 2004-12-15 10:24:29.000000000 +0100
+++ tiff2pdf 2004-12-15 10:21:41.000000000 +0100
@@ -54,6 +54,8 @@
EOF
exit 1
}
+
+TTYCMD=tty
. etc/setup.cache
TIFFINFO=tiffinfo
@@ -86,13 +88,19 @@
$SED 's/.*Image Width: \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
GL=`$TIFFINFO $FILE 2>$ERRORSTO | $GREP "Image Length" | \
$SED 's/.*Image Length: \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
-RW=`$TIFFINFO $FILE 2>$ERRORSTO | $GREP "Resolution" | \
- $SED 's/.*Resolution: \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
-RL=`$TIFFINFO $FILE 2>$ERRORSTO | $GREP "Resolution" | \
- $SED 's/.*Resolution: [0-9]*, \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
+RES=`$TIFFINFO $FILE 2>$ERRORSTO | $AWK 'BEGIN {rw0=rl0=0;}
+/Resolution:/ { rw=$2; rl=$3; unit=$4;
+ if(unit ~ /cm/) { rw *= 2.54; rl *= 2.54; }
+ if(rw > rw0) { rw0=rw; rl0=rl;}}
+END { printf "%dx%d", rw0+0.5, rl+0.5;}' 2>$ERRORSTO`
+#RW=`$TIFFINFO $FILE 2>$ERRORSTO | $GREP "Resolution" | \
+# $SED 's/.*Resolution: \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
+#RL=`$TIFFINFO $FILE 2>$ERRORSTO | $GREP "Resolution" | \
+# $SED 's/.*Resolution: [0-9]*, \([0-9]*\).*/\1/g' | sort -n | $SED -n '$p'`
# keep any output from tiff2ps and ps2pdf from the message source
$TIFF2PS -a -O $tmpps $FILE > $ERRORSTO 2>&1 # fax2ps output looks bad
-$PS2PDF -g$GW\x$GL -r$RW\x$RL $tmpps $out > $ERRORSTO 2>&1
+#$PS2PDF -g$GW\x$GL -r$RW\x$RL $tmpps $out > $ERRORSTO 2>&1
+$PS2PDF -g$GW\x$GL -r$RES $tmpps $out > $ERRORSTO 2>&1
$RM -f $tmpps 2>$ERRORSTO
--===============0203043425==--
---------------------------------------
Received: (at 285739-done) by bugs.debian.org; 12 Jan 2005 19:55:29 +0000
>From [EMAIL PROTECTED] Wed Jan 12 11:55:29 2005
Return-path: <[EMAIL PROTECTED]>
Received: from vsmtp12.tin.it [212.216.176.206]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CooaS-0005CA-00; Wed, 12 Jan 2005 11:55:29 -0800
Received: from eppesuigoccas.homedns.org (80.117.81.199) by vsmtp12.tin.it
(7.0.027) (authenticated as [EMAIL PROTECTED])
id 41E409B8000AD668; Wed, 12 Jan 2005 20:54:53 +0100
Received: from eppesuig3wifi ([192.168.2.51] ident=giuseppe)
by eppesuigoccas.homedns.org with asmtp (Exim 3.35 #1 (Debian))
id 1CooZt-0002hN-00; Wed, 12 Jan 2005 20:54:49 +0100
Subject: Re: Bug#285739: [hylafax-users] patch for tiff2pdf reworked (Re:
Hylafax 4.2 + FaxNotify)
From: Giuseppe Sacco <[EMAIL PROTECTED]>
To: Bodo Meissner <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
In-Reply-To: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>
Content-Type: text/plain
Date: Wed, 12 Jan 2005 20:53:28 +0100
Message-Id: <[EMAIL PROTECTED]>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.3
Content-Transfer-Encoding: 7bit
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Il giorno dom, 02-01-2005 alle 15:56 +0100, Giuseppe Sacco ha scritto:
> Il giorno mer, 29-12-2004 alle 10:25 -0800, Lee Howard ha scritto:
> > On 2004.12.29 10:18 Giuseppe Sacco wrote:
> >
> > > Do you have any idea about when hylafax 4.2.1 might be released?
> >
> > Very soon. We just officially entered a release cycle today, as posted
> > on -devel.
>
> Ok. I am preparing a new package for hylafax-4.2.1 and I will use the
> code from hylafax CVS instead of the proposed patch attached to this bug
> report.
Hi Bodo,
as already told in this report, I did upload 4.2.1 as it come from CVS
so I think this bug should be closed.
Thanks,
Giuseppe
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
