Your message dated Fri, 25 Feb 2005 07:47:16 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#126067: fixed in hexedit 1.2.10-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Dec 2001 10:02:07 +0000
>From [EMAIL PROTECTED] Fri Dec 21 04:02:07 2001
Return-path: <[EMAIL PROTECTED]>
Received: from pc2-hems4-0-cust100.bre.cable.ntl.com (rhirst.linuxcare.com)
[213.107.176.100]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 16HMVD-0001Mp-00; Fri, 21 Dec 2001 04:02:07 -0600
Received: by rhirst.linuxcare.com (Postfix, from userid 501)
id 66881B00C; Fri, 21 Dec 2001 10:00:16 +0000 (GMT)
Date: Fri, 21 Dec 2001 10:00:16 +0000
From: Richard Hirst <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: hexedit: 64 bit off_t problem
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0us
Delivered-To: [EMAIL PROTECTED]
package: hexedit
version: 1.2.2-1
I noticed on hppa that the file offset on the left of the screen was the same
random number of every line of the display. The build options result in
off_t (and hence 'base') being 64 bit. That means there are places where
the code calls printw("%08lX") with a 64 bit param on the stack where the
format string expects 32 bit. On hppa that works sometimes, depending on
how many args there are - 64 bit args are passed in even/odd register
pairs, skipping an odd numbered register if necessary. In this case the
args go in r26 and r24/r23, while printw expects them in r26 and r25.
There are places where you use 'll' in a format string, and I'm guessing
you have simply missed a couple of places, marked >bad> below. Changing the
second of those fixed the problem for me.
Richard
void display()
{
int i;
move(0,0);
for (i = 0; i < nbBytes; i += lineLength) displayLine(i, nbBytes);
>bad> for (; i < page; i += lineLength) PRINTW(("%08lX\n", base + i))
attrset(NORMAL);
move(LINES - 1, 0);
for (i = 0; i < colsUsed - 1; i++) printw("-");
move(LINES - 1, 0);
if (isReadOnly) i = '%';
else if (edited) i = '*';
else i = '-';
>ok> printw("-%c%c %s --0x%llX", i, i, baseName, base + cursor);
if (MAX(fileSize, lastEditedLoc)) printw("/0x%llX", getfilesize());
if (option == bySector) printw("--sector %d", (base + cursor) /
SECTOR_SIZE);
move(cursor / lineLength, computeCursorXCurrentPos());
}
void displayLine(int offset, int max)
{
int i;
>bad> PRINTW(("%08lX ", base + offset))
for (i = offset; i < offset + lineLength; i++) {
if (i > offset) MAXATTRPRINTW(bufferAttr[i] & MARKED, (((i - offset)
% blocSize) ? " " : " "))
if (i < max) ATTRPRINTW(bufferAttr[i], ("%02X", buffer[i]))
else PRINTW((" "))
}
PRINTW((" "))
for (i = offset; i < offset + lineLength; i++) {
if (i >= max) PRINTW((" "))
else if (buffer[i] >= ' ' && buffer[i] < 127)
ATTRPRINTW(bufferAttr[i], ("%c", buffer[i]))
else ATTRPRINTW(bufferAttr[i], ("."))
}
PRINTW(("\n"))
}
---------------------------------------
Received: (at 126067-close) by bugs.debian.org; 25 Feb 2005 12:54:56 +0000
>From [EMAIL PROTECTED] Fri Feb 25 04:54:56 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D4ezg-0006cJ-00; Fri, 25 Feb 2005 04:54:56 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1D4esG-0003Ge-00; Fri, 25 Feb 2005 07:47:16 -0500
From: Florian Ernst <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#126067: fixed in hexedit 1.2.10-1
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Fri, 25 Feb 2005 07:47:16 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: hexedit
Source-Version: 1.2.10-1
We believe that the bug you reported is fixed in the latest version of
hexedit, which is due to be installed in the Debian FTP archive:
hexedit_1.2.10-1.diff.gz
to pool/main/h/hexedit/hexedit_1.2.10-1.diff.gz
hexedit_1.2.10-1.dsc
to pool/main/h/hexedit/hexedit_1.2.10-1.dsc
hexedit_1.2.10-1_i386.deb
to pool/main/h/hexedit/hexedit_1.2.10-1_i386.deb
hexedit_1.2.10.orig.tar.gz
to pool/main/h/hexedit/hexedit_1.2.10.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Florian Ernst <[EMAIL PROTECTED]> (supplier of updated hexedit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 25 Feb 2005 11:43:09 +0100
Source: hexedit
Binary: hexedit
Architecture: source i386
Version: 1.2.10-1
Distribution: unstable
Urgency: low
Maintainer: Florian Ernst <[EMAIL PROTECTED]>
Changed-By: Florian Ernst <[EMAIL PROTECTED]>
Description:
hexedit - view and edit files in hexadecimal or in ASCII
Closes: 48203 126067 259921 281825
Changes:
hexedit (1.2.10-1) unstable; urgency=low
.
* New upstream version, new maintainer (Closes: #259921)
+ showing manpage doesn't screw up terminal mode anymore
(Closes: #48203)
+ backward search works reliably (Closes: #281825)
+ displays correct file offset on hppa / powerpc (Closes: #126067)
* debian/changelog: removed user emacs settings
* echo 4 > debian/compat
* debian/control:
+ drop Build-Depends on autoconf, not needed
+ updated B-D on libncurses-dev to libncurses5-dev, B-D on debhelper
tp >= 4
+ removed trailing full stop from description
+ added Homepage to long description
+ Standards-Version: 3.6.1
* debian/copyright:
+ updated upstream download location
+ added maintaining history
+ extended author / copyright statement, including GPL pointer
* debian/dirs: dropped, not needed
* debian/docs: dropped changes (-> dh_installchangelogs) and
debian/copyright
* debian/menu: added
* debian/rules: complete redo, following best practices
* debian/watch: added
Files:
e34e4ff5fe731f6ee16d91181ba4e9ee 577 editors optional hexedit_1.2.10-1.dsc
706aaefcc7f17f46a3327b702bd278a0 61613 editors optional
hexedit_1.2.10.orig.tar.gz
8b2db36115ae623f13614f01fe7d8f69 2835 editors optional hexedit_1.2.10-1.diff.gz
03e8ba7fae1e34542d13b3b68904f6f6 25142 editors optional
hexedit_1.2.10-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFCHxwVs3U+TVFLPnwRAnflAJoD9aG+QPxDab9P9FIjTYMj/PoAogCdGq+x
SeNsgOa/0HxiuBpmlcKKw90=
=kzFo
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]