Your message dated Sun, 13 Mar 2005 12:20:57 +0100
with message-id <[EMAIL PROTECTED]>
and subject line munin: The port variable is hardcoded
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Feb 2005 20:43:38 +0000
>From [EMAIL PROTECTED] Wed Feb 23 12:43:37 2005
Return-path: <[EMAIL PROTECTED]>
Received: from sun.fadata.bg (skylab.briz.fadata.bg) [213.240.249.67]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D43M9-0003QI-00; Wed, 23 Feb 2005 12:43:37 -0800
Received: from munin by skylab.briz.fadata.bg with local (Exim 4.34)
id 1D3ZZt-0004aT-RL; Tue, 22 Feb 2005 14:55:49 +0200
Content-Type: multipart/mixed; boundary="===============0942739835=="
MIME-Version: 1.0
From: Plamen Tonev <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: munin: The port variable is hardcoded
X-Mailer: reportbug 3.2
Date: Tue, 22 Feb 2005 14:55:49 +0200
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============0942739835==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: munin
Version: 1.2.0-1
Severity: normal
Tags: patch
The problem with munin package is because of the port variable (default is
4949) which is hardcoded
in /usr/share/munin/munin-update. My patch is attached. It also can be found
here:
http://www.tonev.net/patches/munin-port-patch.diff
This probably should be fixed in the next release.
Plamen Tonev
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.21
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages munin depends on:
pn libdigest-md5-perl Not found.
ii libhtml-template-perl 2.6-2 HTML::Template : A module for usin
ii librrds-perl 1.0.49-1 Time-series data storage and displ
pn libtime-hires-perl Not found.
ii perl [libstorable-perl] 5.8.4-6 Larry Wall's Practical Extraction
ii perl-modules 5.8.4-6 Core Perl modules
-- no debconf information
--===============0942739835==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="munin-port-patch.diff"
*** munin-update Tue Feb 22 14:25:21 2005
--- munin-update.diff Tue Feb 22 14:25:21 2005
***************
*** 174,179 ****
--- 174,181 ----
my $update_time= Time::HiRes::time;
my $do_fork = 1;
my $do_version = 0;
+ my $port = 4949;
+ my $dport;
my $timeout = 180;
my $cli_do_fork;
my $cli_timeout;
***************
*** 245,250 ****
--- 247,261 ----
}
# CLI parameters override the configuration file.
+ if (exists $config->{'port'})
+ {
+ $dport = $config->{'port'};
+ }
+ elsif (defined $port)
+ {
+ $dport = $port;
+ }
+
if (defined $cli_timeout)
{
$timeout = $cli_timeout;
***************
*** 642,648 ****
{
$socket = new IO::Socket::INET ('PeerAddr' => "$node->{address}:".
($node->{port} || $config->{domain}->{$domain}->{port} ||
! $config->{port} || "4949"),
'LocalAddr' => &munin_get ($config, "local_address", undef,
$domain, $node),
'Proto' => "tcp", "Timeout" => $timeout);
}
--- 653,659 ----
{
$socket = new IO::Socket::INET ('PeerAddr' => "$node->{address}:".
($node->{port} || $config->{domain}->{$domain}->{port} ||
! $config->{port} || $dport),
'LocalAddr' => &munin_get ($config, "local_address", undef,
$domain, $node),
'Proto' => "tcp", "Timeout" => $timeout);
}
***************
*** 650,656 ****
{
$socket = new IO::Socket::INET ('PeerAddr' => "$node->{address}:".
($node->{port} || $config->{domain}->{$domain}->{port} ||
! $config->{port} || "4949"),
'Proto' => "tcp", "Timeout" => $timeout);
}
my $err = ($socket ? "" : $!);
--- 661,667 ----
{
$socket = new IO::Socket::INET ('PeerAddr' => "$node->{address}:".
($node->{port} || $config->{domain}->{$domain}->{port} ||
! $config->{port} || $dport),
'Proto' => "tcp", "Timeout" => $timeout);
}
my $err = ($socket ? "" : $!);
--===============0942739835==--
---------------------------------------
Received: (at 296660-done) by bugs.debian.org; 13 Mar 2005 11:42:36 +0000
>From [EMAIL PROTECTED] Sun Mar 13 03:42:36 2005
Return-path: <[EMAIL PROTECTED]>
Received: from lust.fud.no [213.145.167.25]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DARUR-0005UL-00; Sun, 13 Mar 2005 03:42:35 -0800
Received: from pride.fud.no ([213.145.167.26])
by lust.fud.no with esmtp (Exim 4.44)
id 1DAR9V-0003xb-WB; Sun, 13 Mar 2005 12:20:58 +0100
From: Tore Anderson <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Re: munin: The port variable is hardcoded
Date: Sun, 13 Mar 2005 12:20:57 +0100
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Closing this bug as it doesn't seem to be a bug..
--
Tore Anderson
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
