Your message dated Sun, 19 Nov 2006 05:02:27 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#383110: fixed in qiv 2.0-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: qiv
Version: 2.0-4.2
Severity: wishlist
Tags: patch
By default, qiv sorts the agglomerate list of files before displaying
the images to the user. I believe it would be useful to have an
option to avoid the sorting all-together, such that the user could
specify a list of files to be viewed in a given order without the need
to rename the files in order to coerce qiv into producing that order.
Since I was unable to find a way to accomplish this with the current
qiv options, I have added a -D,--no_sort option to qiv which causes
qiv to bypass the sorting algorithm. With the attached patch, qiv
still sorts all files by default, and if any of the sort-specifier
options are passed (-P,-M,-N) in addition to the new -D option, the
-D option is overridden.
I hope you find this useful, and will consider its addition.
Cheers,
Kevin
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.20060719a
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages qiv depends on:
ii gdk-imlib11 1.9.14-30 imaging library for use with gtk
ii libc6 2.3.6-19 GNU C Library: Shared libraries
ii libglib1.2 1.2.10-10.1 The GLib library of C routines
ii libgtk1.2 1.2.10-18 The GIMP Toolkit set of widgets fo
ii libx11-6 2:1.0.0-7 X11 client-side library
ii libxext6 1:1.0.0-4 X11 miscellaneous extension librar
ii libxi6 1:1.0.0-5 X11 Input extension library
ii libxinerama1 1:1.0.1-4 X11 Xinerama extension library
qiv recommends no packages.
-- no debconf information
diff -ur qiv-2.0.orig/options.c qiv-2.0/options.c
--- qiv-2.0.orig/options.c 2006-08-14 15:08:45.000000000 -0600
+++ qiv-2.0/options.c 2006-08-14 18:55:02.000000000 -0600
@@ -22,7 +22,7 @@
extern int rreaddir(const char *);
extern int rreadfile(const char *);
-static char *short_options = "hexyzmtb:c:g:niIpaGA:vo:srRSd:u:fw:W:PMNF:T";
+static char *short_options = "hexyzmtb:c:g:niIpaGA:vo:srRSd:u:fw:W:DPMNF:T";
static struct option long_options[] =
{
{"help", 0, NULL, 'h'},
@@ -52,6 +52,7 @@
{"fullscreen", 0, NULL, 'f'},
{"fixed_width", 1, NULL, 'w'},
{"fixed_zoom", 1, NULL, 'W'},
+ {"no_sort", 0, NULL, 'D'},
{"ignore_path_sort", 0, NULL, 'P'},
{"merged_case_sort", 0, NULL, 'M'},
{"numeric_sort", 0, NULL, 'N'},
@@ -187,7 +188,7 @@
void options_read(int argc, char **argv, qiv_image *q)
{
- int long_index, shuffle = 0, need_sort = 0;
+ int long_index, shuffle = 0, need_sort = 1;
int c, cnt;
int force_statusbar=-1; /* default is don't force */
struct stat sb;
@@ -260,7 +261,6 @@
g_print("Error: %s is not a directory.\n",optarg);
gdk_exit(1);
}
- need_sort=1;
break;
case 'f': fullscreen=1;
break;
@@ -268,17 +268,18 @@
break;
case 'W': fixed_zoom_factor = (checked_atoi(optarg) - 100) / 10;
break;
- case 'P': need_sort = ignore_path_sort = 1;
+ case 'D': need_sort = 0;
break;
- case 'M': need_sort = merged_case_sort = 1;
+ case 'P': ignore_path_sort = 1;
break;
- case 'N': need_sort = numeric_sort = 1;
+ case 'M': merged_case_sort = 1;
+ break;
+ case 'N': numeric_sort = 1;
break;
case 'F': if(rreadfile(optarg) < 0) {
g_print("Error: %s could not be opened: %s.\n",optarg, strerror(errno));
gdk_exit(1);
}
- need_sort=1;
break;
case 'T': watch_file=1;
break;
@@ -288,6 +289,9 @@
}
}
+ /* In case user specified -D and -P, -M, or -N */
+ need_sort = need_sort || ignore_path_sort || merged_case_sort || numeric_sort;
+
/* default: show statusbar only in fullscreen mode */
/* user wants to override? */
if (force_statusbar != -1) {
@@ -302,7 +306,6 @@
while (cnt-- > 0) {
if (stat(argv[optind], &sb) >= 0 && S_ISDIR(sb.st_mode)) {
rreaddir(argv[optind++]);
- need_sort=1;
}
else {
if (images >= max_image_cnt) {
diff -ur qiv-2.0.orig/qiv.1 qiv-2.0/qiv.1
--- qiv-2.0.orig/qiv.1 2006-08-14 15:08:45.000000000 -0600
+++ qiv-2.0/qiv.1 2006-08-14 18:55:00.000000000 -0600
@@ -130,6 +130,9 @@
baz01.jpg through baz99.jpg (because the longer group of zero-padded
digits indicates that they shouldn't be intermingled).
.TP
+.B \-D, \-\-no_sort
+Do not apply any sorting to the list of files.
+.TP
.B \-T, \-\-watch
Reload the image if it has changed on disk.
.SH EXAMPLES
--- End Message ---
--- Begin Message ---
Source: qiv
Source-Version: 2.0-5
We believe that the bug you reported is fixed in the latest version of
qiv, which is due to be installed in the Debian FTP archive:
qiv_2.0-5.diff.gz
to pool/main/q/qiv/qiv_2.0-5.diff.gz
qiv_2.0-5.dsc
to pool/main/q/qiv/qiv_2.0-5.dsc
qiv_2.0-5_i386.deb
to pool/main/q/qiv/qiv_2.0-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bart Martens <[EMAIL PROTECTED]> (supplier of updated qiv package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 12 Nov 2006 09:21:38 +0100
Source: qiv
Binary: qiv
Architecture: source i386
Version: 2.0-5
Distribution: unstable
Urgency: low
Maintainer: Bart Martens <[EMAIL PROTECTED]>
Changed-By: Bart Martens <[EMAIL PROTECTED]>
Description:
qiv - A quick image viewer for X
Closes: 311232 320115 326849 347042 383108 383110 383113 398124
Changes:
qiv (2.0-5) unstable; urgency=low
.
* New maintainer. Closes: #398124.
* Acknowledge NMU's. Closes: #320115, #347042.
* debian/*: Repackaged with cdbs.
* debian/control: Updated build-depends to gdk-imlib11-dev.
* debian/patches/*: Converted dpatches to diff files.
* debian/patches/02.typo_envoked.diff: Added. Closes: #311232. Patch by A
Costa <[EMAIL PROTECTED]>, thanks.
* debian/patches/04.qiv-nosort.diff: Added. Closes: #383110. Patch by
Kevin Locke <[EMAIL PROTECTED]>, thanks.
* debian/patches/05.qiv-manpage-options.diff: Added. Closes: #383108.
Patch by Kevin Locke <[EMAIL PROTECTED]>, thanks.
* debian/patches/06.xmalloc.diff: Added. Closes: #383113. Patch by Kevin
Locke <[EMAIL PROTECTED]>, thanks.
* debian/watch: Added.
* debian/bin/qiv, debian/lintian/qiv, debian/rules: Add wrapper using
XLIB_SKIP_ARGB_VISUALS=1 as workaround for problem in qiv with X composite
extension. Closes: #326849. Thanks to Joerg Platte <[EMAIL PROTECTED]>.
Files:
199a930c6c12b8af1656ab4273cf2f63 598 graphics extra qiv_2.0-5.dsc
0ec33dfc402492daf35e04d3f3305478 10937 graphics extra qiv_2.0-5.diff.gz
4e1df5abf932a0e4bdaae269d850a7bf 66956 graphics extra qiv_2.0-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
iD8DBQFFYFO601u8mbx9AgoRAtePAJ9WhBYK6+NwCV5hldwFacZdiMenMQCgqn5T
V7LX/m81DHN/rGUNuKUNsRw=
=kAP0
-----END PGP SIGNATURE-----
--- End Message ---
