Your message dated Mon, 18 Dec 2006 09:02:12 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#403043: fixed in unixcw 2.3-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: unixcw
Severity: important
Version: 2.3-3
Tags: patch
Hi,
the current version fails to build on GNU/kFreeBSD.
It incorrectly assumes that number of signals
is given by macro SIGRTMAX.
Moreover there is "off by one" bug even on Linux,
as signal numbers starts with 1,
see also /usr/include/bits/signum.h.
Current code reject perfectly valid signal 64 in
cw_register_signal_handler() and cw_unregister_signal_handler()
with EINVAL.
Please find attached patch to fix all of that.
There may be still problem with cw_register_signal_handler()
and cw_unregister_signal_handler() for signal number 0.
IMHO, it should be rejected directly with EINVAL.
It would also be nice if you can inform upstream
about this issues.
Thanks in advance
Petr--- unixcw-2.3.orig/src/cwlib/cwlib.c
+++ unixcw-2.3/src/cwlib/cwlib.c
@@ -3008,7 +3008,18 @@
* initialized dynamically to SIG_DFL (if SIG_DFL is not NULL, which it
* seems that it is in most cases).
*/
-static void (*cw_signal_callbacks[RTSIG_MAX]) (int);
+
+#if defined(NSIG)
+#define SIG_MAX (NSIG)
+#elif defined(_NSIG)
+#define SIG_MAX (_NSIG)
+#elif defined(RTSIG_MAX)
+#define SIG_MAX ((RTSIG_MAX)+1)
+#else
+#error unknown number of signals
+#endif
+
+static void (*cw_signal_callbacks[SIG_MAX]) (int);
/**
@@ -3194,14 +3205,14 @@
{
int index;
- for (index = 0; index < RTSIG_MAX; index++)
+ for (index = 0; index < SIG_MAX; index++)
cw_signal_callbacks[index] = SIG_DFL;
is_initialized = TRUE;
}
/* Reject invalid signal numbers, and SIGALRM, which we use internally. */
- if (signal_number < 0 || signal_number >= RTSIG_MAX
+ if (signal_number < 0 || signal_number >= SIG_MAX
|| signal_number == SIGALRM)
{
errno = EINVAL;
@@ -3256,7 +3267,7 @@
int status;
/* As above, reject unacceptable signal numbers. */
- if (signal_number < 0 || signal_number >= RTSIG_MAX
+ if (signal_number < 0 || signal_number >= SIG_MAX
|| signal_number == SIGALRM)
{
errno = EINVAL;
--- End Message ---
--- Begin Message ---
Source: unixcw
Source-Version: 2.3-4
We believe that the bug you reported is fixed in the latest version of
unixcw, which is due to be installed in the Debian FTP archive:
cw_2.3-4_i386.deb
to pool/main/u/unixcw/cw_2.3-4_i386.deb
cwcp_2.3-4_i386.deb
to pool/main/u/unixcw/cwcp_2.3-4_i386.deb
unixcw-dev_2.3-4_i386.deb
to pool/main/u/unixcw/unixcw-dev_2.3-4_i386.deb
unixcw_2.3-4.diff.gz
to pool/main/u/unixcw/unixcw_2.3-4.diff.gz
unixcw_2.3-4.dsc
to pool/main/u/unixcw/unixcw_2.3-4.dsc
unixcw_2.3-4_i386.deb
to pool/main/u/unixcw/unixcw_2.3-4_i386.deb
xcwcp_2.3-4_i386.deb
to pool/main/u/unixcw/xcwcp_2.3-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joop Stakenborg <[EMAIL PROTECTED]> (supplier of updated unixcw package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 18 Dec 2006 09:45:19 +0100
Source: unixcw
Binary: xcwcp cwcp cw unixcw unixcw-dev
Architecture: source i386
Version: 2.3-4
Distribution: unstable
Urgency: low
Maintainer: Joop Stakenborg <[EMAIL PROTECTED]>
Changed-By: Joop Stakenborg <[EMAIL PROTECTED]>
Description:
cw - Command-line frontend to unixcw
cwcp - Ncurses frontend to unixcw
unixcw - Shared library for Morse programs
unixcw-dev - Development files for Morse programs
xcwcp - Qt frontend to unixcw
Closes: 403043
Changes:
unixcw (2.3-4) unstable; urgency=low
.
* Fix FTBFS on GNU/kFreeBSD. Thanks Petr Salinger. Closes: #403043.
Files:
30c8df584e164e7914ea189bdd821ae5 638 hamradio optional unixcw_2.3-4.dsc
97bf91457460bb9d3cb2add8282c0d58 84737 hamradio optional unixcw_2.3-4.diff.gz
331ac639d7862f7d740419d7e4136e76 27914 hamradio optional unixcw_2.3-4_i386.deb
5ae7acf3fddf45fdbd36eaf71df39325 25512 hamradio optional cw_2.3-4_i386.deb
d34d18ff5d9e14135326cf542c624431 36458 devel optional unixcw-dev_2.3-4_i386.deb
8c0f374857dbdd5102b4924361e9ccaa 38684 hamradio optional cwcp_2.3-4_i386.deb
b51792065f04d2e835b8c2b550005cbd 79240 hamradio optional xcwcp_2.3-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFFhlZe/CqtjGLxpX8RAhxXAJ9HTLDEyfUv0z/JVouqOAZhVzUVIwCgp6iQ
oJbAsXyOaQkC7vQZ8o3golU=
=DlY9
-----END PGP SIGNATURE-----
--- End Message ---
