Your message dated Tue, 26 Dec 2006 15:36:49 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Bug#344967: svn-buildpackage: --svn-ignore-new ignores locally 
added files during build
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: svn-buildpackage
Version: 0.6.7
Severity: normal
Tags: patch

The --svn-ignore-new switch allows me to build a package even though
there are local changes, but svn-buildpackage ignores locally added
files and directories.

The --svn-ignore-new switch should ignore the fact that there are local
changes, but it should still include any newly added files and
directories when building a package.  (This is extremely useful for
testing.)

The attached patch accomplishes this for added files in version 0.6.7,
but I see that the way the list of files is generated now differs in
version 0.6.14 to use SVN::Client, so this may already be fixed.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.27-2-386
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages svn-buildpackage depends on:
ii  devscripts                    2.8.14     Scripts to make the life of a Debi
ii  perl                          5.8.4-8    Larry Wall's Practical Extraction 
ii  subversion                    1.1.4-2    advanced version control system (a
ii  subversion-tools              1.1.4-2    assorted tools related to Subversi

-- no debconf information
--- svn-buildpackage.orig       2005-04-21 13:17:45.000000000 -0500
+++ svn-buildpackage    2005-12-27 19:14:43.000000000 -0600
@@ -335,7 +335,8 @@
 print STDERR "Creating file list...\n" if $opt_verbose;
 open($stat, "svn status -v |");
 while(<$stat>) {
-   if(/^[^\?].*\d+\s+\d+\s+\S+\s+(.*)\n/) {
+   if(/^[^\?].*\d+\s+\d+\s+\S+\s+(.*)\n/
+      || ($opt_ignnew && /^A.*0\s+\?\s+\?\s+(.*)\n/)) {
       $_=$1;
       if ($_ ne ".") {
          if(-d $_) {

--- End Message ---
--- Begin Message ---
Version: 0.6.13

#include <hallo.h>
* David D. Kilzer [Mon, Dec 25 2006, 08:57:53PM]:
> On Dec 25, 2006, at 1:07 PM, Eduard Bloch wrote:
> 
> >* David D. Kilzer [Tue, Dec 27 2005, 07:51:32PM]:
> >>Package: svn-buildpackage
> >>Version: 0.6.7
> >>Severity: normal
> >>Tags: patch
> >>
> >>The --svn-ignore-new switch allows me to build a package even though
> >>there are local changes, but svn-buildpackage ignores locally added
> >>files and directories.
> >>
> >>The --svn-ignore-new switch should ignore the fact that there are  
> >>local
> >>changes, but it should still include any newly added files and
> >>directories when building a package.  (This is extremely useful for
> >>testing.)
> >
> >I disagree. If you want to mess around with unknown files, then  
> >work in
> >your work directory directly. Or copy it manually and test somewhere
> >else. rsync is great for doing that.
> 
> I fail to see how locally modified files (status 'M') differ from  
> locally added files and directories (status 'A') in this context.   
> Both contain changes that will be checked in during the next commit-- 
> the only difference is that the newly added files (and directories)  
> don't exist in the svn repository yet.
> 
> Note that I am NOT talking about ignoring unknown files (status '?'),  
> just newly added files.
> 
> I won't argue this point any further, though.

Uhm. If your wish only refers to the files that have been svn-added,
then I assume that you have watched some temporary bug fixed long ago,
probably somewhere around 0.6.13 when I started using perl bindings because
parsing the "svn status" and "svn ls" output was too error-prone.

I am closing this bugreport, since AFAICS it works well as soon as you
registered new files with svn. Thanks for reporting anyway.

Eduard.

-- 
<DeVries> Wann kommt Debian3.0? Jemand n ungefähres oder genaues Datum parat?
<Alfie> DeVries: Wenn es fertig ist.
<Falky> dwVries wenn es fertig ist
<weasel> DeVries: ziemlich genau dann, wenn es fertig ist.

--- End Message ---

Reply via email to