Your message dated Sun, 03 Apr 2005 12:02:40 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#300878: fixed in nstx 1.1-beta6-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Mar 2005 13:28:09 +0000
>From [EMAIL PROTECTED] Tue Mar 22 05:28:09 2005
Return-path: <[EMAIL PROTECTED]>
Received: from c223012.adsl.hansenet.de (localhost.localdomain) [213.39.223.12]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DDjQW-00078U-00; Tue, 22 Mar 2005 05:28:08 -0800
Received: from aj by localhost.localdomain with local (Exim 4.44)
id 1DDjQP-0005AB-B0; Tue, 22 Mar 2005 14:28:06 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: nstx: FTBFS (amd64/gcc-4.0): pointer targets in assignment differ in
signedness
Message-Id: <[EMAIL PROTECTED]>
Date: Tue, 22 Mar 2005 14:28:06 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: nstx
Severity: normal
Tags: patch
When building 'nstx' on amd64 with gcc-4.0,
I get the following error:
make[1]: Entering directory `/nstx-1.1-beta6'
cc -ggdb -Wall -Werror -Wsign-compare -c -o nstxd.o nstxd.c
cc1: warnings being treated as errors
nstxd.c: In function 'do_timeout':
nstxd.c:175: warning: pointer targets in assignment differ in signedness
nstxd.c: In function 'nstx_getpacket':
nstxd.c:191: warning: pointer targets in passing argument 1 of 'dns_extractpkt'
differ in signedness
nstxd.c:201: warning: pointer targets in passing argument 1 of 'nstx_decode'
differ in signedness
nstxd.c:223: warning: pointer targets in assignment differ in signedness
make[1]: *** [nstxd.o] Error 1
make[1]: Leaving directory `/nstx-1.1-beta6'
make: *** [build-stamp] Error 2
With the attached patch 'nstx' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/nstx-1.1-beta6/nstx_dns.c ./nstx_dns.c
--- ../tmp-orig/nstx-1.1-beta6/nstx_dns.c 2005-03-22 14:22:24.480816105
+0100
+++ ./nstx_dns.c 2005-03-22 14:18:41.878141515 +0100
@@ -143,7 +143,7 @@
{
int len;
- len = strlen(data);
+ len = strlen((char*)data);
return _cstringify(data, &len, 63);
}
@@ -200,7 +200,7 @@
d += llen;
} while (llen);
*d = '\0';
- return buf;
+ return (const unsigned char*)buf;
}
/* New DNS-Code */
@@ -318,7 +318,7 @@
const char *ptr;
static char *fqdn;
- ptr = data2lbl(data);
+ ptr = (char*)data2lbl((unsigned char*)data);
fqdn = realloc(fqdn, strlen(ptr)+strlen(suffix)+1);
strcpy(fqdn, ptr);
strcat(fqdn, suffix);
@@ -337,7 +337,7 @@
off = strstr(fqdn, suffix);
if (off)
- buf = strdup(lbl2data(fqdn, off - fqdn));
+ buf = strdup((char*)lbl2data((unsigned char*)fqdn, off - fqdn));
else
/* Our suffix not found... */
buf = NULL;
@@ -364,7 +364,7 @@
const char *ptr;
char *buf;
- ptr = data2txt(data, &len);
+ ptr = (char*)data2txt((unsigned char*)data, &len);
buf = malloc(len);
memcpy(buf, ptr, len);
@@ -477,7 +477,7 @@
{
offsets[i++] = ptr - buf;
rrp = _new_listitem(&pkt->query);
- rrp->data = decompress_label(buf, len, ptr);
+ rrp->data = decompress_label((char*)buf, len, (char*)ptr);
if (!rrp->data)
{
syslog(LOG_ERR, "dns_extractpkt: decompress_label choked in qd\n");
diff -urN ../tmp-orig/nstx-1.1-beta6/nstx_encode.c ./nstx_encode.c
--- ../tmp-orig/nstx-1.1-beta6/nstx_encode.c 2005-03-22 14:22:24.480816105
+0100
+++ ./nstx_encode.c 2005-03-22 14:15:16.428144462 +0100
@@ -34,7 +34,7 @@
revmap = malloc(256);
- for (i = 0; i < strlen(map); i++)
+ for (i = 0; i < strlen((char*)map); i++)
revmap[map[i]] = i;
}
@@ -70,7 +70,7 @@
if (!revmap)
init_revmap();
- len = strlen(data);
+ len = strlen((char*)data);
buf = realloc(buf, ((len+3)/4)*3);
diff -urN ../tmp-orig/nstx-1.1-beta6/nstx_tuntap.c ./nstx_tuntap.c
--- ../tmp-orig/nstx-1.1-beta6/nstx_tuntap.c 2004-06-27 23:43:34.000000000
+0200
+++ ./nstx_tuntap.c 2005-03-22 14:20:18.778279573 +0100
@@ -215,7 +215,7 @@
struct nstxmsg *nstx_select (int timeout)
{
- int peerlen;
+ unsigned peerlen;
fd_set set;
struct timeval tv;
static struct nstxmsg *ret = NULL;
diff -urN ../tmp-orig/nstx-1.1-beta6/nstxcd.c ./nstxcd.c
--- ../tmp-orig/nstx-1.1-beta6/nstxcd.c 2004-06-27 23:43:34.000000000 +0200
+++ ./nstxcd.c 2005-03-22 14:22:16.841302705 +0100
@@ -110,11 +110,11 @@
const char *data;
int datalen;
- pkt = dns_extractpkt (reply, len);
+ pkt = dns_extractpkt ((unsigned char*)reply, len);
if (!pkt)
return;
while ((data = dns_getanswerdata(pkt, &datalen))) {
- data = txt2data(data, &datalen);
+ data = (char*)txt2data((unsigned char*)data, &datalen);
nstx_handlepacket (data, datalen, &sendtun);
}
dequeueitem(pkt->id);
@@ -159,9 +159,9 @@
data += l;
datalen -= l;
- dns_addquery(pkt, dns_data2fqdn(nstx_encode(p, sizeof(nh)+l)));
+ dns_addquery(pkt, dns_data2fqdn(nstx_encode((unsigned char*)p,
sizeof(nh)+l)));
free(p);
- p = dns_constructpacket(pkt, &l);
+ p = (char*)dns_constructpacket(pkt, &l);
sendns(p, l, NULL);
free(p);
diff -urN ../tmp-orig/nstx-1.1-beta6/nstxd.c ./nstxd.c
--- ../tmp-orig/nstx-1.1-beta6/nstxd.c 2004-06-27 23:55:17.000000000 +0200
+++ ./nstxd.c 2005-03-22 14:14:39.530330481 +0100
@@ -172,7 +172,7 @@
dns_setid(pkt, q->id);
dns_settype(pkt, DNS_RESPONSE);
dns_addanswer(pkt, "\xb4\x00\x00\x00", 4, dns_addquery(pkt, q->name));
- buf = dns_constructpacket (pkt, &len);
+ buf = (char*)dns_constructpacket (pkt, &len);
sendns(buf, len, &q->peer);
free(buf);
}
@@ -188,7 +188,7 @@
if (msg) {
if (msg->src == FROMNS) {
- pkt = dns_extractpkt(msg->data, msg->len);
+ pkt = dns_extractpkt((unsigned char*)msg->data, msg->len);
if (pkt)
{
name = dns_getquerydata(pkt);
@@ -198,7 +198,7 @@
name);
queueitem(pkt->id, name, &msg->peer);
if ((data = dns_fqdn2data(name)) &&
- (buf = nstx_decode(data, &len)))
+ (buf = nstx_decode((unsigned char*)data, &len)))
{
nstx_handlepacket(buf, len, &sendtun);
}
@@ -220,7 +220,7 @@
len = dns_getfreespace(pkt, DNS_RESPONSE);
buf = dequeue_senditem(&len);
dns_addanswer(pkt, buf, len, link);
- buf = dns_constructpacket(pkt, &len);
+ buf = (char*)dns_constructpacket(pkt, &len);
sendns(buf, len, &qitem->peer);
}
timeoutqueue(do_timeout);
---------------------------------------
Received: (at 300878-close) by bugs.debian.org; 3 Apr 2005 16:24:34 +0000
>From [EMAIL PROTECTED] Sun Apr 03 09:24:34 2005
Return-path: <[EMAIL PROTECTED]>
Received: from gluck.debian.org [192.25.206.10]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DI7tp-0000IV-00; Sun, 03 Apr 2005 09:24:33 -0700
Received: from newraff.debian.org [208.185.25.31] (mail)
by gluck.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DI7tp-0002ow-00; Sun, 03 Apr 2005 10:24:33 -0600
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DI7Ye-0002dE-00; Sun, 03 Apr 2005 12:02:40 -0400
From: Matthew Garrett <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#300878: fixed in nstx 1.1-beta6-2
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sun, 03 Apr 2005 12:02:40 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: nstx
Source-Version: 1.1-beta6-2
We believe that the bug you reported is fixed in the latest version of
nstx, which is due to be installed in the Debian FTP archive:
nstx_1.1-beta6-2.diff.gz
to pool/main/n/nstx/nstx_1.1-beta6-2.diff.gz
nstx_1.1-beta6-2.dsc
to pool/main/n/nstx/nstx_1.1-beta6-2.dsc
nstx_1.1-beta6-2_i386.deb
to pool/main/n/nstx/nstx_1.1-beta6-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matthew Garrett <[EMAIL PROTECTED]> (supplier of updated nstx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 3 Apr 2005 16:36:20 +0100
Source: nstx
Binary: nstx
Architecture: source i386
Version: 1.1-beta6-2
Distribution: unstable
Urgency: low
Maintainer: Matthew Garrett <[EMAIL PROTECTED]>
Changed-By: Matthew Garrett <[EMAIL PROTECTED]>
Description:
nstx - Tunnel IP over DNS
Closes: 300878 302874
Changes:
nstx (1.1-beta6-2) unstable; urgency=low
.
* don't cast things to signed chars if you want numbers greater than 128
(closes: #302874)
* fix FTBFS with gcc 4.0 (thanks to Andreas Jochens for the patch)
(closes: #300878)
* don't assume chars are signed
Files:
ef133a103bd3224208cbdec7814ad177 565 net optional nstx_1.1-beta6-2.dsc
6a828c586f3a5e4ed1e7035cabf401af 7026 net optional nstx_1.1-beta6-2.diff.gz
414002e5ca28104041111ee5f98b1938 20856 net optional nstx_1.1-beta6-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFCUBFo7Hkv8l1YiTsRAmRDAJ0eQWqdKoJ8yKwNMdsLwu8otBjDegCfZCSw
QQqQIYL/DLIA1bQQ/TPm/zo=
=f82v
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
