Your message dated Tue, 05 Apr 2005 00:33:00 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#300150: fixed in chromium 0.9.12-7
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 17 Mar 2005 23:55:17 +0000
>From [EMAIL PROTECTED] Thu Mar 17 15:55:17 2005
Return-path: <[EMAIL PROTECTED]>
Received: from braint.aber.ac.uk [144.124.16.42] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DC4pg-0007iX-00; Thu, 17 Mar 2005 15:55:16 -0800
Received: from localhost ([127.0.0.1] helo=braint.aber.ac.uk)
        by braint.aber.ac.uk with esmtp (Exim 4.43)
        id 1DC4pd-0003yj-5f
        for [EMAIL PROTECTED]; Thu, 17 Mar 2005 23:55:13 +0000
Received: from ip4513.vpn.aber.ac.uk ([144.124.45.13] helo=[10.2.0.19])
        by braint.aber.ac.uk with esmtp (Exim 4.43)
        id 1DC4pB-0003wT-5n
        for [EMAIL PROTECTED]; Thu, 17 Mar 2005 23:54:46 +0000
Message-ID: <[EMAIL PROTECTED]>
Date: Thu, 17 Mar 2005 23:54:47 +0000
From: Alan Woodland <[EMAIL PROTECTED]>
User-Agent: Debian Thunderbird 1.0 (X11/20050118)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: [EMAIL PROTECTED]
Subject: SEGFAULT when running on 64bit platforms.
X-Enigmail-Version: 0.90.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig91ED9157141D8ED34F6ABF11"
X-Sophos-Scanned: from [EMAIL PROTECTED] virus scanned OK
X-UWA-Mid: 1DC4pB-0003wT-5n
X-UWA-Originating-IP: 144.124.45.13
X-UWA-Bounce-Filter: CHzJVT9mGQw
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
        version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig91ED9157141D8ED34F6ABF11
Content-Type: multipart/mixed;
 boundary="------------070007080405030505070706"

This is a multi-part message in MIME format.
--------------070007080405030505070706
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Package: chromium
Version: 0.9.12-5
Tags: patch
Severity: minor

I have several different machines all of which share the same home
directories. When I start chromium on a 64bit platform it segfaults in
HiScore::print(int skill). The reason this happens is because the
highscores file was first written by a 32bit platform. The precise cause
of the segfault is the failure of the call to localtime() on line 308,
which returns NULL (and sets errno). Currently chromium does not check
the return value of this call, and continues regardless, which clearly
is not appropriate behaviour for an application. I've attached a very
simple fix to this email, but it won't make the highscores portable,
just prevents it from crashing if localtime() fails.

Alan

--------------070007080405030505070706
Content-Type: text/plain;
 name="chromium-patch.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="chromium-patch.diff"

--- src/HiScore.cpp.orig        2005-03-17 23:41:17.798546920 +0000
+++ src/HiScore.cpp     2005-03-17 23:41:37.522548416 +0000
@@ -306,6 +306,8 @@
        for(int j = 0; j < HI_SCORE_HIST; j++)
        {
                tmptr = localtime(&hiScoreDate[skill][j]);
+               if (!tmptr)
+                       break;
                fprintf(stderr, "%02d/%02d/%04d %16s %d\n", 1+tmptr->tm_mon, 
tmptr->tm_mday, 1900+tmptr->tm_year,
                                hiScoreName[skill][j], 
(int)(hiScore[skill][j]));
        }

--------------070007080405030505070706--

--------------enig91ED9157141D8ED34F6ABF11
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCOhjK1FNW1LDdr0IRAuyjAKCatqIpIw9k6XuC0WkrCRcLB0GYcQCgotnv
RQR/h7ZbjAWDEug5bQ9L4yM=
=V+W4
-----END PGP SIGNATURE-----

--------------enig91ED9157141D8ED34F6ABF11--

---------------------------------------
Received: (at 300150-close) by bugs.debian.org; 5 Apr 2005 04:41:12 +0000
>From [EMAIL PROTECTED] Mon Apr 04 21:41:12 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DIfsG-00068v-00; Mon, 04 Apr 2005 21:41:12 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
        id 1DIfkK-0001iV-00; Tue, 05 Apr 2005 00:33:00 -0400
From: Mike Furr <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#300150: fixed in chromium 0.9.12-7
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Tue, 05 Apr 2005 00:33:00 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: chromium
Source-Version: 0.9.12-7

We believe that the bug you reported is fixed in the latest version of
chromium, which is due to be installed in the Debian FTP archive:

chromium_0.9.12-7.diff.gz
  to pool/main/c/chromium/chromium_0.9.12-7.diff.gz
chromium_0.9.12-7.dsc
  to pool/main/c/chromium/chromium_0.9.12-7.dsc
chromium_0.9.12-7_i386.deb
  to pool/main/c/chromium/chromium_0.9.12-7_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Furr <[EMAIL PROTECTED]> (supplier of updated chromium package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  5 Apr 2005 00:11:18 -0400
Source: chromium
Binary: chromium
Architecture: source i386
Version: 0.9.12-7
Distribution: unstable
Urgency: low
Maintainer: Mike Furr <[EMAIL PROTECTED]>
Changed-By: Mike Furr <[EMAIL PROTECTED]>
Description: 
 chromium   - Fast paced, arcade-style, scrolling space shooter
Closes: 300150
Changes: 
 chromium (0.9.12-7) unstable; urgency=low
 .
   * Fixed segv when reading highscore file(Closes: 300150)
     Thanks to Alan Woodland
Files: 
 3ae3fdaf46925d2df97ed501aab8f333 653 games optional chromium_0.9.12-7.dsc
 342c963e030d4c95d337d615df3f8d1c 12572 games optional chromium_0.9.12-7.diff.gz
 ee42c5b844e0815aae7a8c7deb7363bf 115940 games optional 
chromium_0.9.12-7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCUhCS7ZPKKRJLJvMRAixtAJ9+AYXa+58oCrqmS/kJw9689EUqpwCeODsT
UmwMOIUj2kMSqiZ/Qo7HlOo=
=zBes
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to