Your message dated Thu, 15 Mar 2007 14:02:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#409994: fixed in lilo 1:22.8-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: lilo
Version: 22.7.3-1.4
Severity: normal
Tags: patch

Hi,

my xsession's terminals (which I now and then run lilo from) happen
to inherit an inotify file descriptor from the window manager. Lilo
happens to encounter it when descending into /dev/fd, but unluckily
those fds return

] st_mode = 040600 (S_IFDIR | S_IRUSR | S_IWUSR)

when fstat()ed. This in turn causes lilo to try to descend into it,
which obviously fails:

] [EMAIL PROTECTED]:~# /sbin/lilo -v
] LILO version 22.7.3, Copyright (C) 1992-1998 Werner Almesberger
] Development beyond version 21 Copyright (C) 1999-2006 John Coffman
] Released 11-Aug-2006, and compiled at 10:06:46 on Feb  3 2007
] Debian GNU/Linux
] 
] Reading boot sector from /dev/hdf
] Fatal: opendir /dev/fd/3: Not a directory
] [EMAIL PROTECTED]:~# ll /dev/fd/
] total 0
] lrwx------ 1 root root 64 2007-02-06 23:21 0 -> /dev/pts/3
] lrwx------ 1 root root 64 2007-02-06 23:21 1 -> /dev/pts/3
] lrwx------ 1 root root 64 2007-02-06 23:21 2 -> /dev/pts/3
] lr-x------ 1 root root 64 2007-02-06 23:21 3 -> inotify
] lr-x------ 1 root root 64 2007-02-06 23:21 4 -> /proc/17696/fd
] [EMAIL PROTECTED]:~# strace -estat64 /sbin/lilo.real -v
] [...]
] stat64("/dev/fd/3", {st_mode=S_IFDIR|0600, st_size=0, ...}) = 0
] Fatal: opendir /dev/fd/3: Not a directory
] Process 17714 detached

While this behaviour of inotify fds is very strange, lilo shouldn't
descend into /dev/fd anyway. I'd suggest updating debian patch 17
to additionally exclude "fd" (besides ".udev"). An update of that dpatch
file is attached.


Regards,

Jan
#! /bin/sh -e
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Skip directories named .udev 

[ -f debian/patches/00patch-opts ] && . debian/patches/00patch-opts
patch_opts="${patch_opts:--f --no-backup-if-mismatch}"

if [ $# -ne 1 ]; then
    echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
    exit 1
fi
case "$1" in
       -patch) patch $patch_opts -p1 < $0;;
       -unpatch) patch $patch_opts -p1 -R < $0;;
        *)
                echo >&2 "`basename $0`: script expects -patch|-unpatch as 
argument"
                exit 1;;
esac

exit 0
@DPATCH@

diff -urN lilo-22.7.3.orig/device.c lilo-22.7.3/device.c
--- lilo-22.7.3.orig/device.c   2006-12-03 20:30:37.924145000 +0000
+++ lilo-22.7.3/device.c        2006-12-03 20:31:05.443946970 +0000
@@ -101,7 +101,7 @@
                return 1;
            }
            if (S_ISDIR(dev->st.st_mode) && strcmp(dir->d_name,".") &&
-             strcmp(dir->d_name,"..")) {
+             strcmp(dir->d_name,"..") && strcmp(dir->d_name, ".udev") && 
strcmp(dir->d_name, "fd")) { 
                for (walk = next; walk; walk = walk->next)
                    if (stat_equal(&walk->st,&st.st)) break;
                if (!walk && scan_dir(&st,dev,parent,number)) {

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: lilo
Source-Version: 1:22.8-2

We believe that the bug you reported is fixed in the latest version of
lilo, which is due to be installed in the Debian FTP archive:

lilo-doc_22.8-2_all.deb
  to pool/main/l/lilo/lilo-doc_22.8-2_all.deb
lilo_22.8-2.diff.gz
  to pool/main/l/lilo/lilo_22.8-2.diff.gz
lilo_22.8-2.dsc
  to pool/main/l/lilo/lilo_22.8-2.dsc
lilo_22.8-2_i386.deb
  to pool/main/l/lilo/lilo_22.8-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrés Roldán <[EMAIL PROTECTED]> (supplier of updated lilo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 15 Mar 2007 13:47:26 +0000
Source: lilo
Binary: lilo-doc lilo
Architecture: source i386 all
Version: 1:22.8-2
Distribution: testing-proposed-updates
Urgency: medium
Maintainer: Andrés Roldán <[EMAIL PROTECTED]>
Changed-By: Andrés Roldán <[EMAIL PROTECTED]>
Description: 
 lilo       - LInux LOader - The Classic OS loader can load Linux and others
 lilo-doc   - Documentation for LILO (LInux LOader)
Closes: 409478 409994 410241 411560 412190
Changes: 
 lilo (1:22.8-2) testing-proposed-updates; urgency=medium
 .
   * Acknowledging NMU. Thanks Christian.
     (Closes: #411560, #409478, #410241, #412190)
   * debian/patches/17_dont_scan_udev.dpatch:
     - Added again and updated to avoid checking '/dev/fd'.
       (Closes: #409994)
Files: 
 edc4900cfad7ee6a5bda45a86abbff08 725 admin optional lilo_22.8-2.dsc
 c449adeb9ed3ac13a81d53490194091b 213424 admin optional lilo_22.8-2.diff.gz
 30f4497f7e912e29cfba62b22a519915 369872 admin optional lilo_22.8-2_i386.deb
 7d64a823b1973a4c3b63fa9123d4a660 226932 doc optional lilo-doc_22.8-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFF+U+Q2OByS7KTlusRAvnPAKCEOVtiTfTKvugLPGbUPQUNtlHfAgCfSupq
6R4SxILctPU6vCCibyZJ1s8=
=BP/l
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to