Your message dated Tue, 24 Apr 2007 18:32:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#399313: fixed in libsql-abstract-perl 1.21-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: libsql-abstract-perl
Version: 1.21-2
Severity: minor
Tags: patch

When rebuilding libclass-dbi-abstractsearch-perl these warnings are
produced:

/usr/bin/make -C . OPTIMIZE="-g -Wall -O2" test
make[1]: Entering directory 
`/home/bart/src/libclass-dbi-abstractsearch-perl/libclass-dbi-abstractsearch-perl-0.07'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 
'blib/lib', 'blib/arch')" t/*.t
t/00_compile.....ok
t/01_abstract....Use of uninitialized value in string eq at 
/usr/share/perl5/SQL/Abstract.pm line 198.
Use of uninitialized value in concatenation (.) or string at 
/usr/share/perl5/SQL/Abstract.pm line 201.
ok
All tests successful.

The attached patch reduces the output to this:

/usr/bin/make -C . OPTIMIZE="-g -Wall -O2" test
make[1]: Entering directory 
`/home/bart/src/libclass-dbi-abstractsearch-perl/libclass-dbi-abstractsearch-perl-0.07'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 
'blib/lib', 'blib/arch')" t/*.t
t/00_compile.....ok
t/01_abstract....ok
All tests successful.

diff -ruN orig/libsql-abstract-perl-1.21/lib/SQL/Abstract.pm libsql-abstract-perl-1.21/lib/SQL/Abstract.pm
--- orig/libsql-abstract-perl-1.21/lib/SQL/Abstract.pm	2006-03-08 02:28:09.000000000 +0100
+++ libsql-abstract-perl-1.21/lib/SQL/Abstract.pm	2006-11-19 09:07:51.000000000 +0100
@@ -196,9 +196,9 @@
     my $label = shift;
 
     return $label
-      if $label eq '*';
+      if defined($label) && $label eq '*';
 
-    return $self->{quote_char} . $label . $self->{quote_char}
+    return $self->{quote_char} . (defined($label)?$label:'') . $self->{quote_char}
       if !defined $self->{name_sep};
 
     return join $self->{name_sep},

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message ---
Source: libsql-abstract-perl
Source-Version: 1.21-3

We believe that the bug you reported is fixed in the latest version of
libsql-abstract-perl, which is due to be installed in the Debian FTP archive:

libsql-abstract-perl_1.21-3.diff.gz
  to pool/main/libs/libsql-abstract-perl/libsql-abstract-perl_1.21-3.diff.gz
libsql-abstract-perl_1.21-3.dsc
  to pool/main/libs/libsql-abstract-perl/libsql-abstract-perl_1.21-3.dsc
libsql-abstract-perl_1.21-3_all.deb
  to pool/main/libs/libsql-abstract-perl/libsql-abstract-perl_1.21-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bart Martens <[EMAIL PROTECTED]> (supplier of updated libsql-abstract-perl 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 24 Apr 2007 19:55:31 +0200
Source: libsql-abstract-perl
Binary: libsql-abstract-perl
Architecture: source all
Version: 1.21-3
Distribution: unstable
Urgency: low
Maintainer: Bart Martens <[EMAIL PROTECTED]>
Changed-By: Bart Martens <[EMAIL PROTECTED]>
Description: 
 libsql-abstract-perl - Generate SQL from Perl data structures
Closes: 399313
Changes: 
 libsql-abstract-perl (1.21-3) unstable; urgency=low
 .
   * debian/patches/01_label_undef.diff: Added.  Closes: #399313.
Files: 
 f0f850fb5f70d8ce955ff4d73b5fdbad 647 perl optional 
libsql-abstract-perl_1.21-3.dsc
 997f9a6e67418a4d8ef116aa1f775ce8 2146 perl optional 
libsql-abstract-perl_1.21-3.diff.gz
 665ac47b99736042df1847bf1fed1cbd 37004 perl optional 
libsql-abstract-perl_1.21-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGLklobMaawmho9B8RAlcRAJ9ljuRC++Jifw+9ai6WtOyhM41LRACcD4R4
3TPbV4DC4lbw7jRJgge2sAY=
=FjOw
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to