Your message dated Sun, 29 Apr 2007 05:47:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#420428: fixed in ikiwiki 1.51
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: ikiwiki
Version: 1.50
Severity: important
Tags: patch

If you anonymously commit to the mercurial backend "$ipaddr" is added to $user
without being untainted. 

Attached patch fixes this. 

Thanks
Alex


--- System information. ---
Architecture: powerpc
Kernel:       Linux 2.6.17-rc5

Debian Release: lenny/sid
  200 unstable        debian.netcologne.de 
    1 experimental    debian.netcologne.de 

--- Package information. ---
Depends                         (Version) | Installed
=========================================-+-==============
perl                        (>= 5.6.0-16) | 5.8.8-7
libxml-simple-perl                        | 2.16-1
markdown                                  | 1.0.1-6
libtimedate-perl                          | 1.1600-5
libhtml-template-perl                     | 2.9-1
libhtml-scrubber-perl                     | 0.08-4
libcgi-formbuilder-perl      (>= 3.02.02) | 3.05-1
libtime-duration-perl                     | 1.02-1
libcgi-session-perl           (>= 4.14-1) | 4.20-1
libmail-sendmail-perl                     | 0.79-4
gcc                                       | 4:4.1.1-15
 OR c-compiler                            | 
libc6-dev                                 | 2.5-2
 OR libc-dev                              | 
libhtml-parser-perl                       | 3.56-1
liburi-perl                               | 1.35-2

--- ./IkiWiki/Rcs/mercurial.pm	2007-03-24 16:14:35.000000000 +0100
+++ /usr/share/perl5/IkiWiki/Rcs/mercurial.pm	2007-04-22 11:04:56.000000000 +0200
@@ -72,6 +72,7 @@
 		$user = possibly_foolish_untaint($user);
 	}
 	elsif (defined $ipaddr) {
+		$ipaddr = possibly_foolish_untaint($ipaddr); 
 		$user = "Anonymous from $ipaddr";
 	}
 	else {

--- End Message ---
--- Begin Message ---
Source: ikiwiki
Source-Version: 1.51

We believe that the bug you reported is fixed in the latest version of
ikiwiki, which is due to be installed in the Debian FTP archive:

ikiwiki_1.51.dsc
  to pool/main/i/ikiwiki/ikiwiki_1.51.dsc
ikiwiki_1.51.tar.gz
  to pool/main/i/ikiwiki/ikiwiki_1.51.tar.gz
ikiwiki_1.51_all.deb
  to pool/main/i/ikiwiki/ikiwiki_1.51_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <[EMAIL PROTECTED]> (supplier of updated ikiwiki package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 29 Apr 2007 00:01:23 -0400
Source: ikiwiki
Binary: ikiwiki
Architecture: source all
Version: 1.51
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <[EMAIL PROTECTED]>
Changed-By: Joey Hess <[EMAIL PROTECTED]>
Description: 
 ikiwiki    - a wiki compiler
Closes: 420428 421198
Changes: 
 ikiwiki (1.51) unstable; urgency=low
 .
   [ Joey Hess ]
   * Support setting svnpath to "" for wikis that are rooted at the top of
     their svn repositories, with no trunk directory.
   * Minor template improvements by Alessandro.
   * In mercurial backend, untaint ipaddr when using it as the user for the
     commit. Thanks, Alexander Wirt. Closes: #420428
   * Fix aggregator to not warn when a feed contains no body content at all.
   * Work around bug #420636 by, if XML::Parser crashes, running the feed
     content though Encode::decode_utf8.
 .
   [ Josh Triplett ]
   * Change basewiki CSS to not put a border around images used as links.
 .
   [ Joey Hess ]
   * Move the footer div to enclose tags and links too.
   * More style sheet updates, remove the hack that used the tags div to create
     the footer border.
   * Due to template changes and style sheet changes that depend on them,
     wiki rebuilds are recommended on upgrade to this version.
   * Avoid .svn directories when installing from svn checkout.
   * Fix sending of commit mails when new pages are added via the web.
   * Add user(name) to the PageSpec for commit subscriptions.
   * pagespec_match() has changed to take named parameters, to better allow
     for extended pagespecs. The old calling convention will still work for
     back-compat for now.
   * The calling convention for functions in the IkiWiki::PageSpec namespace
     has changed so they are passed named parameters.
   * Plugin interface version increased to 2.00 since I don't anticipate any
     more interface changes before 2.0.
   * Updated Gujarati translation from Kartik Mistry. Closes: #421198
   * Make pagespec_match return an object that can be stringified to tell
     the reason why the match failed or succeeded.
   * Add testpagespec plugin, which might be useful to see why a pagespec isn't
     working as desired.
 .
   [ Josh Triplett ]
   * Fix bestlink to use pagecase for pages in userdir, to support pages
     with non-lowercase filenames.
 .
   [ Joey Hess ]
   * Include wikiname in syslogged messages.
   * Updated Polish translation from Pawel Tecza.
   * Updated Czech translation from Miroslav Kure.
   * Updated Spanish translation from Victor Moral.
   * Apply patch from hb that uses the full path to a file when adding a file
     using the mercurial backend. Not 100% sure why it failed w/o the full
     path, but this still passes the test suite, and indeed, is how the test
     suite calls hg add.
Files: 
 13318910428a8c5cc692a32386152b00 870 web optional ikiwiki_1.51.dsc
 28e8e5d3830833a3ed5b9934407452a3 418926 web optional ikiwiki_1.51.tar.gz
 9fcd3131a4f753b61ecfdbf5c4b35ea1 537604 web optional ikiwiki_1.51_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGNC1D2tp5zXiKP0wRApYdAKCPIizO85SkxjZNhS6x5XD0uyZP3wCeMmPf
uzQNMCKFMhv8kgLBZP+6fuw=
=nqoI
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to