Your message dated Sun, 29 Apr 2007 08:47:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#421229: fixed in dasher 4.4.1-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: dasher
Version: 4.4.1-1
Usertags: ftbfs-gcc-4.3
Tags: patch
Your package fails to build with GCC 4.3. Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning. In GCC 4.3, the C++ header
dependencies have been cleaned up. The advantage of this is that
programs will compile faster. The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC). Some background of this can be found at
http://gcc.gnu.org/PR28080
There are some new failures in the new upstream version you uploaded.
In fact, dasher does something really evil. WordLanguageModel.cpp
fails to build because it uses atoi without including cstdlib.
However, when I added the #include we started failing in an even worse
way. I found out that essentially (through local includes, in the end
of AlphIO.h) dasher does:
namespace expat {
#include <cstdlib>
}
#include <cstdlib>
and this horribly fails. I "fixed" this by including cstdlib in
AlphIO.h and ColourIO.h before the horrible namespace'd #include.
You can reproduce this problem with gcc-snapshot (20070326-1 or higher)
from unstable. (Currently not available for i386, but for amd64, powerpc
and ia64. I hope to have i386 binaries in the archive in the near
future.)
> Automatic build of dasher_4.4.1-1 on em64t by sbuild/amd64 0.53
...
> g++ -DHAVE_CONFIG_H -I. -I. -I../../.. -g -Wall -O2 -Wall
> -Wno-non-virtual-dtor -c -o DictLanguageModel.o DictLanguageModel.cpp
> DictLanguageModel.cpp: In member function
> 'Dasher::CDictLanguageModel::CDictnode*
> Dasher::CDictLanguageModel::AddSymbolToNode(Dasher::CDictLanguageModel::CDictnode*,
> Dasher::symbol, int*)':
> DictLanguageModel.cpp:69: error: 'USHRT_MAX' was not declared in this scope
> make[5]: *** [DictLanguageModel.o] Error 1
--- Src/DasherCore/LanguageModelling/DictLanguageModel.cpp~ 2007-04-27
09:04:33.000000000 +0000
+++ Src/DasherCore/LanguageModelling/DictLanguageModel.cpp 2007-04-27
09:04:39.000000000 +0000
@@ -13,6 +13,7 @@
#include <stack>
#include <iostream>
#include <fstream>
+#include <climits>
using namespace Dasher;
using namespace std;
--- Src/DasherCore/LanguageModelling/WordLanguageModel.cpp~ 2007-04-27
09:05:39.000000000 +0000
+++ Src/DasherCore/LanguageModelling/WordLanguageModel.cpp 2007-04-27
09:07:40.000000000 +0000
@@ -11,6 +11,7 @@
#include "PPMLanguageModel.h"
#include <cmath>
+#include <cstdlib>
#include <stack>
#include <iostream>
#include <fstream>
--- Src/DasherCore/Alphabet/AlphIO.h~ 2007-04-27 09:26:06.000000000 +0000
+++ Src/DasherCore/Alphabet/AlphIO.h 2007-04-27 09:26:16.000000000 +0000
@@ -13,6 +13,7 @@
//#include "Alphabet.h"
#include "GroupInfo.h"
+#include <cstdlib>
#include <string>
#include <map>
#include <vector>
--- Src/DasherCore/ColourIO.h~ 2007-04-27 09:29:37.000000000 +0000
+++ Src/DasherCore/ColourIO.h 2007-04-27 09:29:54.000000000 +0000
@@ -11,6 +11,7 @@
#include "DasherTypes.h"
+#include <cstdlib>
#include <string>
#include <map>
#include <vector>
--- Src/DasherCore/UserLocation.cpp~ 2007-04-27 09:34:42.000000000 +0000
+++ Src/DasherCore/UserLocation.cpp 2007-04-27 09:34:49.000000000 +0000
@@ -3,6 +3,7 @@
#include "UserLocation.h"
+#include <cstdlib>
#include <sys/timeb.h>
// Track memory leaks on Windows to the line that new'd the memory
--- Src/DasherCore/XMLUtil.cpp~ 2007-04-27 09:35:46.000000000 +0000
+++ Src/DasherCore/XMLUtil.cpp 2007-04-27 09:35:52.000000000 +0000
@@ -3,6 +3,7 @@
#include "XMLUtil.h"
+#include <cstdlib>
#include <sys/types.h>
#include <sys/stat.h>
--
Martin Michlmayr
http://www.cyrius.com/
--- End Message ---
--- Begin Message ---
Source: dasher
Source-Version: 4.4.1-2
We believe that the bug you reported is fixed in the latest version of
dasher, which is due to be installed in the Debian FTP archive:
dasher-data_4.4.1-2_all.deb
to pool/main/d/dasher/dasher-data_4.4.1-2_all.deb
dasher_4.4.1-2.diff.gz
to pool/main/d/dasher/dasher_4.4.1-2.diff.gz
dasher_4.4.1-2.dsc
to pool/main/d/dasher/dasher_4.4.1-2.dsc
dasher_4.4.1-2_i386.deb
to pool/main/d/dasher/dasher_4.4.1-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alan Baghumian <[EMAIL PROTECTED]> (supplier of updated dasher package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 29 Apr 2007 07:49:41 +0330
Source: dasher
Binary: dasher-data dasher
Architecture: source i386 all
Version: 4.4.1-2
Distribution: unstable
Urgency: low
Maintainer: Debian GNOME Maintainers <[EMAIL PROTECTED]>
Changed-By: Alan Baghumian <[EMAIL PROTECTED]>
Description:
dasher - A graphical predictive text input system
dasher-data - Data files for dasher
Closes: 421229
Changes:
dasher (4.4.1-2) unstable; urgency=low
.
* Added 01_missing-includes.patch (Closes: #421229).
- Fixes FTBFS with GCC 4.3, thanks Martin Michlmayr
Files:
0bfbec6666a970f228eac6d8293b5cea 1218 x11 optional dasher_4.4.1-2.dsc
c381a19d99d5b484cecc65d7a3abb623 5161 x11 optional dasher_4.4.1-2.diff.gz
16b5d0819c976845f36f465fcc07520d 7245126 x11 optional
dasher-data_4.4.1-2_all.deb
87ed3a4c9e5b63951b9e860b08a1e0f1 338058 x11 optional dasher_4.4.1-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGNElN4VUX8isJIMARAp1nAJ4tIZuKlgRwwpvuPC3syOC5TPo2iwCfTuRx
jVUGbNLWNCRKgbcn578f/14=
=iMxR
-----END PGP SIGNATURE-----
--- End Message ---
