Your message dated Sat, 19 May 2007 18:17:17 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#425094: fixed in pommed 1.5~dfsg-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: pommed
Version: 1.4~dfsg-1
Severity: normal

(This is actually a report against the powerpc version, but reportbug
runs on my other machine)

pommed 1.4 fails to find the lmu in my PowerBook5,4.

On line 472 of pommed/pmac/kbd_backlight.c
of_find_node_by_type("lmu-controller", 0) returns NULL
Changing it to 
of_find_node_by_name("lmu-controller", 0) succeeds, and the keyboard
backlight operates fine.

I don't know if it's just the PowerBook 5,4, but here's the relevant
device-tree section:

su:~# for d in `find /proc/device-tree -name 'lmu-controller*' -type d`/*; do 
echo $d; hd $d; done
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL 
PROTECTED]/linux,phandle
00000000  ff 96 5b 18                                       |..[.|
00000004
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/name
00000000  6c 6d 75 2d 63 6f 6e 74  72 6f 6c 6c 65 72 00     |lmu-controller.|
0000000f
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/reg
00000000  00 00 00 84                                       |....|
00000004

As you can see, there's no 'type' entry in the directory for
of_find_node_by_type to match.

Assuming of_find_node_by_type works on other machines, the best
way would prolly be to fall back to of_find_node_by_name, and if
that also returns NULL, fail.

I didn't include a patch, it seems kinda trivial, and for my local
build (the PowerPC build of 1.4 has been queued on a buildd somewhere
for nearly two weeks) changing the of_find_node call was sufficient.

Oh, and thanks for pommed. I'm glad of a pbbuttonsd replacement that
doesn't kill the interface part when restarting the backend, and that
doesn't exclusively lock my sound interface if I change the volume at
the wrong time. ^_^

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-- 
Paul "TBBle" Hampson, [EMAIL PROTECTED]

Shorter .sig for a more eco-friendly paperless office.

Attachment: pgpja4DTDnjsN.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: pommed
Source-Version: 1.5~dfsg-1

We believe that the bug you reported is fixed in the latest version of
pommed, which is due to be installed in the Debian FTP archive:

gpomme_1.5~dfsg-1_amd64.deb
  to pool/main/p/pommed/gpomme_1.5~dfsg-1_amd64.deb
pommed_1.5~dfsg-1.diff.gz
  to pool/main/p/pommed/pommed_1.5~dfsg-1.diff.gz
pommed_1.5~dfsg-1.dsc
  to pool/main/p/pommed/pommed_1.5~dfsg-1.dsc
pommed_1.5~dfsg-1_amd64.deb
  to pool/main/p/pommed/pommed_1.5~dfsg-1_amd64.deb
pommed_1.5~dfsg.orig.tar.gz
  to pool/main/p/pommed/pommed_1.5~dfsg.orig.tar.gz
wmpomme_1.5~dfsg-1_amd64.deb
  to pool/main/p/pommed/wmpomme_1.5~dfsg-1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien BLACHE <[EMAIL PROTECTED]> (supplier of updated pommed package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 19 May 2007 20:04:02 +0200
Source: pommed
Binary: pommed wmpomme gpomme
Architecture: source amd64
Version: 1.5~dfsg-1
Distribution: unstable
Urgency: low
Maintainer: Julien BLACHE <[EMAIL PROTECTED]>
Changed-By: Julien BLACHE <[EMAIL PROTECTED]>
Description: 
 gpomme     - graphical client for pommed
 pommed     - Apple laptops hotkeys event handler
 wmpomme    - WindowMaker dockapp client for pommed
Closes: 422857 425094
Changes: 
 pommed (1.5~dfsg-1) unstable; urgency=low
 .
   * New upstream release.
     + Use eject(1) again for CD ejection (closes: #422857).
     + Fallback to identifying the LMU controller by name (closes: #425094).
   * debian/control:
     + Depend on eject again.
Files: 
 2af0f55d1494cd08debcaef07d33f763 857 utils optional pommed_1.5~dfsg-1.dsc
 c263149495f45288dc919a706c9c49a3 373778 utils optional 
pommed_1.5~dfsg.orig.tar.gz
 430c9cf1786604c2ec56fbd66438f062 4815 utils optional pommed_1.5~dfsg-1.diff.gz
 5d6e9f2da3d185aceb020a1e1593b268 34808 utils optional 
pommed_1.5~dfsg-1_amd64.deb
 0c1669490e9682f9395f1d9c191ac1f3 312996 utils optional 
gpomme_1.5~dfsg-1_amd64.deb
 1f59c65a72215b34207ca11851f45aba 17626 utils optional 
wmpomme_1.5~dfsg-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGTzyQzWFP1/XWUWkRAkvjAKDSM6FqX7p9uECzXk0amaOlnghjygCfSmS1
3Ul3GtlsO/tx9+GFtoZUtUM=
=ynXX
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to