Your message dated Thu, 7 Jun 2007 09:30:18 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Bug#427878: /usr/share/mdadm/mkconf should also keep previous 
CREATE, HOMEHOST & PROGRAM
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: mdadm
Version: 2.5.6-9

I think that /usr/share/mdadm/mkconf now only keeps the MAILADDR from the previous mdadm.conf . IMHO it should also do this for the options CREATE, HOMEHOST and PROGRAM . In this way one can simply use mkconf to regenerate a new mdadm.conf without worrying about settings getting lost.

--
Ing. A.C.J. van Amersfoort (Arno)
Department Of Electronics (ELD, k1007)
Huygens Laboratory
Leiden University
P.O. Box 9504
Niels Bohrweg 2
2333 CA Leiden
The Netherlands
----------------------------------------------------------------
Phone : +31-(0)71-527.1894   Fax: +31-(0)71-527.5819
E-mail: [EMAIL PROTECTED]
----------------------------------------------------------------
Arno's (Linux firewall) homepage: http://rocky.eld.leidenuniv.nl









--- End Message ---
--- Begin Message ---
Version: 2.6.1-1

This has been fixed in 2.6.1-1:

  
http://svn.debian.org/wsvn/pkg-mdadm?op=comp&compare%5B0%5D=%2Fmdadm%2Ftrunk%2Fdebian%2Fmkconf&compare%5B1%5D=%2Fmdadm%2Ftrunk%2Fdebian%2Fmkconf&compare_rev%5B0%5D=314&compare_rev%5B1%5D=324&comparesubmit=Compare%20Paths&manualorder=1&op=comp&sc=0

Thanks for the bug report still.

Index: mkconf
===================================================================
--- mkconf  (revision 314)
+++ mkconf  (revision 324)
@@ -22,9 +22,17 @@
   MAILADDR="$MDADM_MAILADDR__"
 else
   # preserve existing MAILADDR
-  MAILADDR="$(sed -ne 's/MAILADDR //p' $CONFIG 2>/dev/null || echo root)"
+  MAILADDR="$(sed -ne 's/^MAILADDR //p' $CONFIG 2>/dev/null)" || :
 fi
 
+# save existing values as defaults
+if [ -r "$CONFIG" ]; then
+  DEVICE="$(sed -ne 's/^DEVICE //p' $CONFIG)"
+  CREATE="$(sed -ne 's/^CREATE //p' $CONFIG)"
+  HOMEHOST="$(sed -ne 's/^HOMEHOST //p' $CONFIG)"
+  PROGRAM="$(sed -ne 's/^PROGRAM //p' $CONFIG)"
+fi
+
 generate=0
 [ "${1:-}" = force-generate ] && rm -f $CONFIG
 case "${1:-}" in
@@ -50,19 +58,27 @@
 
 # by default, scan all partitions (/proc/partitions) for MD superblocks.
 # alternatively, specify devices to scan, using wildcards if desired.
-DEVICE partitions
+DEVICE ${DEVICE:-partitions}
 
 # auto-create devices with Debian standard permissions
-CREATE owner=root group=disk mode=0660 auto=yes
+CREATE ${CREATE:-owner=root group=disk mode=0660 auto=yes}
 
 # automatically tag new arrays as belonging to the local system
-HOMEHOST <system>
+HOMEHOST ${HOMEHOST:-<system>}
 
 # instruct the monitoring daemon where to send mail alerts
-MAILADDR $MAILADDR
+MAILADDR ${MAILADDR:-root}
 
 _eof
 
+if [ -n "$PROGRAM" ]; then
+  cat <<-_eof
+ # program to run when mdadm monitor detects potentially interesting events
+ PROGRAM ${PROGRAM}
+ 
+ _eof
+fi
+
 error=0
 if [ ! -r /proc/mdstat ]; then
   echo W: $ME: MD subsystem is not loaded, thus I cannot scan for arrays. >&2

-- 
 .''`.   martin f. krafft <[EMAIL PROTECTED]>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems

Attachment: signature.asc
Description: Digital signature (GPG/PGP)


--- End Message ---

Reply via email to