Your message dated Tue, 26 Jun 2007 06:17:03 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#422759: fixed in grub 0.97-29 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: grub Version: 0.97-27 Severity: normal If a suffix has non-numeric and numeric characters, CompareVersions() will replace the non-numeric characters with '99' but the numeric characters will remain appended. I ran into this issue when comparing 2.6.18-4-amd64 and 2.6.18-4-telco-amd64. CompareVersions converted these into the following components: v1: 2 6 18 4 99 9964 v2: 2 6 18 4 9964 It converted 'amd' to 99, while I think the intent was to convert 'amd64' to 99. The patch below fixes this by converting any string that contains a non-numeric character to '99'. It seems to do what I would expect for the various test cases I threw at it. This table compares the sort order produced by both versions of update-grub executing on the same set of kernel names. original w/ my patch ---------------------------------------------------------------------- /boot/vmlinuz-2.6.20-1-686 /boot/vmlinuz-2.6.20-1-686 /boot/vmlinuz-2.6.18-4-amd64 /boot/vmlinuz-2.6.18-4-686 /boot/vmlinuz-2.6.18-4-dannf10 /boot/vmlinuz-2.6.18-4-telco-amd64 /boot/vmlinuz-2.6.18-4-dannf2 /boot/vmlinuz-2.6.18-4-dannf10 /boot/vmlinuz-2.6.18-4-686 /boot/vmlinuz-2.6.18-4-dannf2 /boot/vmlinuz-2.6.18-4-telco-amd64 /boot/vmlinuz-2.6.18-4-amd64 /boot/vmlinuz-2.6.18-4-rc10 /boot/vmlinuz-2.6.18-4-rc10 /boot/vmlinuz-2.6.18-4-rc2 /boot/vmlinuz-2.6.18-4-rc2 /boot/vmlinuz-2.4.32 /boot/vmlinuz-2.4.32 --- /usr/sbin/update-grub~ 2007-03-29 23:41:47.000000000 -0600 +++ /usr/sbin/update-grub 2007-05-07 23:31:47.000000000 -0600 @@ -484,9 +484,9 @@ CompareVersions() # rc = -40 # test = -60 # others are given 99 - v1=$(echo $v1 | sed -e 's! k7! 786 !g' -e 's! ac! 50 !g' -e 's! rc! -40 !g' -e 's! pre! -50 !g' -e 's! test! -60 !g' -e 's![^-0-9 ]\+!99!g') + v1=$(echo $v1 | sed -e 's! k7! 786 !g' -e 's! ac! 50 !g' -e 's! rc! -40 !g' -e 's! pre! -50 !g' -e 's! test! -60 !g' -e 's![^ ]*[^-0-9 ][^ ]*!99!g') - v2=$(echo $v2 | sed -e 's! k7! 786 !g' -e 's! ac! 50 !g' -e 's! rc! -40 !g' -e 's! pre! -50 !g' -e 's! test! -60 !g' -e 's![^-0-9 ]\+!99!g') + v2=$(echo $v2 | sed -e 's! k7! 786 !g' -e 's! ac! 50 !g' -e 's! rc! -40 !g' -e 's! pre! -50 !g' -e 's! test! -60 !g' -e 's![^ ]*[^-0-9 ][^ ]*!99!g') result=0; v1finished=0; v2finished=0; while [ $result -eq 0 ] && [ $v1finished -eq 0 ] && [ $v2finished -eq 0 ]; -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.20-1-686 (SMP w/1 CPU core) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/bash Versions of packages grub depends on: ii libc6 2.5-5 GNU C Library: Shared libraries ii libncurses5 5.5-5 Shared libraries for terminal hand grub recommends no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: grub Source-Version: 0.97-29 We believe that the bug you reported is fixed in the latest version of grub, which is due to be installed in the Debian FTP archive: grub-disk_0.97-29_all.deb to pool/main/g/grub/grub-disk_0.97-29_all.deb grub-doc_0.97-29_all.deb to pool/main/g/grub/grub-doc_0.97-29_all.deb grub_0.97-29.diff.gz to pool/main/g/grub/grub_0.97-29.diff.gz grub_0.97-29.dsc to pool/main/g/grub/grub_0.97-29.dsc grub_0.97-29_amd64.deb to pool/main/g/grub/grub_0.97-29_amd64.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Robert Millan <[EMAIL PROTECTED]> (supplier of updated grub package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Tue, 26 Jun 2007 07:48:57 +0200 Source: grub Binary: grub-disk grub grub-doc Architecture: source amd64 all Version: 0.97-29 Distribution: unstable Urgency: low Maintainer: Grub Maintainers <[EMAIL PROTECTED]> Changed-By: Robert Millan <[EMAIL PROTECTED]> Description: grub - GRand Unified Bootloader grub-disk - GRUB bootable disk image (dummy package) grub-doc - Documentation for GRand Unified Bootloader Closes: 250938 352731 399168 422759 424510 429576 Changes: grub (0.97-29) unstable; urgency=low . [ Otavio Salvador ] * update-grub: Improve sorting with mixed numeric and non-numeric characters. Thanks dann frazier <[EMAIL PROTECTED]> for the patch. Closes: #422759 . [ Robert Millan ] * Add myself to Uploaders. * update-grub: Remove core.img handling. It was becoming meaningless without presence of the grub-pc package. * control (Architecture): Replace any-* arches with the old, boring, hardcoded list. (Closes: #424510) * Get rid of grub-disk, mkbimage and grub-floppy. They're deprecated in favour of grub-rescue-pc now. (Closes: #399168, #250938, #429576, #352731) Files: 80da51b24a3cbfafc54f1fa86b81079f 926 admin optional grub_0.97-29.dsc 40786e07bd2b890d0bfdb3609fcad7a6 73048 admin optional grub_0.97-29.diff.gz 06a85be9cdc5560b9063d8babcc34d54 818678 admin optional grub_0.97-29_amd64.deb b05c212fe4c5f1793cf6ac0d6c533b1f 112406 admin optional grub-disk_0.97-29_all.deb 72137541b64c35f923c9556264a6cdba 273450 doc optional grub-doc_0.97-29_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGgK38C19io6rUCv8RAjeVAJ9+kqm+s1KwL629sBQoZTv7SGBK5wCfczR6 T4Y9UlHRJaOc9LaNumqlhx4= =vjIy -----END PGP SIGNATURE-----
--- End Message ---
