Your message dated Thu, 26 Jul 2007 03:32:03 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#431091: fixed in emacs-goodies-el 26.13-1 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: emacs-goodies-el Version: 26.11-1 Severity: minor Tags: patch Hello, with respect to the close statement, `debian-changelog-close-bug' has two different results depending on `debian-bug-open-alist' being nil or an alist: - nil, lowercase c and no final full stop [debian-changelog-mode.el] * WHATEVER (closes: #NNN) - alist, uppercase C and a final full stop [debian-bug.el] * Bug fix: "WHATEVER", thanks to WHOEVER (Closes: #NNN). I think that the result should be consistent [1] and AFAIK both statements are correct [2]. Thus, the attached patch solves it adding a new variable to control the preferred close statement [3][4]:. [debian-bug.el] --8<---------------cut here---------------start------------->8--- --- debian-bug.el.ORG 2007-06-25 12:27:45.000000000 +0100 +++ debian-bug.el 2007-06-25 12:32:53.000000000 +0100 @@ -349,6 +349,29 @@ ;; :group 'debian-bug ;; :type 'boolean) + +;; this solves the consistency problem with `debian-changelog-close-bug' +;; as per bug #FILL-IN +(defcustom debian-changelog-close-bug-statement "(closes: #%s)" + "The text to be inserted to close a bug. `%s' is replaced by +the bug number." + :group 'debian-changelog + :type 'string) + +;; this function is stolen from emacs/lisp/calendar/icalendar.el, +;; necessary to replace "%s" with the bug number in the above +;; `debian-changelog-close-bug-statement' +(defsubst debian-changelog--rris (&rest args) + "Replace regular expression in string. +Pass ARGS to `replace-regexp-in-string' (GNU Emacs) or to +`replace-in-string' (XEmacs)." + ;; XEmacs: + (if (fboundp 'replace-in-string) + (save-match-data ;; apparently XEmacs needs save-match-data + (apply 'replace-in-string args)) + ;; Emacs: + (apply 'replace-regexp-in-string args))) + (defvar debian-bug-minor-mode nil) (defvar debian-bug-minor-mode-map nil "Keymap for `debian-bug' minor mode.") @@ -1824,7 +1847,9 @@ "\", thanks to " (debian-bug-rfc2047-decode-string (match-string 1)) - " (Closes: #" bugnumber ")."))) + " " (debian-changelog--rris + "%s" bugnumber + debian-changelog-close-bug-statement)))) (setq bug-open-alist (cons (list bugnumber shortdescription) bug-open-alist))) --8<---------------cut here---------------end--------------->8--- [debian-changelog-mode.el] --8<---------------cut here---------------start------------->8--- --- debian-changelog-mode.el.ORG 2007-06-25 10:56:52.000000000 +0100 +++ debian-changelog-mode.el 2007-06-25 12:33:17.000000000 +0100 @@ -805,7 +805,9 @@ (insert (cadr (assoc bug-number debian-bug-open-alist))) (fill-paragraph nil)) (t - (save-excursion (insert " (closes: #" bug-number ")")) + (save-excursion + (insert " " (debian-changelog--rris + "%s" bug-number debian-changelog-close-bug-statement))) (message "Enter a brief description of what was done here.")))) ;; --8<---------------cut here---------------end--------------->8--- While the patch to debian-changelog-mode.el should be applied after the patch at bug #430517 [5], it applies with a successful hunk to debian-changelog-mode.el version 26.11-1, too. Both patches has been tested on emacs-snapshot-nox with a new and not customized user. Thx, bye, Gismo / Luca Footnotes: [1] as I don't see why the same maintainer would use two different statements [2] and the statement without the parenthesis is valid, too [3] while the new variable belongs to debian-changelog-mode.el, it's better to define it in debian-bug.el, so we don't clutter debian-bug.el with something like (untested): (setq shortdescription (concat "Bug fix: \"" shortdescription "\", thanks to " (debian-bug-rfc2047-decode-string (match-string 1)) " " (if debian-changelog-close-bug-statement (debian-changelog--rris "%s" bugnumber debian-changelog-close-bug-statement) "(Closes: #" bugnumber ")."))) [4] I'm not sure it's correct to define in debian-bug.el variables and functions with a debian-changelog- prefix [5] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430517 -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.21-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages emacs-goodies-el depends on: ii bash 3.1dfsg-8 The GNU Bourne Again SHell ii emacs-snapshot-gtk [emacsen 1:20070617-1 The GNU Emacs editor (with GTK+ 2. ii emacs-snapshot-nox [emacsen 1:20070617-1 The GNU Emacs editor (without X su Versions of packages emacs-goodies-el recommends: pn dict <none> (no description available) pn perl-doc <none> (no description available) ii wget 1.10.2-3 retrieves files from the web -- debconf-show failed
--- End Message ---
--- Begin Message ---Source: emacs-goodies-el Source-Version: 26.13-1 We believe that the bug you reported is fixed in the latest version of emacs-goodies-el, which is due to be installed in the Debian FTP archive: debian-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/debian-el_26.13-1_all.deb devscripts-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/devscripts-el_26.13-1_all.deb dpkg-dev-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/dpkg-dev-el_26.13-1_all.deb emacs-goodies-el_26.13-1.diff.gz to pool/main/e/emacs-goodies-el/emacs-goodies-el_26.13-1.diff.gz emacs-goodies-el_26.13-1.dsc to pool/main/e/emacs-goodies-el/emacs-goodies-el_26.13-1.dsc emacs-goodies-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/emacs-goodies-el_26.13-1_all.deb emacs-goodies-el_26.13.orig.tar.gz to pool/main/e/emacs-goodies-el/emacs-goodies-el_26.13.orig.tar.gz gnus-bonus-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/gnus-bonus-el_26.13-1_all.deb vm-bonus-el_26.13-1_all.deb to pool/main/e/emacs-goodies-el/vm-bonus-el_26.13-1_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Peter S Galbraith <[EMAIL PROTECTED]> (supplier of updated emacs-goodies-el package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Wed, 25 Jul 2007 21:53:16 -0400 Source: emacs-goodies-el Binary: gnus-bonus-el dpkg-dev-el vm-bonus-el emacs-goodies-el debian-el devscripts-el Architecture: source all Version: 26.13-1 Distribution: unstable Urgency: low Maintainer: Peter S Galbraith <[EMAIL PROTECTED]> Changed-By: Peter S Galbraith <[EMAIL PROTECTED]> Description: debian-el - Emacs helpers specific to Debian users devscripts-el - Emacs wrappers for the commands in devscripts dpkg-dev-el - Emacs helpers specific to Debian development emacs-goodies-el - Miscellaneous add-ons for Emacs gnus-bonus-el - Miscellaneous add-ons for Gnus vm-bonus-el - Miscellaneous add-ons for VM Closes: 371861 430788 431091 432100 434491 Changes: emacs-goodies-el (26.13-1) unstable; urgency=low . * Bug fix: "gnus-bonus-el does not know about emacs22", thanks to Mikhail Gusarov (Closes: #434491). * Bug fix: "emacs-goodies-el: Please prefer emacs22 as first alternative", thanks to Sven Joachim (Closes: #432100). * Bug fix: "[debian-bug.el, debian-changelog-mode.el] please be consistent for the close statement", thanks to Luca Capello (Closes: #431091). * Bug fix: "cyclebuffer.el too old global-set-key example", thanks to Dan Jacobson (Closes: #371861). * Bug fix: "emacs-goodies-el: df-mode break minor-mode-alist and function using it". Added 50_df_minor_mode_alist.dpatch thanks to Remi Vanicat (Closes: #430788). Files: a63ad70d82e6c2ef5192fdd91715ca04 875 editors optional emacs-goodies-el_26.13-1.dsc c4bd2edc085c81c806be25ee392dbdcd 1058390 editors optional emacs-goodies-el_26.13.orig.tar.gz eea7d0815c6c39fd8e468dafc07195ff 102957 editors optional emacs-goodies-el_26.13-1.diff.gz cf7fe34743edbf336d9ee6d93cee22cc 937764 editors optional emacs-goodies-el_26.13-1_all.deb b0c71c81fc42b9c687cff5ce4f0d8fb3 73416 news optional gnus-bonus-el_26.13-1_all.deb 4dbab3c51b348e99e2db35e4fa9de432 33226 editors optional devscripts-el_26.13-1_all.deb 1dd371321c6c7ac24c147f43bcfa8fdf 86818 utils optional debian-el_26.13-1_all.deb 43ffc97b61277287e16297e389fc3704 63000 utils optional dpkg-dev-el_26.13-1_all.deb fc781df1b7131a71a6f1c125c6936a7a 57416 mail optional vm-bonus-el_26.13-1_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQCVAwUBRqgTXbwVH8jSqROhAQL1HwQApeWoXhqt6rPbVBXywg1oOAihxdtU+beS 04LLjwnVuPMV1/W9kkjay1bg2+1N6h+njP3mKCK3tLofxFPneMcImRbi9D3E2aea TbUKNnd89YDlG+0xId0iX2ZVjyPvVtqe7ridqjtjO/OEnlHDrcF0CWcCH+i1YjXp R6N9Q6rC+8E= =zqJ5 -----END PGP SIGNATURE-----
--- End Message ---
