Your message dated Sat, 18 Aug 2007 14:47:02 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#337299: fixed in silo 1.4.13a-1 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: silo Version: 1.4.9-1rs1 Severity: normal Tags: patch Hi, doing an "ls -l" in some directories caused the system to stall before printing the date of certain entries. This is caused by the algorithm that computes the individual parts of the date: ======================================================================= [...] mtime = array[i]->mtime; /* Following code taken from glibc */ day = mtime / (60 * 60 * 24); hour = mtime % (60 * 60 * 24); hour /= 60; min = hour % 60; hour /= 60; year = 1970; #define ISLEAP(year) ((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0)) #define DIV(a, b) ((a) / (b) - ((a) % (b) < 0)) #define LEAPS_THRU_END_OF(y) (DIV (y, 4) - DIV (y, 100) + DIV (y, 400)) while (day < 0 || day >= (ISLEAP (year) ? 366 : 365)) { /* Guess a corrected year, assuming 365 days per year. */ long int yg = year + day / 365 - (day % 365 < 0); /* Adjust DAYS and Y to match the guessed year. */ day -= ((yg - year) * 365 + LEAPS_THRU_END_OF (yg - 1) - LEAPS_THRU_END_OF (year - 1)); year = yg; } [...] ======================================================================= The problem here is that it's common for "day" to be temporarily below 0, but its type is unsigned. So the while(){} loop causes an infinite loop for e.g. mtime=1104005394. Consider the attached patch that fixes the problem for me. Theoretically, it would be enough to declare "day" as (signed) int, but looking at the issue the other way around: If we don't have a good reason for "unsigned int", why use it and provoke problems like the issue at hand? Thanks for considering. bye, Roland -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: sparc (sparc64) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.12-1-sparc64 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8) Versions of packages silo depends on: ii libc6 2.3.5-6 GNU C Library: Shared libraries an silo recommends no packages. -- no debconf information--- second/ls.c.orig 2005-11-03 19:12:27.000000000 +0100 +++ second/ls.c 2005-11-03 19:12:41.000000000 +0100 @@ -157,7 +157,7 @@ if (tab_ambiguous == NULL && ls_opt & LSOPT_L) { char mode[11]; char *q; - unsigned int mtime, day, hour, min, month, year; + int mtime, day, hour, min, month, year; static char *months[] = { "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec" };
--- End Message ---
--- Begin Message ---Source: silo Source-Version: 1.4.13a-1 We believe that the bug you reported is fixed in the latest version of silo, which is due to be installed in the Debian FTP archive: silo_1.4.13a-1.diff.gz to pool/main/s/silo/silo_1.4.13a-1.diff.gz silo_1.4.13a-1.dsc to pool/main/s/silo/silo_1.4.13a-1.dsc silo_1.4.13a-1_sparc.deb to pool/main/s/silo/silo_1.4.13a-1_sparc.deb silo_1.4.13a.orig.tar.gz to pool/main/s/silo/silo_1.4.13a.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jurij Smakov <[EMAIL PROTECTED]> (supplier of updated silo package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sun, 19 Aug 2007 01:30:48 +1200 Source: silo Binary: silo Architecture: source sparc Version: 1.4.13a-1 Distribution: unstable Urgency: low Maintainer: Debootloaders SILO Maintainers Team <[EMAIL PROTECTED]> Changed-By: Jurij Smakov <[EMAIL PROTECTED]> Description: silo - Sparc Improved LOader Closes: 337299 337303 433282 Changes: silo (1.4.13a-1) unstable; urgency=low . [ Jurij Smakov ] * Get rid of the legacy build system, switch to quilt for patch management. * Apply a patch by Roland Stigge (slightly modified) to fix date calculation in the ls output. (Closes: #337299) . [ Aurélien GÃRÃME ] * Switch to team-maintenance under the Debootloaders project. * Bump Standards-Version to 3.7.2. * Replace Build-Depends on "linux-kernel-headers (>= 2.6.18)" by "linux-libc-dev (>= 2.6.22)". (Closes: #433282) * Create a new non-native upstream tarball with the same version, but we need to bump it for dak to accept it. (Closes: #337303) * Fix lintian warning "debian-rules-uses-pwd line 32". * Add 11-silocheck_non-failure_on_stat.patch to avoid silent failure of silocheck when an unresolved symlink is encountered under /dev. * Add the XS-Vcs-Svn and XS-Vcs-Browser fields to debian/control. * Fix lintian warnings "binary-without-manpage usr/sbin/silocheck" and "binary-without-manpage usr/sbin/siloconfig" by writing and adding the 2 missing manpages. Files: 7d024a35e6a0fa00cc6344f19522c7c0 936 admin important silo_1.4.13a-1.dsc 661c806cca8a1bf076fe30f8c7ed29be 168934 admin important silo_1.4.13a.orig.tar.gz b5af7885577f5c2b3d78c413e5b9d7d0 9933 admin important silo_1.4.13a-1.diff.gz 1539e43fffe3bfb248ac2187f994c427 177554 admin important silo_1.4.13a-1_sparc.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGxwUSjjectMmeA8wRAlfmAKCM2bSCkPfiy1h4bQwSKQVS/Y+dxQCggUR/ 3cp+KpfENbG8e+dtt+UfDHQ= =AleG -----END PGP SIGNATURE-----
--- End Message ---
