Your message dated Sun, 16 Sep 2007 20:47:28 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#437474: fixed in libnet-irc-perl 0.75-7 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: libnet-irc-perl Version: 0.75-6 Severity: normal Hi David, thanks for your patches. I'm forwarding them to the Debian bug tracking system, so we can better keep track of them. Please keep the bug address ([EMAIL PROTECTED], I don't know the number yet) Cc'd. When is the first patch ('fix_ev_has_null_type.patch') needed? Is it when the server sends an unknown numeric response, or is some part of the code calling handler() with an empty string? The second patch ('fix_next_outside_loop_with_return.patch') looks good to me. I'm not sure of the third one ('fix_send_on_unexpected_close.patch'). If the server has closed the connection, shouldn't we trigger a 'sockerror' event before failing? ----- Forwarded message from David Sobon <[EMAIL PROTECTED]> ----- From: David Sobon <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: libnet-irc-perl patches Hello, I think you may be the most appropriate person for receiving submitted patches related to libnet-irc-perl. I tried to send patches many years ago to the former maintainer, or even the original Net::IRC contact address, but nothing came out of it. Unfortunately I lost one patch that related to DCC CHAT line handling... so I cannot provide a fix I had created a few years ago. (I can probably try one of my old scripts that exposed the problem) The patches only solve warnings basically. If the patches do not appear to solve a convincing issue, I can, with effort, to reproduce the warning messages. Patches are as attached with self-descriptive filename. Thanks. -David. --- Connection.pm.orig 2004-12-17 08:18:48.000000000 +0800 +++ Connection.pm 2007-08-12 18:40:22.000000000 +0800 @@ -473,6 +473,10 @@ } else { croak "Not enough arguments to handler()"; } + + unless ($ev) { + croak "event has NULL type!"; + } print STDERR "Trying to handle event '$ev'.\n" if $self->{_debug}; --- DCC.pm.orig 2006-10-04 04:49:54.000000000 +0800 +++ DCC.pm 2007-08-12 18:32:46.000000000 +0800 @@ -253,7 +253,8 @@ my $line = $self->_getline($_[0], 'BLOCKS'); - next unless defined $line; + return unless defined $line; + unless(print {$self->{_fh}} $line) { carp ("Error writing to " . $self->{_filename} . ": $!"); close $self->{_fh}; --- Connection.pm.orig 2004-12-17 08:18:48.000000000 +0800 +++ Connection.pm 2007-08-12 18:40:22.000000000 +0800 @@ -1374,7 +1378,11 @@ if ($self->{_debug}) { print ">>> $line\n"; } - + + # sometimes IRC servers unexpectedly close on connect, so we try to send + # to a closed socket. dodgy IRC server software? + return unless ($self->{_socket}); + # RFC compliance can be kinda nice... my $rv = $self->ssl ? $self->socket->print("$line\015\012") : ----- End forwarded message ----- Cheers, -- Niko Tyni [EMAIL PROTECTED]
--- End Message ---
--- Begin Message ---Source: libnet-irc-perl Source-Version: 0.75-7 We believe that the bug you reported is fixed in the latest version of libnet-irc-perl, which is due to be installed in the Debian FTP archive: libnet-irc-perl_0.75-7.diff.gz to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-7.diff.gz libnet-irc-perl_0.75-7.dsc to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-7.dsc libnet-irc-perl_0.75-7_all.deb to pool/main/libn/libnet-irc-perl/libnet-irc-perl_0.75-7_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Niko Tyni <[EMAIL PROTECTED]> (supplier of updated libnet-irc-perl package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sun, 16 Sep 2007 21:59:14 +0300 Source: libnet-irc-perl Binary: libnet-irc-perl Architecture: source all Version: 0.75-7 Distribution: unstable Urgency: low Maintainer: Debian Perl Group <[EMAIL PROTECTED]> Changed-By: Niko Tyni <[EMAIL PROTECTED]> Description: libnet-irc-perl - IRC (Internet Relay Chat) interface module for Perl Closes: 437474 Changes: libnet-irc-perl (0.75-7) unstable; urgency=low . * debian/patches/50fix_next_outside_loop_with_return.dpatch: fix subroutine exit via 'next'. Thanks to David Sobon. (Closes: #437474) * debian/patches/60warnings_from_unknown_event.dpatch: fix warnings from unknown response codes. Thanks to David Sobon. (See #437474) * Update to debhelper compatibility level 5. Files: 39fb7921e33c63cca470df7375166d6f 922 perl optional libnet-irc-perl_0.75-7.dsc fad65e4866bdcc251e765367fbaf9f08 5385 perl optional libnet-irc-perl_0.75-7.diff.gz 2bc4f237f618e4cb4989ca57f796e80d 70644 perl optional libnet-irc-perl_0.75-7_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFG7YoLHqjlqpcl9jsRAgKqAJsHgenhWwGXFkJhOIko1oqGhv6RqQCgsGvz 2f6Ey3Kh8wd8L0HLU79xqk8= =Ids7 -----END PGP SIGNATURE-----
--- End Message ---
