Your message dated Sat, 06 Oct 2007 04:07:28 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Bug#238118: Debian CVS bug triage - bug #238118
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: cvs
Version: 1:1.12.5-3
Severity: normal
Hi,
82_flow_control_fix does the following.
exitstatus = (*command) (argument_count, argument_vector);
[...]
* the parent.
*/
buf_free (protocol);
+ close (STDIN_FILENO);
+ close (STDERR_FILENO);
+ close (STDOUT_FILENO);
command() is using the stderr/stdout, but this patch doesn't use
it. So message from command() wasn't outputed, because fd already
closed before flushing from stream buffer.
"cvs version" can easy reproduce this problem.
[EMAIL PROTECTED] cvs version
Client: Concurrent Versions System (CVS) 1.12.5 (client/server)
Server: [EMAIL PROTECTED]
Please consider the attached patch.
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux devron 2.6.4 #1 SMP Fri Mar 12 00:08:15 JST 2004 i686
GNU/Linux
--
OGAWA Hirofumi <[EMAIL PROTECTED]>
---
src/server.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff -puN src/server.c~cvs-bug-fix src/server.c
--- cvs-1.12.5/src/server.c~cvs-bug-fix 2004-03-15 17:13:06.000000000 +0900
+++ cvs-1.12.5-hirofumi/src/server.c 2004-03-15 17:13:25.000000000 +0900
@@ -2753,6 +2753,7 @@ error \n");
TRACE (TRACE_DATA, "CVS_SERVER_SLEEP not set.");
exitstatus = (*command) (argument_count, argument_vector);
+ fflush (NULL);
/* Output any partial lines. If the client doesn't support
"MT", we go ahead and just tack on a newline since the
@@ -2772,16 +2773,16 @@ error \n");
* the parent.
*/
buf_free (protocol);
- close (STDIN_FILENO);
- close (STDERR_FILENO);
- close (STDOUT_FILENO);
- close (protocol_pipe[1]);
+ close (STDIN_FILENO);
+ close (STDERR_FILENO);
+ close (STDOUT_FILENO);
+ close (protocol_pipe[1]);
#ifdef SERVER_FLOWCONTROL
- if (unset_nonblock_fd (flowcontrol_pipe[0]) == 0)
- {
- char junk;
- while (read (flowcontrol_pipe[0], &junk, 1) != 0);
- }
+ if (unset_nonblock_fd (flowcontrol_pipe[0]) == 0)
+ {
+ char junk;
+ while (read (flowcontrol_pipe[0], &junk, 1) != 0);
+ }
#endif
exit (exitstatus);
_
--- End Message ---
--- Begin Message ---
Version: 1:1.12.7-1
OGAWA Hirofumi wrote:
> Lior Kaplan <[EMAIL PROTECTED]> writes:
>
>> As part of a bug triage I'm doing for several packages, I would like your
>> help
>> with verifying your bug is still relevant or getting your approval for
>> closing
>> it.
>
> I can't remember the detail of this bug, but it seems to be fixed as
> far as I can see.
Closing.
I think this changelog entry might be relevant:
> * Old patches no longer necessary:
> + 57_update_segfault_fix (in upstream now)
> + 82_flow_control_fix (fixed upstream in a different way)
--
Lior Kaplan
[EMAIL PROTECTED]
GPG fingerprint:
C644 D0B3 92F4 8FE4 4662 B541 1558 9445 99E8 1DA0
--- End Message ---
