Your message dated Tue, 18 Dec 2007 16:32:05 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#456916: fixed in virtualbox-ose 1.5.2-dfsg2-6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: virtualbox-ose-source
Version: 1.5.2-dfsg2-5
Severity: grave
Justification: renders package unusable
Tags: patch
*** Please type your report below this line ***
Hi
A side effect of commit r134, the addition of
debian/virtualbox-ose-source.dirs, was that
usr/src/modules/virtualbox-ose/
usr/src/modules/virtualbox-ose/debian/
now exist before the install target of debia/rules gets invoked
# Install virtualbox-ose-source
mv debian/$(sname)/usr/lib/virtualbox/src
debian/$(psource)/usr/src/modules/$(sname)
which now moves
debian/$(sname)/usr/lib/virtualbox/src/
to
debian/$(psource)/usr/src/modules/$(sname)/src/
because debian/$(psource)/usr/src/modules/$(sname) already exists,
although debian/virtualbox-ose-source.rules still expects the kernel
module's Makefile still in
debian/$(psource)/usr/src/modules/$(sname)/Makefile
instead of
debian/$(psource)/usr/src/modules/$(sname)/src/Makefile
This results in the following error while trying to build kernel modules via
virtualbox-ose-source
cd /tmp/pkg/linux && \
make-kpkg --rootcmd fakeroot --revision 1 modules
[...]
make[2]: Entering directory `/tmp/pkg/modules/virtualbox-ose'
fakeroot kmk -w -f debian/rules kdist_clean kdist_config binary-modules
kmk[3]: Entering directory `/tmp/pkg/modules/virtualbox-ose'
kmk -w -f debian/rules clean
kmk[4]: Entering directory `/tmp/pkg/modules/virtualbox-ose'
kmk[4]: Nothing to be done for `clean'.
kmk[4]: Leaving directory `/tmp/pkg/modules/virtualbox-ose'
kmk[3]: Nothing to be done for `kdist_config'.
for templ in ; do \
cp $templ `echo $templ | sed -e 's/_KVERS_/2.6.24-rc5-git5-slh-smp-1/g'` ; \
done
for templ in `ls debian/*.modules.in` ; do \
test -e ${templ%.modules.in}.backup || cp ${templ%.modules.in}
${templ%.modules.in}.backup 2>/dev/null || true; \
sed -e 's/##KVERS##/2.6.24-rc5-git5-slh-smp-1/g
;s/#KVERS#/2.6.24-rc5-git5-slh-smp-1/g ; s/_KVERS_/2.6.24-rc5-git5-slh-smp-1/g
; s/##KDREV##/1/g ; s/#KDREV#/1/g ; s/_KDREV_/1/g ' < $templ >
${templ%.modules.in}; \
done
dh_testroot
dh_clean -k
# Build the module
kmk all KSRC=/tmp/pkg/linux KVER=2.6.24-rc5-git5-slh-smp-1
KERN_DIR=/tmp/pkg/linux
kmk[4]: Entering directory `/tmp/pkg/modules/virtualbox-ose'
kmk[4]: *** No rule to make target `all'. Stop.
kmk[4]: Leaving directory `/tmp/pkg/modules/virtualbox-ose'
kmk[3]: *** [binary-modules] Error 2
kmk[3]: Leaving directory `/tmp/pkg/modules/virtualbox-ose'
make[2]: *** [kdist_build] Error 2
make[2]: Leaving directory `/tmp/pkg/modules/virtualbox-ose'
Module /tmp/pkg/modules/virtualbox-ose failed.
Perhaps /tmp/pkg/modules/virtualbox-ose does not understand --rootcmd?
If you see messages that indicate that it is not
in fact being built as root, please file a bug
against /tmp/pkg/modules/virtualbox-ose.
Hit return to Continue?
Of course, (/tmp/pkg/)modules/virtualbox-ose/Makefile does not exist, as
it is hiding in (/tmp/pkg/)modules/virtualbox-ose/src/Makefile.
I see two potential fixes for this issue, the attached debdiff
"virtualbox-ose-source_fix-installdir.diff" installs the module source
directly to modules/virtualbox/ again, while the likewise attached
debdiff "virtualbox-ose-source_fix-rules.diff" rewrites
debian/virtualbox-ose-source.rules to deal with the module sources now
residing in a subdir.
Personally I tend to favour "virtualbox-ose-source_fix-installdir.diff", as
it seems to be more consistent to keep a top level Makefile than
redirecting to a subdirectory in debian/rules.
Regards
Stefan Lippers-Hollmann
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.24-rc5-git5-slh64-smp-1 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages virtualbox-ose-source depends on:
ii bzip2 1.0.3-7 high-quality block-sorting file co
ii debhelper 5.0.62 helper programs for debian/rules
ii dpatch 2.0.28 patch maintenance system for Debia
ii kbuild 1366-1 framework for writing simple makef
ii module-assistant 0.10.11 tool to make module package creati
virtualbox-ose-source recommends no packages.
-- no debconf information
diff -u virtualbox-ose-1.5.2-dfsg2/debian/rules virtualbox-ose-1.5.2-dfsg2/debian/rules
--- virtualbox-ose-1.5.2-dfsg2/debian/rules
+++ virtualbox-ose-1.5.2-dfsg2/debian/rules
@@ -97,7 +97,8 @@
echo "INSTALL_DIR="\"/usr/lib/virtualbox\" >> $(CURDIR)/debian/$(sname)/etc/vbox/vbox.cfg
# Install virtualbox-ose-source
- mv debian/$(sname)/usr/lib/virtualbox/src debian/$(psource)/usr/src/modules/$(sname)
+ mv debian/$(sname)/usr/lib/virtualbox/src/* debian/$(psource)/usr/src/modules/$(sname)/
+ rmdir debian/$(sname)/usr/lib/virtualbox/src
# Install virtualbox-ose-guest-source
mv debian/$(sname)/usr/lib/virtualbox/additions/src/vboxadd debian/$(gsource)/usr/src/modules/$(gname)
diff -u virtualbox-ose-1.5.2-dfsg2/debian/virtualbox-ose-source.rules virtualbox-ose-1.5.2-dfsg2/debian/virtualbox-ose-source.rules
--- virtualbox-ose-1.5.2-dfsg2/debian/virtualbox-ose-source.rules
+++ virtualbox-ose-1.5.2-dfsg2/debian/virtualbox-ose-source.rules
@@ -56,10 +56,10 @@
dh_clean -k
# Build the module
- $(MAKE) all KSRC=$(KSRC) KVER=$(KVERS) KERN_DIR=$(KSRC)
+ $(MAKE) -C src all KSRC=$(KSRC) KVER=$(KVERS) KERN_DIR=$(KSRC)
# Install the module
- dh_install vboxdrv.ko /lib/modules/$(KVERS)/misc/
+ dh_install src/vboxdrv.ko /lib/modules/$(KVERS)/misc/
dh_installdocs
dh_installchangelogs
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---
Source: virtualbox-ose
Source-Version: 1.5.2-dfsg2-6
We believe that the bug you reported is fixed in the latest version of
virtualbox-ose, which is due to be installed in the Debian FTP archive:
virtualbox-ose-dbg_1.5.2-dfsg2-6_i386.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-dbg_1.5.2-dfsg2-6_i386.deb
virtualbox-ose-guest-source_1.5.2-dfsg2-6_all.deb
to
pool/main/v/virtualbox-ose/virtualbox-ose-guest-source_1.5.2-dfsg2-6_all.deb
virtualbox-ose-guest-utils_1.5.2-dfsg2-6_i386.deb
to
pool/main/v/virtualbox-ose/virtualbox-ose-guest-utils_1.5.2-dfsg2-6_i386.deb
virtualbox-ose-source_1.5.2-dfsg2-6_all.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-source_1.5.2-dfsg2-6_all.deb
virtualbox-ose_1.5.2-dfsg2-6.diff.gz
to pool/main/v/virtualbox-ose/virtualbox-ose_1.5.2-dfsg2-6.diff.gz
virtualbox-ose_1.5.2-dfsg2-6.dsc
to pool/main/v/virtualbox-ose/virtualbox-ose_1.5.2-dfsg2-6.dsc
virtualbox-ose_1.5.2-dfsg2-6_i386.deb
to pool/main/v/virtualbox-ose/virtualbox-ose_1.5.2-dfsg2-6_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Meskes <[EMAIL PROTECTED]> (supplier of updated virtualbox-ose package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 18 Dec 2007 16:21:33 +0100
Source: virtualbox-ose
Binary: virtualbox-ose-guest-utils virtualbox-ose-guest-source
virtualbox-ose-source virtualbox-ose-dbg virtualbox-ose
Architecture: source all i386
Version: 1.5.2-dfsg2-6
Distribution: unstable
Urgency: low
Maintainer: Debian Virtualbox Team <[EMAIL PROTECTED]>
Changed-By: Michael Meskes <[EMAIL PROTECTED]>
Description:
virtualbox-ose - PC virtualization solution
virtualbox-ose-dbg - PC virtualization solution (debug)
virtualbox-ose-guest-source - Source for the VirtualBox Guest Addition module
virtualbox-ose-guest-utils - PC virtualization solution - guest utils
virtualbox-ose-source - Source for the VirtualBox module
Closes: 456916
Changes:
virtualbox-ose (1.5.2-dfsg2-6) unstable; urgency=low
.
[ Daniel Baumann ]
* Again removing reimported useless whitespaces at EOL and EOF in debian/*.
* Fixing dpatch headers.
* Rediffed dpatches 6-12.
* Removed svn:executable on dpatch 9 and 12.
.
[ Michael Meskes ]
* Fixed rules file to correctly install module sources, closes: #456916
Files:
656733e236c5224da4f6da52d6f724fc 1343 misc extra
virtualbox-ose_1.5.2-dfsg2-6.dsc
90b1243b1d6fb369ce59eef861269e58 81944 misc extra
virtualbox-ose_1.5.2-dfsg2-6.diff.gz
b3fba3a9b2e9c1ada097471a8c598211 6082196 misc extra
virtualbox-ose_1.5.2-dfsg2-6_i386.deb
130da7fc20517522829611a40b7c44d4 6638176 devel extra
virtualbox-ose-dbg_1.5.2-dfsg2-6_i386.deb
b1dde10158808f173f016a465b2e6a09 314462 misc extra
virtualbox-ose-guest-utils_1.5.2-dfsg2-6_i386.deb
254ff1fc367a10996c3e7c9b002e7603 199600 misc extra
virtualbox-ose-source_1.5.2-dfsg2-6_all.deb
90dbbf55a0607c07cc501bd74d604be2 276396 misc extra
virtualbox-ose-guest-source_1.5.2-dfsg2-6_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHZ+7eVkEm8inxm9ERAkDGAJ4q3vP1FZcOujo91eB/8ZA5SEkJ1wCfZ29D
oSqg8utbQz/iPpnnpSg6Gxk=
=MkR8
-----END PGP SIGNATURE-----
--- End Message ---
