Your message dated Wed, 09 Jan 2008 23:47:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#458535: fixed in hotkey-setup 0.1-18
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: hotkey-setup
Version: 0.1-17.1

I plan to NMU hotkey-setup to fix a few issues.  I will upload to the
7-day delayed upload queue.  Here is the patch I plan to upload.
Please let me know if there is some reason why I should not upload
this new version.  The package is ready to go, and I will wait for 5
hours before doing I upload.

I did not process the laptop specific bugs and patches this time, as I
do not yet understand the package well enough to evaluate them.

diff -urN hotkey-setup-0.1/debian/changelog 
hotkey-setup-0.1-pere/debian/changelog
--- hotkey-setup-0.1/debian/changelog   2007-08-04 19:10:57.000000000 +0200
+++ hotkey-setup-0.1-pere/debian/changelog      2008-01-01 14:46:21.000000000 
+0100
@@ -1,3 +1,28 @@
+hotkey-setup (0.1-17.2) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Updated standards-version from 3.6.1 to 3.7.3.  No changes needed.
+  * Make sure init.d script is not executed when the package is removed
+    but not purged (Closes: #379613).  Patch from Vagrant Cascadian.
+  * Add LSB style dependency header in init.d script (Closes: #376955)
+  * Remove unneeded stop symlinks in runlevel 0 and 6.  Based on patch
+    from Scott James Remnant and Ubuntu.
+  * Use -c when checking for /dev/nvram (Closes: #387246).  Patch from
+    Tom May.
+  * Don't fail when keystate cannot be restored or thinkpad-keys cannot
+    be terminated when stopping initscript.  Patch from Kel Modderman.
+  * Add a custom prerm script to remove keycodes state file when prerm
+    of installed package fails (Closes: #437360). Patch from Kel
+    Modderman.
+  * Depend on console-tools | console-utilities to make sure the
+    setkeycodes program is available (Closes: #431329).
+  * Change init.d shell from /bin/bash to /bin/sh, based on patch from
+    Paul Sladen and Ubuntu.
+  * Ensure that the existing scripts are only run on laptops.  Based
+    on patch from Matthew Garrett and Ubuntu.
+
+ -- Petter Reinholdtsen <[EMAIL PROTECTED]>  Tue,  1 Jan 2008 14:45:47 +0100
+
 hotkey-setup (0.1-17.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -urN hotkey-setup-0.1/debian/control hotkey-setup-0.1-pere/debian/control
--- hotkey-setup-0.1/debian/control     2007-08-04 19:10:04.000000000 +0200
+++ hotkey-setup-0.1-pere/debian/control        2008-01-01 14:37:30.000000000 
+0100
@@ -3,11 +3,11 @@
 Priority: optional
 Maintainer: Matthew Garrett <[EMAIL PROTECTED]>
 Build-Depends: debhelper (>= 4.0.0)
-Standards-Version: 3.6.1
+Standards-Version: 3.7.3
 
 Package: hotkey-setup
 Architecture: i386 amd64
-Depends: dmidecode (>= 2.7)
+Depends: dmidecode (>= 2.7), laptop-detect, console-tools | console-utilities
 Conflicts: tpb
 Description: auto-configures laptop hotkeys
  This package will attempt to auto-detect your laptop hardware and then
diff -urN hotkey-setup-0.1/debian/init.d hotkey-setup-0.1-pere/debian/init.d
--- hotkey-setup-0.1/debian/init.d      2006-04-29 21:09:27.000000000 +0200
+++ hotkey-setup-0.1-pere/debian/init.d 2008-01-01 14:47:38.000000000 +0100
@@ -1,4 +1,15 @@
-#!/bin/bash
+#!/bin/sh
+### BEGIN INIT INFO
+# Provides:          hotkey-setup
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Default-Start:     2 3 4 5
+# Default-Stop:      1
+# Short-Description: Set up laptop keys to generate keycodes.
+### END INIT INFO
+
+# do not run if not package is not installed
+test -x /usr/sbin/dumpkeycodes || exit 0
 
 manufacturer=`dmidecode --string system-manufacturer`
 name=`dmidecode --string system-product-name`
@@ -15,7 +26,7 @@
        if [ ! -c /dev/input/uinput ]; then
            modprobe uinput
        fi
-       if [ ! -b /dev/nvram ]; then
+       if [ ! -c /dev/nvram ]; then
            modprobe nvram
        fi
        /usr/sbin/thinkpad-keys && touch $THINKPAD_LOCKFILE
@@ -25,6 +36,9 @@
 case "$1" in
     start)
 
+# This entire block does nothing on desktops right now
+    if laptop-detect; then
+
     /usr/sbin/dumpkeycodes >$SAVED_STATE
     
     if [ $? -gt 0 ]; then
@@ -105,13 +119,14 @@
        . /usr/share/hotkey-setup/default.hk    
     esac
     . /usr/share/hotkey-setup/generic.hk
+    fi
     ;;
     stop)
        if [ -f $THINKPAD_LOCKFILE ]; then
-           kill `pidof thinkpad-keys` && rm -f $THINKPAD_LOCKFILE
+           kill `pidof thinkpad-keys` || true ; rm -f $THINKPAD_LOCKFILE
        fi
        if [ -f $SAVED_STATE ]; then
-               setkeycodes $(cat $SAVED_STATE)
+               setkeycodes $(cat $SAVED_STATE) || true
        fi
     ;;
     restart|force-reload)
diff -urN hotkey-setup-0.1/debian/postinst hotkey-setup-0.1-pere/debian/postinst
--- hotkey-setup-0.1/debian/postinst    1970-01-01 01:00:00.000000000 +0100
+++ hotkey-setup-0.1-pere/debian/postinst       2008-01-01 14:58:19.000000000 
+0100
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -e
+
+# Remove symlinks to script to have them reinserted by debhelper
+# without the shutdown and reboot links; this init script does not
+# need them.
+if dpkg --compare-versions "$2" lt "0.1-17.2"; then
+       update-rc.d -f hotkey-setup remove
+fi
+
+#DEBHELPER#
diff -urN hotkey-setup-0.1/debian/prerm hotkey-setup-0.1-pere/debian/prerm
--- hotkey-setup-0.1/debian/prerm       1970-01-01 01:00:00.000000000 +0100
+++ hotkey-setup-0.1-pere/debian/prerm  2008-01-01 14:26:56.000000000 +0100
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+set -e
+
+if dpkg --compare-versions "$2" lt "0.1-17.2"; then
+       # setkeycodes exits with error sometimes (#437360) and has
+       # completely broken the upgrade path for some users.
+       # remove the saved state file if installed package prerm
+       # maintainer script fails.
+       rm -f /var/run/hotkey-setup
+fi
+
+#DEBHELPER#
diff -urN hotkey-setup-0.1/debian/rules hotkey-setup-0.1-pere/debian/rules
--- hotkey-setup-0.1/debian/rules       2006-02-06 14:41:37.000000000 +0100
+++ hotkey-setup-0.1-pere/debian/rules  2008-01-01 14:16:59.000000000 +0100
@@ -51,7 +51,7 @@
 #      dh_installemacsen
 #      dh_installpam
 #      dh_installmime
-       dh_installinit
+       dh_installinit -- start 20 2 3 4 5 . stop 20 1 .
 #      dh_installcron
 #      dh_installinfo
        dh_installman



--- End Message ---
--- Begin Message ---
Source: hotkey-setup
Source-Version: 0.1-18

We believe that the bug you reported is fixed in the latest version of
hotkey-setup, which is due to be installed in the Debian FTP archive:

hotkey-setup_0.1-18.dsc
  to pool/main/h/hotkey-setup/hotkey-setup_0.1-18.dsc
hotkey-setup_0.1-18.tar.gz
  to pool/main/h/hotkey-setup/hotkey-setup_0.1-18.tar.gz
hotkey-setup_0.1-18_i386.deb
  to pool/main/h/hotkey-setup/hotkey-setup_0.1-18_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <[EMAIL PROTECTED]> (supplier of updated hotkey-setup 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed,  9 Jan 2008 23:23:18 +0100
Source: hotkey-setup
Binary: hotkey-setup
Architecture: source i386
Version: 0.1-18
Distribution: unstable
Urgency: low
Maintainer: Petter Reinholdtsen <[EMAIL PROTECTED]>
Changed-By: Petter Reinholdtsen <[EMAIL PROTECTED]>
Description: 
 hotkey-setup - auto-configures laptop hotkeys
Closes: 355813 430031 445737 458535 459423 459881 459898
Changes: 
 hotkey-setup (0.1-18) unstable; urgency=low
 .
   * New maintainer (Closes: #459898).
   * Acknowledge NMU (Closes: #458535).
   * Merge changes from Ubuntu version 0.1-17ubuntu20.
     - Adds support for CLEVO D500P laptop (Closes: #355813)
     - Avoids circular dependencies between key and brightness events
       (Closes: #459881).
     - Reduces power and cpu consumption of thinkpad-keys (Closes:
       #430031)
   * Debian changes from earlier versions left to merge with Ubuntu:
     - Include LSB header in init.d script.
     - Make sure to exit the init.d script if the package
       is removed but not purged.
     - Depend on "console-tools | console-utilities" for the
       setkeycodes program.
     - Do not depend on newer sysv-rc, Debian is not using the
       multiuser argument for update-rc.d.
     - Remove runlevel 0 and 6 stop scripts by removing and adding the
       init.d script, as just removing the symlinks do not work with
       file-rc.
     - Updated standards-version from 3.6.1 to 3.7.3.
   * Add new keys for mute and volume up and down keys on Dell XPS
     M1330 (Closes: #459423).
   * Add keys left and right for Thinkpad X60 tablets (Closes:
     #445737).
   * Change formatting of NEWS file to keep lintian quiet.
Files: 
 3bc9d618c849662e353bf53170f7f5b6 523 misc optional hotkey-setup_0.1-18.dsc
 6b2ee206e8286f5af73951bba33684b3 19554 misc optional hotkey-setup_0.1-18.tar.gz
 6dde60a768864977c78a485664842d49 21842 misc optional 
hotkey-setup_0.1-18_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHhVi120zMSyow1ykRAu/nAJ45oUsSIpUJC156r5/LcdDLbRnrmACfSR/E
FZi7OJr2VswxQ24z9iSBI10=
=My/1
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to