Your message dated Sun, 13 Jan 2008 14:02:05 +0100 with message-id <[EMAIL PROTECTED]> and subject line Bug#460462: xfce4-fsguard-plugin: crashes upon icon click when $filemanager was never set has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: xfce4-fsguard-plugin Version: 0.3.0-3 Severity: important Hi, steps to reproduce: - add fsguard plugin; - configure it as you wish, e.g.: - label = root, - moint point = /, - filemanager = (empty), - alert level = 200, - warn level = 500 Then one can hover the icon, get the available disk space, but when clicking on the icon, the plugin disappears. ,---[ xsession errors ]--- | ** Message: Contrôle d'espace disque: screen changed: 0 | ** Message: No valid plug window. | (xfce4-panel:3603): Gtk-CRITICAL **: gtk_socket_get_id: assertion `GTK_WIDGET_ANCHORED (socket)' failed | ** (xfce4-panel:3603): CRITICAL **: Un élément a été inopinément supprimé: "Contrôle d'espace disque". `--- If you add it back, setting e.g. filemanager to thunar, everything goes fine. It keeps on going fine even if you reset filemanager to an empty string. Looks like a missing/buggy initialization. Miaou, -- Cyril Brulebois -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: powerpc (ppc) Kernel: Linux 2.6.22-3-powerpc Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages xfce4-fsguard-plugin depends on: ii libatk1.0-0 1.20.0-1 The ATK accessibility toolkit ii libc6 2.7-2 GNU C Library: Shared libraries ii libcairo2 1.4.10-1+b2 The Cairo 2D vector graphics libra ii libfontconfig1 2.5.0-2 generic font configuration library ii libglib2.0-0 2.14.4-1 The GLib library of C routines ii libgtk2.0-0 2.12.1-3 The GTK+ graphical user interface ii libpango1.0-0 1.18.3-1 Layout and rendering of internatio ii libx11-6 2:1.0.3-7 X11 client-side library ii libxcursor1 1:1.1.9-1 X cursor management library ii libxext6 1:1.0.3-2 X11 miscellaneous extension librar ii libxfce4util4 4.4.2-1 Utility functions library for Xfce ii libxfcegui4-4 4.4.2-1 Basic GUI C functions for Xfce4 ii libxfixes3 1:4.0.3-2 X11 miscellaneous 'fixes' extensio ii libxi6 2:1.1.3-1 X11 Input extension library ii libxinerama1 1:1.0.2-1 X11 Xinerama extension library ii libxrandr2 2:1.2.2-1 X11 RandR extension library ii libxrender1 1:0.9.4-1 X Rendering Extension client libra ii xfce4-panel 4.4.2-1 The Xfce4 desktop environment pane xfce4-fsguard-plugin recommends no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Version: 0.4.0-1 Miaou back. On 13/01/2008, [EMAIL PROTECTED] wrote: > I couldn't reproduce because I'm not running any xfce panel atm. > However I can tell that this problem isn't present in the 0.4.0 > version (already in unstable and testing). I attach a quick patch > that should just work. > > Btw, I don't see any 0.3.0-3 version in packages.d.o. *sigh*, I thought I had updated all xfce-related thingies. My bad. Fixing with the current version, which doesn't show that behaviour. > --- panel-plugin/fsguard.c.orig 2008-01-13 06:02:46.000000000 +0100 > +++ panel-plugin/fsguard.c 2008-01-13 06:12:46.000000000 +0100 > @@ -121,7 +121,7 @@ > { > FsGuard *fsguard = user_data; > GString *cmd; > - if (strlen(fsguard->filemanager) == 0) { > + if (fsguard->filemanager == NULL || strlen(fsguard->filemanager) == 0) { > return; > } Looks like it would have done the job; thanks. :) Cheers, -- Cyril Brulebois
pgpwqJPjlnZ67.pgp
Description: PGP signature
--- End Message ---
