Your message dated Tue, 29 Jan 2008 15:47:05 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#442162: fixed in snmptrapfmt 1.13
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: snmptrapfmt
Version: 1.11
Severity: important
Tags: patch

I have a lot of switches sending traps on linkup/down and other events
which I receive using snmptrapd and log using snmptrapfmt (or at least
try to).  Everytime I receive a trap however snmptrapfmt segfaults.

I tracked the segfault down to trying to call sprintf with a null
pointer input as an argument since the trap messages do not contain an
enterprise value and the log format has $e in it to print the enterprise
value for every log entry.

The following patch prints out '(null)' instead whenever the enterprise
value is non existant.

diff -u snmptrapfmt-1.11/snmptrapfmt.c snmptrapfmt-1.11.new/snmptrapfmt.c
--- snmptrapfmt-1.11/snmptrapfmt.c      2006-03-22 15:39:19.000000000 -0500
+++ snmptrapfmt-1.11.new/snmptrapfmt.c  2007-09-13 13:26:22.000000000 -0400
@@ -858,11 +858,11 @@
   switch (oidFmt)
   {
     case OIDFMT_TEXT:          /* use textual format for the oid */
-      sprintf(lbuf, "%s", oidP);
+      sprintf(lbuf, "%s", oidP ? oidP : "(null)");
       break;
     case OIDFMT_OID:           /* usenumerical format for the oid */
     default:                   /* shouldn't happen */
-      sprintf(lbuf, "%s", oidP);
+      sprintf(lbuf, "%s", oidP ? oidP : "(null)");
       break;
   }
 
@@ -1105,7 +1105,7 @@
             lg_sprint_oid(var->v_oid, cfg_oidfmt, cPPtr, bRemP);
             break;
           case 't':            /* the type */
-            logging(0, "Type info not available - using ASN_OCTET_STR");
+            logging(1, "Type info not available - using ASN_OCTET_STR");
             lg_sprint_ASNtype(ASN_OCTET_STR, cPPtr, bRemP);
             break;
           case 'v':            /* the value */


It also changes one call to logging since it was causing the program to
complain about an already existing snmptrapfmt.trc file.  Perhaps the
real answer is that the trc file should be recreated each time, rather
than complain that the file already exists (which is the current
behaviour).

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'proposed-updates')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-1-686-smp
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages snmptrapfmt depends on:
ii  libsnmp9                      5.2.3-7    NET SNMP (Simple Network Managemen
ii  snmpd                         5.2.3-7    NET SNMP (Simple Network Managemen

snmptrapfmt recommends no packages.

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: snmptrapfmt
Source-Version: 1.13

We believe that the bug you reported is fixed in the latest version of
snmptrapfmt, which is due to be installed in the Debian FTP archive:

snmptrapfmt_1.13.dsc
  to pool/main/s/snmptrapfmt/snmptrapfmt_1.13.dsc
snmptrapfmt_1.13.tar.gz
  to pool/main/s/snmptrapfmt/snmptrapfmt_1.13.tar.gz
snmptrapfmt_1.13_sparc.deb
  to pool/main/s/snmptrapfmt/snmptrapfmt_1.13_sparc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Friedrich <[EMAIL PROTECTED]> (supplier of updated snmptrapfmt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 29 Jan 2008 16:25:28 +0100
Source: snmptrapfmt
Binary: snmptrapfmt
Architecture: source sparc
Version: 1.13
Distribution: unstable
Urgency: low
Maintainer: Jochen Friedrich <[EMAIL PROTECTED]>
Changed-By: Jochen Friedrich <[EMAIL PROTECTED]>
Description: 
 snmptrapfmt - A configurable snmp trap handler daemon for snmpd
Closes: 442162 457752
Changes: 
 snmptrapfmt (1.13) unstable; urgency=low
 .
   * Update Policy to 3.7.3
   * Add patch from Len Sorensen <[EMAIL PROTECTED]> to fix
     a segfault on traps without enterprise value (Closes: #442162)
   * Add LSB header to init script (Closes: #457752)
Files: 
 42d4fd2368dcb6fcbf0d8b4c6cec98fd 518 net optional snmptrapfmt_1.13.dsc
 5d99b7ef0e602715a85869b601c8fdca 17335 net optional snmptrapfmt_1.13.tar.gz
 d181ab0ec0dba9d529b5c62ed637fc3e 18192 net optional snmptrapfmt_1.13_sparc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHn0jb0fhX0Y/ocz0RAl6cAJ48NduyxRHWNdTvcHUPfhEzi3Y4GQCeOyEe
xlBjKO4GEep05Ku5bEgfe4M=
=o8qu
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to