Your message dated Wed, 06 Feb 2008 00:02:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#464172: fixed in cpio 2.9-11
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: cpio-win32
Severity: normal
Tags: patch
Output is corrupted when input contains newlines, because write() without
binary mode replaces all \n with \r\n (even where \r is already present!),
resulting in checksum failure.
Attached patch fixes the problem. I've also sent it upstream.
-- System Information:
Debian Release: lenny/sid
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
diff -ur cpio-2.9.old/lib/fcntl_.h cpio-2.9/lib/fcntl_.h
--- cpio-2.9.old/lib/fcntl_.h 2007-06-28 19:18:55.000000000 +0200
+++ cpio-2.9/lib/fcntl_.h 2008-02-05 17:00:24.000000000 +0100
@@ -111,7 +111,10 @@
# undef O_TEXT
#endif
-#ifndef O_BINARY
+#ifdef O_BINARY
+# define SET_BINARY_MODE(arc) setmode(arc, O_BINARY)
+#else
+# define SET_BINARY_MODE(arc)
# define O_BINARY 0
# define O_TEXT 0
#endif
diff -ur cpio-2.9.old/lib/system.h cpio-2.9/lib/system.h
--- cpio-2.9.old/lib/system.h 2008-02-05 14:03:34.000000000 +0100
+++ cpio-2.9/lib/system.h 2008-02-05 17:00:37.000000000 +0100
@@ -109,9 +109,6 @@
# define O_TRUNC 32 /* truncate file on open */
#endif
-#ifndef O_BINARY
-# define O_BINARY 0
-#endif
#ifndef O_DIRECTORY
# define O_DIRECTORY 0
#endif
@@ -490,13 +487,11 @@
#endif
#if MSDOS
-# define SET_BINARY_MODE(arc) setmode(arc, O_BINARY)
# define ERRNO_IS_EACCES errno == EACCES
# define mkdir(file, mode) (mkdir) (file)
# define TTY_NAME "con"
# define sys_reset_uid_gid()
#else
-# define SET_BINARY_MODE(arc)
# define ERRNO_IS_EACCES 0
# define TTY_NAME "/dev/tty"
# define sys_reset_uid_gid() \
diff -ur cpio-2.9.old/src/main.c cpio-2.9/src/main.c
--- cpio-2.9.old/src/main.c 2007-06-28 12:46:41.000000000 +0200
+++ cpio-2.9/src/main.c 2008-02-05 17:03:48.000000000 +0100
@@ -792,6 +792,8 @@
initialize_buffers ();
+ SET_BINARY_MODE (1);
+
(*copy_function) ();
if (archive_des >= 0 && rmtclose (archive_des) == -1)
--- End Message ---
--- Begin Message ---
Source: cpio
Source-Version: 2.9-11
We believe that the bug you reported is fixed in the latest version of
cpio, which is due to be installed in the Debian FTP archive:
cpio-win32_2.9-11_all.deb
to pool/main/c/cpio/cpio-win32_2.9-11_all.deb
cpio_2.9-11.diff.gz
to pool/main/c/cpio/cpio_2.9-11.diff.gz
cpio_2.9-11.dsc
to pool/main/c/cpio/cpio_2.9-11.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Clint Adams <[EMAIL PROTECTED]> (supplier of updated cpio package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 05 Feb 2008 18:43:36 -0500
Source: cpio
Binary: cpio cpio-win32
Architecture: source all
Version: 2.9-11
Distribution: unstable
Urgency: low
Maintainer: Clint Adams <[EMAIL PROTECTED]>
Changed-By: Clint Adams <[EMAIL PROTECTED]>
Description:
cpio - GNU cpio -- a program to manage archives of files
cpio-win32 - GNU cpio -- a program to manage archives of files (win32 build)
Closes: 464172 464208
Changes:
cpio (2.9-11) unstable; urgency=low
.
* Apply patch from Robert Millan to set O_BINARY where available.
closes: #464172.
* Strip cpio.exe. closes: #464208.
Files:
9ad795077966f613003fab7d6a49cab8 716 utils important cpio_2.9-11.dsc
0121088489acf6c2cc49316bd0b23853 103924 utils important cpio_2.9-11.diff.gz
23ea860962451dc57d35cbdadf6fd629 73786 utils extra cpio-win32_2.9-11_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Debian!
iD8DBQFHqPcY5m0u66uWM3ARAsPzAJoDnbS+N8uojNgHQG+Phw79fpZa+gCfbCdt
u7pgWCzCt4O08WZZXlkyj4M=
=RnG3
-----END PGP SIGNATURE-----
--- End Message ---
