Your message dated Wed, 13 Feb 2008 21:32:11 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#464918: fixed in grub2 1.96+20080213-1
has caused the Debian Bug report #464918,
regarding automated migration of kopt from menu.list
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
464918: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464918
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: grub-pc
Version: 1.95+20080107-1
Severity: wishlist
Tags: patch

--- Please enter the report below this line. ---

Hi Robert,

here's the patch for debconf/postinst/etc.  for extracting kopt from the old 
menu.lst to 
/etc/default/grub, as we spoke on grub mailing list.

I hope you could rework on it, to make it a good patch.

Thanks again for your work.

--- System information. ---
Architecture: amd64
Kernel:       Linux 2.6.23-1-amd64

Debian Release: lenny/sid
  500 voip-snapshots-debian-sid snapshots.seconix.com 
  500 unstable        www.emdebian.org 
  500 unstable        www.debian-multimedia.org 
  500 unstable        ftp.uk.debian.org 
  500 unstable        ftp.fr.debian.org 
  400 testing         security.debian.org 
  400 testing         ftp.fr.debian.org 
    1 experimental    ftp.fr.debian.org 

--- Package information. ---
Depends          (Version) | Installed
==========================-+-===========
base-files      (>= 4.0.1) | 4.0.2
debconf                    | 1.5.18
debconf          (>= 0.5)  | 1.5.18
 OR debconf-2.0            | 
libc6           (>= 2.7-1) | 2.7-6
liblzo2-2                  | 2.02-3

diff -Nru --exclude=i386-pc.mk /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.config ./grub2-1.95+20080107/debian/grub-pc.config
--- /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.config	2008-01-15 00:18:46.000000000 +0100
+++ ./grub2-1.95+20080107/debian/grub-pc.config	2008-01-15 00:11:02.000000000 +0100
@@ -1,7 +1,19 @@
 #!/bin/bash -e
 
+function get_kopt_from_menu.lst() {
+    if test -e /boot/grub/menu.lst; then
+	grep -v '^[[:space:]]*##' /boot/grub/menu.lst | sed -e '\+^# kopt=+!d;s/^# kopt=\(.*\)/\1/g' -e 's/ root=[^ ]*\|^root=[^ ]*/ /g' -e 's/^ro$\|^ro \| ro$\| ro / /g'| tr -s ' '
+    fi
+}
+
 if test -e /boot/grub/menu.lst ; then
   . /usr/share/debconf/confmodule
+  present=`grep -v '^[[:space:]]*#' /etc/default/grub | grep 'GRUB_CMDLINE_LINUX' | wc -l`
+  if test "x${present}" = "x0" ; then
+      kopt=`get_kopt_from_menu.lst`
+        db_set grub-pc/kernel_options ${kopt} || true
+  fi
   db_input high grub-pc/chainload_from_menu.lst || true
+  db_input high grub-pc/kernel_options || true
   db_go
 fi
diff -Nru --exclude=i386-pc.mk /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.postinst ./grub2-1.95+20080107/debian/grub-pc.postinst
--- /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.postinst	2008-01-15 00:18:46.000000000 +0100
+++ ./grub2-1.95+20080107/debian/grub-pc.postinst	2008-01-15 00:11:02.000000000 +0100
@@ -1,5 +1,18 @@
 #!/bin/bash -e
 
+function write_kopt()
+{
+    present=`grep -v '^[[:space:]]*#' /etc/default/grub | grep 'GRUB_CMDLINE_LINUX' | wc -l`
+    if [ "x${present}" = "x1" ]
+    then
+	mask=s/GRUB_CMDLINE_LINUX=.*$/GRUB_CMDLINE_LINUX=\"$1\"/  
+	sed -i "${mask}" /etc/default/grub
+    else
+	echo GRUB_CMDLINE_LINUX=\"$1\" >> /etc/default/grub
+    fi
+}
+
+
 case "$1" in
   configure)
     . /usr/share/debconf/confmodule
@@ -11,6 +24,13 @@
       grub-mkdevicemap
     fi
 
+    # get kernel line parameter and place it in /etc/default/grub
+    # adding it or modifying it
+    db_get grub-pc/kernel_options
+    if [ ! -z "${RET}" ]; then
+	write_kopt "${RET}"
+    fi
+
     db_get grub-pc/chainload_from_menu.lst
     if $RET && test -e /boot/grub/menu.lst && ! test -e /boot/grub/core.img ; then
       # If there's no core.img setup, create one (but do not risk writing to MBR).
diff -Nru --exclude=i386-pc.mk /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.templates ./grub2-1.95+20080107/debian/grub-pc.templates
--- /tmp/grub-orig/grub2-1.95+20080107/debian/grub-pc.templates	2008-01-15 00:18:46.000000000 +0100
+++ ./grub2-1.95+20080107/debian/grub-pc.templates	2008-01-15 00:11:02.000000000 +0100
@@ -17,3 +17,13 @@
  you can do so by issuing (as root) the following command:
  .
  grub-install "(hd0)" && update-grub
+
+Template: grub-pc/kernel_options
+Type: string
+Default:
+Description: Kernel command line parameters
+ Value of kernel command line parameters. By default, value is
+ extracted from old /boot/grub/menu.lst if exists. Here you can
+ place value to fix acpi or apic on your computer, and also parameters
+ for splash boot (splashy, usplash, ...)
+ .

Attachment: signature.asc
Description: Ceci est une partie de message numériquement signée


--- End Message ---
--- Begin Message ---
Source: grub2
Source-Version: 1.96+20080213-1

We believe that the bug you reported is fixed in the latest version of
grub2, which is due to be installed in the Debian FTP archive:

grub-efi_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub-efi_1.96+20080213-1_amd64.deb
grub-ieee1275_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub-ieee1275_1.96+20080213-1_amd64.deb
grub-linuxbios_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub-linuxbios_1.96+20080213-1_amd64.deb
grub-pc_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub-pc_1.96+20080213-1_amd64.deb
grub-rescue-pc_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub-rescue-pc_1.96+20080213-1_amd64.deb
grub2_1.96+20080213-1.diff.gz
  to pool/main/g/grub2/grub2_1.96+20080213-1.diff.gz
grub2_1.96+20080213-1.dsc
  to pool/main/g/grub2/grub2_1.96+20080213-1.dsc
grub2_1.96+20080213-1_amd64.deb
  to pool/main/g/grub2/grub2_1.96+20080213-1_amd64.deb
grub2_1.96+20080213.orig.tar.gz
  to pool/main/g/grub2/grub2_1.96+20080213.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Robert Millan <[EMAIL PROTECTED]> (supplier of updated grub2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 13 Feb 2008 16:37:13 +0100
Source: grub2
Binary: grub2 grub-of grub-pc grub-rescue-pc grub-linuxbios grub-efi 
grub-ieee1275
Architecture: source amd64
Version: 1.96+20080213-1
Distribution: unstable
Urgency: low
Maintainer: GRUB Maintainers <[EMAIL PROTECTED]>
Changed-By: Robert Millan <[EMAIL PROTECTED]>
Description: 
 grub-efi   - GRand Unified Bootloader, version 2 (EFI version)
 grub-ieee1275 - GRand Unified Bootloader, version 2 (Open Firmware version)
 grub-linuxbios - GRand Unified Bootloader, version 2 (LinuxBIOS version)
 grub-pc    - GRand Unified Bootloader, version 2 (PC/BIOS version)
 grub-rescue-pc - GRUB bootable rescue images, version 2 (PC/BIOS version)
 grub2      - GRand Unified Bootloader, version 2 (dummy package)
Closes: 426341 461164 463144 464911 464912 464918 465137 465295 465296
Changes: 
 grub2 (1.96+20080213-1) unstable; urgency=low
 .
   * New CVS snapshot.
     - Failure to read one device in a RAID-1 array no longer causes boot
       to fail (so long as there's a member that works).  (Closes: #426341)
   * script: For /proc/mounts, only report lines that start with /dev/.
   * Add new upgrade-from-grub-legacy script for the user to complete the 
upgrade
     process from GRUB Legacy, and advertise it prominently in menu.lst.
     (Closes: #464912)
   * Add a hack to support gfxterm / background_image on systems where /usr
     isn't accessible.  (Closes: #464911, #463144)
     - grub-pc.postinst
     - grub.d/05_debian_theme
   * Fix a pair of spelling mistakes in debconf.  (Closes: #465296)
   * Migrate kopt from menu.lst.  (Closes: #461164, #464918)
 .
   [ Updated translations ]
   * Portuguese (pt.po) by Ricardo Silva (Closes: #465137)
   * German (de.po) by Helge Kreutzmann (Closes: #465295)
Files: 
 c7eaf13ea133c7588e10e962baacaf7f 1481 admin extra grub2_1.96+20080213-1.dsc
 0f41e0686f6c971da69440ec0bb98a05 676223 admin extra 
grub2_1.96+20080213.orig.tar.gz
 a9e0c7280375be9aad0d9b5a5fb02510 34543 admin extra 
grub2_1.96+20080213-1.diff.gz
 3c398f49e99f0c3c0b8a4df837c3ed05 97650 admin extra 
grub2_1.96+20080213-1_amd64.deb
 64d02c9a6947865cf2f844b2aa09c785 1139158 admin extra 
grub-pc_1.96+20080213-1_amd64.deb
 594b6028e23084a9051047fde59145b8 414182 admin extra 
grub-rescue-pc_1.96+20080213-1_amd64.deb
 2b1196486e6f4ea4c984af5c89235b22 1018470 admin extra 
grub-linuxbios_1.96+20080213-1_amd64.deb
 3ffc5e1d87d3fa4d69b97f4c61142f4f 917814 admin extra 
grub-efi_1.96+20080213-1_amd64.deb
 0aa40933efa962967bb9dfaccd0a75cb 1014744 admin extra 
grub-ieee1275_1.96+20080213-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHs1p4C19io6rUCv8RAjqHAJ9IEkA5kRXNuIQbgT+GXxISg0JJ+wCfdazt
OqidOGsbWtymlVKd1D4C5jo=
=877t
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to