Your message dated Sat, 01 Mar 2008 21:38:26 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#454523: fixed in xscreensaver 5.04-3
has caused the Debian Bug report #454523,
regarding xscreensaver hangs if machine is suspended during fade-out/fade-in
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
454523: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=454523
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: xscreensaver
Version: 4.24-5.nix.1
Severity: normal
Tags: patch
If the machine is suspended (using swsusp or similar) while xscreensaver
is fading in or out, and the machine stays in suspended state more
than cca. 72 minutes, an overflow occurs in the code that computes the
sleep time between fade steps, which results in xscreensaver sleeping
for many minutes (without responding to either keyboard, mouse or
xscreensaver-command socket).
Since it is normal to lock the screen before suspending the machine
(eg. the hibernate script has an option that does this automatically),
the probability is high. The only prerequisite is enablig the 'fade'
option of xscreensaver.
A patch is attached (it produces a couple of duplicated code lines, though).
Best regards,
norbi
-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (700, 'stable'), (660, 'oldstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18
Locale: LANG=C, LC_CTYPE=hu_HU (charmap=ISO-8859-2)
Versions of packages xscreensaver depends on:
ii libatk1.0-0 1.12.4-3 The ATK accessibility toolkit
ii libc6 2.3.6.ds1-13etch2 GNU C Library: Shared libraries
ii libcairo2 1.2.4-4 The Cairo 2D vector graphics libra
ii libfontconfig1 2.4.2-1.2 generic font configuration library
ii libglade2-0 1:2.6.0-4 library to load .glade files at ru
ii libglib2.0-0 2.12.4-2 The GLib library of C routines
ii libgtk2.0-0 2.8.20-7 The GTK+ graphical user interface
ii libice6 1:1.0.1-2 X11 Inter-Client Exchange library
ii libjpeg62 6b-13 The Independent JPEG Group's JPEG
ii libpam0g 0.79-4 Pluggable Authentication Modules l
ii libpango1.0-0 1.14.8-5 Layout and rendering of internatio
ii libsm6 1:1.0.1-3 X11 Session Management library
ii libx11-6 2:1.0.3-7 X11 client-side library
ii libxcursor1 1.1.7-4 X cursor management library
ii libxext6 1:1.0.1-2 X11 miscellaneous extension librar
ii libxfixes3 1:4.0.1-5 X11 miscellaneous 'fixes' extensio
ii libxi6 1:1.0.1-4 X11 Input extension library
ii libxinerama1 1:1.0.1-4.1 X11 Xinerama extension library
ii libxml2 2.6.27.dfsg-1 GNOME XML library
ii libxmu6 1:1.0.2-2 X11 miscellaneous utility library
ii libxpm4 1:3.5.5-2 X11 pixmap library
ii libxrandr2 2:1.1.0.2-5 X11 RandR extension library
ii libxrender1 1:0.9.1-3 X Rendering Extension client libra
ii libxt6 1:1.0.2-2 X11 toolkit intrinsics library
ii libxxf86misc1 1:1.0.1-2 X11 XFree86 miscellaneous extensio
ii libxxf86vm1 1:1.0.1-2 X11 XFree86 video mode extension l
Versions of packages xscreensaver recommends:
ii libjpeg-progs 6b-13 Programs for manipulating JPEG fil
ii miscfiles [wordlist] 1.4.2.dfsg.1-7 Dictionaries and other interesting
ii perl [perl5] 5.8.8-7etch1 Larry Wall's Practical Extraction
ii wamerican [wordlist] 6-2 American English dictionary words
ii xli 1.17.0-22 command line tool for viewing imag
ii xloadimage 4.1-16 Graphics file viewer under X11
-- no debconf information
diff -Naur xscreensaver-4.24/utils/fade.c xscreensaver-4.24-fixed/utils/fade.c
--- xscreensaver-4.24/utils/fade.c 2005-06-22 01:47:48.000000000 +0200
+++ xscreensaver-4.24-fixed/utils/fade.c 2007-10-03 21:07:25.000000000 +0200
@@ -12,6 +12,7 @@
#include "utils.h"
#include <sys/time.h> /* for gettimeofday() */
+#include <limits.h>
#ifdef VMS
# include "vms-gtod.h"
@@ -330,12 +331,14 @@
/* If we haven't already used up our alotted time, sleep to avoid
changing the colormap too fast. */
{
- long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
- now.tv_usec - then.tv_usec);
+ if ((now.tv_sec - then.tv_sec) < (LONG_MAX / 1000000 - 1)) {
+ long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
+ now.tv_usec - then.tv_usec);
+ if (usecs_per_step > diff)
+ usleep (usecs_per_step - diff);
+ }
then.tv_sec = now.tv_sec;
then.tv_usec = now.tv_usec;
- if (usecs_per_step > diff)
- usleep (usecs_per_step - diff);
}
}
@@ -531,12 +534,14 @@
/* If we haven't already used up our alotted time, sleep to avoid
changing the colormap too fast. */
{
- long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
- now.tv_usec - then.tv_usec);
+ if ((now.tv_sec - then.tv_sec) < (LONG_MAX / 1000000 - 1)) {
+ long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
+ now.tv_usec - then.tv_usec);
+ if (usecs_per_step > diff)
+ usleep (usecs_per_step - diff);
+ }
then.tv_sec = now.tv_sec;
then.tv_usec = now.tv_usec;
- if (usecs_per_step > diff)
- usleep (usecs_per_step - diff);
}
}
}
@@ -758,12 +763,14 @@
/* If we haven't already used up our alotted time, sleep to avoid
changing the colormap too fast. */
{
- long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
- now.tv_usec - then.tv_usec);
+ if ((now.tv_sec - then.tv_sec) < (LONG_MAX / 1000000 - 1)) {
+ long diff = (((now.tv_sec - then.tv_sec) * 1000000) +
+ now.tv_usec - then.tv_usec);
+ if (usecs_per_step > diff)
+ usleep (usecs_per_step - diff);
+ }
then.tv_sec = now.tv_sec;
then.tv_usec = now.tv_usec;
- if (usecs_per_step > diff)
- usleep (usecs_per_step - diff);
}
}
}
--- End Message ---
--- Begin Message ---
Source: xscreensaver
Source-Version: 5.04-3
We believe that the bug you reported is fixed in the latest version of
xscreensaver, which is due to be installed in the Debian FTP archive:
xscreensaver-data-extra_5.04-3_i386.deb
to pool/main/x/xscreensaver/xscreensaver-data-extra_5.04-3_i386.deb
xscreensaver-data_5.04-3_i386.deb
to pool/main/x/xscreensaver/xscreensaver-data_5.04-3_i386.deb
xscreensaver-gl-extra_5.04-3_i386.deb
to pool/main/x/xscreensaver/xscreensaver-gl-extra_5.04-3_i386.deb
xscreensaver-gl_5.04-3_i386.deb
to pool/main/x/xscreensaver/xscreensaver-gl_5.04-3_i386.deb
xscreensaver_5.04-3.diff.gz
to pool/main/x/xscreensaver/xscreensaver_5.04-3.diff.gz
xscreensaver_5.04-3.dsc
to pool/main/x/xscreensaver/xscreensaver_5.04-3.dsc
xscreensaver_5.04-3_i386.deb
to pool/main/x/xscreensaver/xscreensaver_5.04-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jose Luis Rivas <[EMAIL PROTECTED]> (supplier of updated xscreensaver package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 29 Feb 2008 18:53:35 -0430
Source: xscreensaver
Binary: xscreensaver xscreensaver-data xscreensaver-data-extra xscreensaver-gl
xscreensaver-gl-extra
Architecture: source i386
Version: 5.04-3
Distribution: unstable
Urgency: low
Maintainer: Jose Luis Rivas <[EMAIL PROTECTED]>
Changed-By: Jose Luis Rivas <[EMAIL PROTECTED]>
Description:
xscreensaver - Automatic screensaver for X
xscreensaver-data - data files to be shared among screensaver frontends
xscreensaver-data-extra - data files to be shared among screensaver frontends
xscreensaver-gl - GL(Mesa) screen hacks for xscreensaver
xscreensaver-gl-extra - GL(Mesa) screen hacks for xscreensaver
Closes: 410095 454523 463345
Changes:
xscreensaver (5.04-3) unstable; urgency=low
.
[ Tormod Volden ]
* (From Ubuntu) Include .desktop files for hacks (Closes: #410095)
* debian/xscreensaver-data.files: Skip .desktop file for popsquares
for now until conflict is sorted out with gnome-screensaver that
also ships it
* dropped planetary_gears.desktop (gears goes planetary randomly
and has no command option for it)
* 60_add-ant-hack.patch: restore "ant" (disabled upstream in 4.23)
* Add .desktop description for "ant"
* (From Ubuntu) Split xscreensaver package into:
- xscreensaver (core backend without hacks)
- xscreensaver-data (standard hacks)
- xscreensaver-data-extra (hacks not installed by default)
* (From Ubuntu) Split xscreensaver-gl package into:
- xscreensaver-gl (standard GL hacks)
- xscreensaver-data (GL hacks not installed by default)
* 70_fade_oversleep.patch: don't hang on resume (Closes: #454523)
* 71_endgame_whiter_colour.patch: better contrast (Closes: #463345)
.
[ Jose Luis Rivas ]
* debian/xscreensaver-gl.files: Deleted interplanetary-gears.desktop since
it's not shipped.
Files:
d9745e63e92ef10f5888446abff30ba8 1138 x11 optional xscreensaver_5.04-3.dsc
5521dbc84eeeb67363c0e6132b2e7183 72389 x11 optional xscreensaver_5.04-3.diff.gz
accffc94ac3139ef8e84ad6ab4d33a8a 728522 x11 optional
xscreensaver_5.04-3_i386.deb
e900d9dddc9d16d2cae4d330e04f6e15 482204 x11 optional
xscreensaver-data_5.04-3_i386.deb
ab60946d18fa3af9eb429ce9785914a1 2990590 x11 optional
xscreensaver-data-extra_5.04-3_i386.deb
b531c7bb8e15738986562b63637f69bc 1901976 x11 optional
xscreensaver-gl_5.04-3_i386.deb
3c72985113ec1dff6d8ea47ef402f477 1784726 x11 optional
xscreensaver-gl-extra_5.04-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHyKUkmBxf18ZxJX0RAthTAKCaPzbL0ZGo3/51NvwXbPtQIj8JvgCfRqyV
9mVIBH1cbLA2YJo0kfGnfRk=
=USM+
-----END PGP SIGNATURE-----
--- End Message ---
