Your message dated Sun, 02 Mar 2008 16:02:09 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#468468: fixed in vzctl 3.0.22-5
has caused the Debian Bug report #468468,
regarding vzctl: Bad modification to vps-functions and README.Debian update 
needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
468468: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468468
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: vzctl
Version: 3.0.22-4
Severity: normal

The following modification made by the Debian package is wrong twice:

--- vzctl-3.0.22.orig/scripts/vps-functions.in
+++ vzctl-3.0.22/scripts/vps-functions.in
@@ -143,6 +143,10 @@
        local dev
 
        for dev in $(vz_get_neighbour_devs "$2"); do
+               if [ $(cat /proc/sys/net/ipv4/conf/$dev/proxy_arp) == 0 ] && [ 
"$1" -
eq "add" ] ; then
+                   vzwarning "Function proxy_arp for $dev is set to 0. Enable 
with '
sysctl -w net.ipv4.conf.$dev.proxy_arp=1'. See 
/usr/share/doc/vzctl/README.Debian."
+               fi
+
                ${IP_CMD} neigh "$1" proxy "$2" dev "$dev" >/dev/null 2>&1
        done
 }

=> -eq is for numerical comparison and comparing to "add" is bound to fail:
/usr/lib/vzctl/scripts/vps-functions: line 146: [: add: integer expression 
expected

Just use [ "$1" = "add" ]. 

Likewise "==" is a bashism, you shouldn't use it. And you need to protect the 
$(cat ...) in case it returns an empty value. The correct check is thus:
[ "$(cat /proc/sys/net/ipv4/conf/$dev/proxy_arp)" = "0" ]


And the README.Debian states:

+Network configuration:
+----------------------
+
+If you want network access for the virtual server then you need to
+enable IP forwarding. You do that in the /etc/network/options file
+using the directive.
+
+  ip_forward=yes

=> this is obsolete nowadays, we recommend usage of /etc/sysctl.conf and
net.ipv4.conf.default.forwarding=1


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages vzctl depends on:
ii  iproute                       20080108-1 Professional tools to control the 
ii  libc6                         2.7-9      GNU C Library: Shared libraries
ii  vzquota                       3.0.11-1   server virtualization solution - q

Versions of packages vzctl recommends:
ii  rsync                         2.6.9-6    fast remote file copy program (lik

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: vzctl
Source-Version: 3.0.22-5

We believe that the bug you reported is fixed in the latest version of
vzctl, which is due to be installed in the Debian FTP archive:

vzctl_3.0.22-5.diff.gz
  to pool/main/v/vzctl/vzctl_3.0.22-5.diff.gz
vzctl_3.0.22-5.dsc
  to pool/main/v/vzctl/vzctl_3.0.22-5.dsc
vzctl_3.0.22-5_i386.deb
  to pool/main/v/vzctl/vzctl_3.0.22-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ola Lundqvist <[EMAIL PROTECTED]> (supplier of updated vzctl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  2 Mar 2008 16:44:27 +0100
Source: vzctl
Binary: vzctl
Architecture: source i386
Version: 3.0.22-5
Distribution: unstable
Urgency: low
Maintainer: Ola Lundqvist <[EMAIL PROTECTED]>
Changed-By: Ola Lundqvist <[EMAIL PROTECTED]>
Description: 
 vzctl      - server virtualization solution - control tools
Closes: 468468
Changes: 
 vzctl (3.0.22-5) unstable; urgency=low
 .
   * Updated README.Debian to use /etc/sysctl.conf instead of depricated
     directive in /etc/network/options.
   * Corrected two bashism issues, closes: #468468.
     Thanks to Raphael Hertzog <[EMAIL PROTECTED]> for both the above
     corrections.
Files: 
 41d8890c20da67bb5bc66a1d521da1fb 581 admin optional vzctl_3.0.22-5.dsc
 a2fb3c1bd62325e95a96a7ef6dc8f75f 93896 admin optional vzctl_3.0.22-5.diff.gz
 b5758052d53ec52b27512857d3cab655 191010 admin optional vzctl_3.0.22-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHysz+GKGxzw/lPdkRAsUwAKCVtF7B0khIamp0h3V22xu4mz0MLgCeNWt+
uEnxFHs8aR3/yM7WG8yNnHs=
=KhtR
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to