Your message dated Sun, 02 Mar 2008 22:47:06 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#468654: fixed in zsh 4.3.5-5
has caused the Debian Bug report #468654,
regarding zsh: rsync completion fails to complete remote paths with spaces
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
468654: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468654
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: zsh
Version: 4.3.5-4
Severity: normal
Tags: patch

If I have the following on host 'alpha':

        /tmp/foo bar baz/foo
        /tmp/foo bar baz/bar
        /tmp/foo bar baz/baz

I can do this:

        % rsync alpha:/tmp/foo<TAB>
        -->  % rsync alpha:/tmp/foo\\\ bar\\\ baz/

But I can't continue:

        % rsync alpha:/tmp/foo\\\ bar\\\ baz/<TAB>
        --> no response

Tracing this, I found that it ran a failing 'ls' via ssh, something akin
to this:

        ssh -a -x alpha ls -d1FL "/tmp/foo bar baz/*"

This fails because the quoting only makes the argument appear as a
single argument to 'ssh'; when ssh passes the command to the remote
host, it comes out as trying to list three different files.

The solution is to double-quote the parameter, akin to this:

        ssh -a -x alpha ls -d1FL "\"/tmp/foo bar baz/\"*"

I've attached a patch.  I'm no zsh expert, so it needs review -- I
don't know if I've fixed one thing and broken another.  But it does
seem to work for this situation.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (400, 'testing'), (300, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages zsh depends on:
ii  libc6                     2.7-5          GNU C Library: Shared libraries
ii  libcap1                   1:1.10-14      support for getting/setting POSIX.
ii  libncursesw5              5.6+20080119-1 Shared libraries for terminal hand

Versions of packages zsh recommends:
ii  libpcre3                      7.4-1      Perl 5 Compatible Regular Expressi

-- debconf information:
  zsh/rcmove:
--- /usr/share/zsh/functions/Completion/Unix/_rsync	2008-02-28 00:39:09.000000000 -0500
+++ /usr/share/zsh-beta/functions/Completion/Unix/_rsync	2008-02-29 14:46:52.000000000 -0500
@@ -58,7 +58,7 @@
 elif compset -P 1 '*:'; then
 
   if zstyle -T ":completion:${curcontext}:files" remote-access; then
-    remfiles=(${(M)${(f)"$(_call_program files ssh -a -x ${IPREFIX%:} ls -d1FL "${(Q)PREFIX%%[^./][^/]#}\*" 2>/dev/null)"}%%[^/]#(|/)})
+    remfiles=(${(M)${(f)"$(_call_program files ssh -a -x ${IPREFIX%:} ls -d1FL "\"${(Q)PREFIX%%[^./][^/]#}\"\*" 2>/dev/null)"}%%[^/]#(|/)})
     compset -P '*/'
     compset -S '/*' || suf='remote file'
 

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: zsh
Source-Version: 4.3.5-5

We believe that the bug you reported is fixed in the latest version of
zsh, which is due to be installed in the Debian FTP archive:

zsh-doc_4.3.5-5_all.deb
  to pool/main/z/zsh/zsh-doc_4.3.5-5_all.deb
zsh_4.3.5-5.diff.gz
  to pool/main/z/zsh/zsh_4.3.5-5.diff.gz
zsh_4.3.5-5.dsc
  to pool/main/z/zsh/zsh_4.3.5-5.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Clint Adams <[EMAIL PROTECTED]> (supplier of updated zsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 02 Mar 2008 16:55:13 -0500
Source: zsh
Binary: zsh zsh-doc zsh-static zsh-dev zsh-dbg
Architecture: source all
Version: 4.3.5-5
Distribution: unstable
Urgency: medium
Maintainer: Clint Adams <[EMAIL PROTECTED]>
Changed-By: Clint Adams <[EMAIL PROTECTED]>
Description: 
 zsh        - A shell with lots of features
 zsh-dbg    - A shell with lots of features (debugging symbols)
 zsh-dev    - A shell with lots of features (development files)
 zsh-doc    - zsh documentation - info/HTML format
 zsh-static - A shell with lots of features (static link)
Closes: 468654
Changes: 
 zsh (4.3.5-5) unstable; urgency=medium
 .
   * Fix completion of rsync -e ssh remote pathnames containing spaces.
     closes: #468654.
Files: 
 6e334ab4f386748306401309a885b77b 915 shells optional zsh_4.3.5-5.dsc
 ddc88f7ed7843ec6fcc41f75a6fed08f 53365 shells optional zsh_4.3.5-5.diff.gz
 9e6ce616df294fec272b13bdefcd421a 2124228 doc optional zsh-doc_4.3.5-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Debian!

iD8DBQFHyywD5m0u66uWM3ARAsjuAJ9Mp+X6H+FGPNuEXhwiEUrScKQDCwCgicQb
D+wE9OPwBT+8R70uUtiUpLg=
=gSfi
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to