Your message dated Mon, 23 May 2005 08:39:12 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#310071: libdjbdns: Tests broken.
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 21 May 2005 12:40:15 +0000
>From [EMAIL PROTECTED] Sat May 21 05:40:15 2005
Return-path: <[EMAIL PROTECTED]>
Received: from poros.telenet-ops.be [195.130.132.44]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DZTH5-0002Zt-00; Sat, 21 May 2005 05:40:15 -0700
Received: from localhost (localhost.localdomain [127.0.0.1])
by poros.telenet-ops.be (Postfix) with SMTP id 1F82F3BCE90
for <[EMAIL PROTECTED]>; Sat, 21 May 2005 14:40:14 +0200 (MEST)
Received: from Q.roeckx.be (dD5775FD9.access.telenet.be [213.119.95.217])
by poros.telenet-ops.be (Postfix) with ESMTP id 0BE053BC8ED
for <[EMAIL PROTECTED]>; Sat, 21 May 2005 14:40:14 +0200 (MEST)
Received: by Q.roeckx.be (Postfix, from userid 501)
id 93A4B26136; Sat, 21 May 2005 14:40:13 +0200 (CEST)
Date: Sat, 21 May 2005 14:40:13 +0200
From: Kurt Roeckx <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: libdjbdns: Tests broken.
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.1i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: libdjbdns
Version: 1.05-3
Severity: important
Hi,
The test the package does it broken. test.c says:
dns_domain_length(sa.s);
dns_domain_equal(sa.s, sa.s);
dns_domain_copy(&dn, sa.s);
The sa.s arguments to those functions are not in the format the
function expects them to be in. sa.s is set to "abcdefg", which
is a normal string. It expected to get something like
"\aabcdefg", where the '\a' says the rest of the string is 7
chars long. dns_domain_length() now things 'a' is the length so
assume it's 97 chars long, and then goes and access memory it
shouldn't. Note that the first thing the 2 other function do is
calling dns_domain_length() on those sa.s's.
Also, the test script doesn't check any return type or anything,
so I don't really see the value of it.
Kurt
---------------------------------------
Received: (at 310071-done) by bugs.debian.org; 23 May 2005 08:35:27 +0000
>From [EMAIL PROTECTED] Mon May 23 01:35:27 2005
Return-path: <[EMAIL PROTECTED]>
Received: from a.mx.smarden.org [212.21.76.77]
by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
id 1Da8PH-0000UN-00; Mon, 23 May 2005 01:35:27 -0700
Received: (qmail 23643 invoked by uid 1000); 23 May 2005 08:35:40 -0000
Message-ID: <[EMAIL PROTECTED]>
Date: Mon, 23 May 2005 08:39:12 +0000
From: Gerrit Pape <[EMAIL PROTECTED]>
To: Kurt Roeckx <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
Subject: Re: Bug#310071: libdjbdns: Tests broken.
Reply-To: [EMAIL PROTECTED]
References: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
On Sat, May 21, 2005 at 02:40:13PM +0200, Kurt Roeckx wrote:
> Package: libdjbdns
> Version: 1.05-3
> Severity: important
Hi, you think a non-perfect library selftest is an important bug? What
severity do you use when reporting bugs against all those library
packages that don't include any selftest at all?
> Hi,
>
> The test the package does it broken. test.c says:
> dns_domain_length(sa.s);
> dns_domain_equal(sa.s, sa.s);
> dns_domain_copy(&dn, sa.s);
>
> The sa.s arguments to those functions are not in the format the
> function expects them to be in. sa.s is set to "abcdefg", which
> is a normal string. It expected to get something like
> "\aabcdefg", where the '\a' says the rest of the string is 7
> chars long. dns_domain_length() now things 'a' is the length so
> assume it's 97 chars long, and then goes and access memory it
> shouldn't. Note that the first thing the 2 other function do is
> calling dns_domain_length() on those sa.s's.
>
> Also, the test script doesn't check any return type or anything,
> so I don't really see the value of it.
It ensures that programs using the public library functions do actually
compile, and don't fail with undefined references or so.
I you want to improve the selftest, I would be happy to review and
consider a patch.
Gerrit.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
