Your message dated Sat, 15 Mar 2008 15:32:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#469841: fixed in mediawiki 1:1.11.2-2
has caused the Debian Bug report #469841,
regarding mediawiki: select fixes for postgreSQL backend
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
469841: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=469841
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: mediawiki
Version: 1:1.11.1-1
Tags: patch
Coin fellow DD,
I've managed to fix a few problems in the pg support (but still many
remains). This patch would solve SELECT requests with ORDER BY or GROUP
BY, which request having the fields of these options be added in the
fetched fields in certains conditions. I'm not sure all cases are
matched, but the most usual ones are.
Regards.
--- includes/DatabasePostgres.php.orig 2008-03-05 14:45:05.000000000 +0100
+++ includes/DatabasePostgres.php 2008-03-07 13:59:57.000000000 +0100
@@ -87,6 +87,44 @@
}
+ /**
+ * SELECT wrapper
+ *
+ * @param mixed $table Array or string, table name(s) (prefix auto-added)
+ * @param mixed $vars Array or string, field name(s) to be retrieved
+ * @param mixed $conds Array or string, condition(s) for WHERE
+ * @param string $fname Calling function name (use __METHOD__) for logs/profiling
+ * @param array $options Associative array of options (e.g. array('GROUP BY' => 'page_title')),
+ * see Database::makeSelectOptions code for list of supported stuff
+ * @return mixed Database result resource (feed to Database::fetchObject or whatever), or false on failure
+ */
+ function select( $table, $vars, $conds='', $fname = 'Database::select', $options = array() )
+ {
+ $noKeyOptions = array();
+ foreach ( $options as $key => $option ) {
+ if ( is_numeric( $key ) ) {
+ $noKeyOptions[$option] = true;
+ }
+ }
+
+ if (is_array($vars) === false) {
+ $vars = (string)$vars;
+ $var_list = explode(',', $vars);
+ }
+ else {
+ $var_list = $vars;
+ $vars = implode(',', $var_list);
+ }
+
+ ## in certain conditions with ORDER BY and GROUP BY, the specified fields *MUST* be included in fetched data
+ if (array_key_exists('ORDER BY', $options) && (strpos($vars, '(') === false) && ((stripos($vars, "DISTINCT ") !== false) || (array_key_exists('DISTINCT', $noKeyOptions))))
+ $var_list[] = preg_replace("/ (ASC|DESC|USING .*?)(,| |$)/i", "", $options['ORDER BY']);
+ else if (array_key_exists('GROUP BY', $options))
+ $var_list[] = $options['GROUP BY'];
+
+ return parent::select( $table, $var_list, $conds, $fname, $options );
+ }
+
function cascadingDeletes() {
return true;
}
--
Marc Dequènes
Homepage: http://www.proformatique.com/
Proformatique - 67 rue Voltaire - 92800 Puteaux
Tel. : 01 41 38 99 64 - Fax. : 01 41 38 99 70
pgpiCbkVezIQO.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: mediawiki
Source-Version: 1:1.11.2-2
We believe that the bug you reported is fixed in the latest version of
mediawiki, which is due to be installed in the Debian FTP archive:
mediawiki-math_1.11.2-2_amd64.deb
to pool/main/m/mediawiki/mediawiki-math_1.11.2-2_amd64.deb
mediawiki_1.11.2-2.diff.gz
to pool/main/m/mediawiki/mediawiki_1.11.2-2.diff.gz
mediawiki_1.11.2-2.dsc
to pool/main/m/mediawiki/mediawiki_1.11.2-2.dsc
mediawiki_1.11.2-2_all.deb
to pool/main/m/mediawiki/mediawiki_1.11.2-2_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Romain Beauxis <[EMAIL PROTECTED]> (supplier of updated mediawiki package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 03 Mar 2008 13:58:57 +0100
Source: mediawiki
Binary: mediawiki mediawiki-math
Architecture: source all amd64
Version: 1:1.11.2-2
Distribution: unstable
Urgency: high
Maintainer: Mediawiki Maintenance Team <[EMAIL PROTECTED]>
Changed-By: Romain Beauxis <[EMAIL PROTECTED]>
Description:
mediawiki - website engine for collaborative work
mediawiki-math - math rendering plugin for MediaWiki
Closes: 469558 469841
Changes:
mediawiki (1:1.11.2-2) unstable; urgency=high
.
* Added patch to fix pgsql select, thanks to Marc Dequènes
Closes: #469841
* Upated README.Debian to mention php5-gd instead of php5-gd2
and texlive-latex-base instead to tetex-bin.
Closes: #469558
* still setting urgency to high since previous upload didn't make it
to testing.
Files:
faeefb8cc138d2ea51f1ff9ca94bb0a8 832 web optional mediawiki_1.11.2-2.dsc
eced0ce1942d3761d1d7b84ccffeab55 30598 web optional mediawiki_1.11.2-2.diff.gz
43b8e2eba19c91b2a496d290a775f2f2 4904864 web optional
mediawiki_1.11.2-2_all.deb
62dc760f3eb6b8260f8b3f82da5f21bb 154754 web optional
mediawiki-math_1.11.2-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFH2+nDnuQ3Rt5ZmAARAsbEAJsFjUY5DmmHundKO2h8ONoD8zoWfACgiVpA
zRz65LSNf8mAwWQSLwlW/R0=
=NQOp
-----END PGP SIGNATURE-----
--- End Message ---
