Your message dated Fri, 04 Apr 2008 13:02:47 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#473692: fixed in secvpn 2.21+nmu1
has caused the Debian Bug report #473692,
regarding secvpn: bashism in /bin/sh script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
473692: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=473692
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: secvpn
Severity: important
Version: 2.21
User: [EMAIL PROTECTED]
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing a /bin/sh script making 
use of a bashism.

checkbashisms' output:
> possible bashism in ./usr/sbin/secvpn line 85 (echo -e):
>           echo -e "saving ssh route: route add -host $_testip gw $gw\r"
> possible bashism in ./usr/sbin/secvpn line 100 (echo -e):
>     [ "$SILENT" ] || echo -e "Starting Secure VPN $THIS_IS -> $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 104 (echo -e):
>     [ "$VERBOSE" ] && echo -e "ssh ... $O_BAD_IP\r"
> possible bashism in ./usr/sbin/secvpn line 110 (echo -e):
>       [ "$VERBOSE" ] && echo -e "pppd ... $T_CRYPT_IP:$O_CRYPT_IP ... \r"
> possible bashism in ./usr/sbin/secvpn line 116 (echo -e):
>         [ "$VERBOSE" ] && echo -e "Starting recursive on $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 123 (echo -e):
>     [ "$SILENT" ] || echo -e "start: Nothing to do for $OTHER_IS ->
> $THIS_IS\r" possible bashism in ./usr/sbin/secvpn line 131 (echo -e):
>   [ "$SILENT" ] || echo -e "routeadd $THIS_IS -> $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 142 (echo -e):
>     [ "$VERBOSE" ] && echo -e "route add `route_area $i` gw $O_CRYPT_IP\r"
> possible bashism in ./usr/sbin/secvpn line 150 (echo -e):
>         echo -e "ask remote $OTHER_IS to add back route to $CONNECTED\r"
> possible bashism in ./usr/sbin/secvpn line 152 (echo -e):
>        echo -e "ask remote $OTHER_IS to add back route\r"
> possible bashism in ./usr/sbin/secvpn line 160 (echo -e):
>       [ "$VERBOSE" ] && echo -e "Routeadd recursive on $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 174 (echo -e):
>     echo -e "$OTHER_IS"
> possible bashism in ./usr/sbin/secvpn line 191 (echo -e):
>     [ "$SILENT" ] || echo -e "$INFO"
> possible bashism in ./usr/sbin/secvpn line 194 (echo -e):
>     echo -e "$INFO"
> possible bashism in ./usr/sbin/secvpn line 200 (echo -e):
>       [ "$VERBOSE" ] && echo -e "Testing recursive on $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 213 (echo -e):
>       [ "$SILENT" ] || echo -e "[$wt] wait_for_ppp($O_CRYPT_IP) UP\r"
> possible bashism in ./usr/sbin/secvpn line 216 (echo -e):
>     [ "$SILENT" ] || echo -e "[$wt] wait_for_ppp($O_CRYPT_IP) DOWN\r"
> possible bashism in ./usr/sbin/secvpn line 225 (echo -e):
>   [ "$SILENT" ] || echo -e "stop $THIS_IS -> $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 231 (echo -e):
>     [ "$VERBOSE" ] && echo -e "shutting down $PL\r"
> possible bashism in ./usr/sbin/secvpn line 237 (echo -e):
>     [ "$VERBOSE" ] && echo -e "shutting down $PL\r"
> possible bashism in ./usr/sbin/secvpn line 244 (echo -e):
>     [ "$VERBOSE" ] && echo -e "killing:\n$PL\r"
> possible bashism in ./usr/sbin/secvpn line 251 (echo -e):
>     [ "$VERBOSE" ] && echo -e "killing -9\n$PL\r"
> possible bashism in ./usr/sbin/secvpn line 257 (echo -e):
>     [ "$VERBOSE" ] && echo -e "ask remote $OTHER_IS ($O_BAD_IP) to stop\r"
> possible bashism in ./usr/sbin/secvpn line 262 (echo -e):
>       [ "$VERBOSE" ] && echo -e "Stopping recursive on $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 271 (echo -e):
>   [ "$SILENT" ] || echo -e "routedel $THIS_IS -> $OTHER_IS\r"
> possible bashism in ./usr/sbin/secvpn line 276 (echo -e):
>     [ "$VERBOSE" ] && echo -e "route del `route_area $i` gw $O_CRYPT_IP\r"
> possible bashism in ./usr/sbin/secvpn line 281 (echo -e):
>     [ "$VERBOSE" ] && echo -e "ask remote $OTHER_IS to delete back route\r"
> possible bashism in ./usr/sbin/secvpn line 286 (echo -e):
>       [ "$VERBOSE" ] && echo -e "Routedel recursive on $OTHER_IS\r"

Not using bash (or a Debian Policy conformant shell interpreter which doesn't 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



--- End Message ---
--- Begin Message ---
Source: secvpn
Source-Version: 2.21+nmu1

We believe that the bug you reported is fixed in the latest version of
secvpn, which is due to be installed in the Debian FTP archive:

secvpn_2.21+nmu1.dsc
  to pool/main/s/secvpn/secvpn_2.21+nmu1.dsc
secvpn_2.21+nmu1.tar.gz
  to pool/main/s/secvpn/secvpn_2.21+nmu1.tar.gz
secvpn_2.21+nmu1_all.deb
  to pool/main/s/secvpn/secvpn_2.21+nmu1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Peter Eisentraut <[EMAIL PROTECTED]> (supplier of updated secvpn package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 04 Apr 2008 14:34:45 +0200
Source: secvpn
Binary: secvpn
Architecture: source all
Version: 2.21+nmu1
Distribution: unstable
Urgency: low
Maintainer: Bernd Schumacher <[EMAIL PROTECTED]>
Changed-By: Peter Eisentraut <[EMAIL PROTECTED]>
Description: 
 secvpn     - Secure Virtual Private Network
Closes: 469753 473692
Changes: 
 secvpn (2.21+nmu1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Added LSB formatted dependency info in init.d script (closes: #469753)
   * Changed /usr/sbin/secvpn to use bash because it is full of bashisms
     (closes: #473692)
Files: 
 a9db03c9910380c59d2de922aac553ad 539 net optional secvpn_2.21+nmu1.dsc
 c8a247a39ccdccb80a5dc58a9e99f4ac 218744 net optional secvpn_2.21+nmu1.tar.gz
 be834a3c6da8df8eddbe620579f65d43 222476 net optional secvpn_2.21+nmu1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH9iWuTTx8oVVPtMYRAmowAKCEUgQMm6wisPMe2iYsDdStFMUHfgCePuEP
5Ga2PGDatCdpCSLzkiQuhJo=
=8UXe
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to