Your message dated Sun, 27 Apr 2008 23:50:52 +0100
with message-id <[EMAIL PROTECTED]>
and subject line xmms has been removed from Debian, closing #82920
has caused the Debian Bug report #82920,
regarding vorbis input plugin is slow to recognize input files (patch)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
82920: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=82920
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: xmms
Version: 1.2.4-1.1
Severity: minor
It takes a long time to scan a page worth of playlist entries containing Ogg
Vorbis files. Part of the problem seems to be that the library takes a little
while to extract the song info, but another problem is that the plugin does an
expensive ov_open just to check whether a file is an Ogg Vorbis stream.
Attached is a patch that changes this behavior, so that it will only check for
the magic number at the beginning of the file (but still do a full ov_open to
read the song info). This results in a noticeable performance improvement
on my system.
There still seem to be some concurrency issues; I still get a lot of segfaults
with "Xlib: unexpected async reply (sequence <blah>)!", even after applying the
patch from #78463.
-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux mizar 2.4.0 #1 Sat Jan 6 09:34:06 EST 2001 i686
Versions of packages xmms depends on:
ii libc6 2.2.1-1 GNU C Library: Shared libraries an
ii libglib1.2 1.2.8-2 The GLib library of C routines
ii libgtk1.2 1.2.8-3 The GIMP Toolkit set of widgets fo
ii xlibs 4.0.2-1 X Window System client libraries
--
- mdz
--- vorbis.c.orig Fri Jan 19 15:25:55 2001
+++ vorbis.c Fri Jan 19 15:20:09 2001
@@ -83,7 +83,7 @@
vorbis_check_file(char *filename)
{
FILE *stream;
- OggVorbis_File vf; /* avoid thread interaction */
+ char buf[4];
/* This isn't supported... yet */
if(strncasecmp(filename, "http://";, 7) == 0)
@@ -92,17 +92,17 @@
if((stream = fopen(filename, "r")) == NULL)
return FALSE;
- /* The open function performs full stream detection and machine
- initialization. If it returns zero, the stream *is* Vorbis and
- we're fully ready to decode. */
- if(ov_open(stream, &vf, NULL, 0) < 0) {
- fclose(stream);
- return FALSE;
+ if (fread(buf, 1, 4, stream) != 4) {
+ fclose(stream);
+ return(FALSE);
}
- ov_clear(&vf); /* once the ov_open succeeds, the stream belongs to
- vorbisfile.a. ov_clear will fclose it */
- return TRUE;
+ fclose(stream);
+
+ if (strncmp(buf, "OggS", 4) == 0)
+ return TRUE;
+ else
+ return FALSE;
}
static void
--- End Message ---
--- Begin Message ---
Version: 1:1.2.10+20070601-1+rm
The xmms package has been removed from Debian testing, unstable and
experimental, so I am now closing the bugs that were still opened
against it.
For more information about this package's removal, read
http://bugs.debian.org/461309 . That bug might give the reasons why
this package was removed, and suggestions of possible replacements.
Don't hesitate to reply to this mail if you have any question.
Thank you for your contribution to Debian.
--
Marco Rodrigues
http://Marco.Tondela.org
--- End Message ---
