Your message dated Sat, 17 May 2008 09:47:05 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#480993: fixed in reprepro 3.4.2-1
has caused the Debian Bug report #480993,
regarding reprepro: Segfaults when calling log notification script without a 
'causing file'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
480993: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480993
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: reprepro
Version: 3.4.1-1
Severity: normal
Tags: patch

Using copysrc to copy some files that are /already/ in the destination
repo:

----------------------------
[EMAIL PROTECTED]:~/apt$ cat conf/updatehook
#!/bin/sh
exit 0
[EMAIL PROTECTED]:~/apt$ reprepro -V copysrc prod-sarge dvl-sarge
bds-triton-cert
Adding 'bds-triton-cert' '3.1~test1' to 'prod-sarge|bds|i386'.
Warning: downgrading 'bds-triton-cert' from '3.1~test1' to '3.1~test1' in 
'prod-sarge|bds|i386'!
Adding 'bds-triton-cert' '3.1~test1' to 'prod-sarge|bds|amd64'.
Warning: downgrading 'bds-triton-cert' from '3.1~test1' to '3.1~test1' in 
'prod-sarge|bds|amd64'!
Adding 'bds-triton-cert' '3.1~test1' to 'prod-sarge|bds|source'.
Warning: downgrading 'bds-triton-cert' from '3.1~test1' to '3.1~test1' in 
'prod-sarge|bds|source'!
Notification process '/home/repo/apt/conf/updatehook' killed with signal 11!
Segmentation fault
----------------------------

Analysis (getting gdb to follow the right child process):

----------------------------
0xa7cfb53b in strlen () from /lib/tls/i686/cmov/libc.so.6
(gdb) bt
#0  0xa7cfb53b in strlen () from /lib/tls/i686/cmov/libc.so.6
#1  0xa7cadb6a in putenv () from /lib/tls/i686/cmov/libc.so.6
#2  0xa7cadf03 in setenv () from /lib/tls/i686/cmov/libc.so.6
#3  0x0805c296 in startchild () at log.c:567
#4  0x0805cf87 in notificator_enqueue (n=0x80b75f0, target=0x80b77b8, 
    name=0x80cb368 "bds-triton-cert", version=0x80cbc60 "3.1~test1", 
    oldversion=0x80cb0e0 "3.1~test1", 
    control=0x80cec78 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., 
    oldcontrol=0x80c69d8 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., filekeys=0x80cb350, 
    oldfilekeys=0xafd594d0, renotification=false) at log.c:848
#5  0x0805d5d3 in logger_log (log=0x80b7108, target=0x80b77b8, 
    name=0x80cb368 "bds-triton-cert", version=0x80cbc60 "3.1~test1", 
    oldversion=0x80cb0e0 "3.1~test1", 
    control=0x80cec78 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., 
    oldcontrol=0x80c69d8 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., filekeys=0x80cb350, 
    oldfilekeys=0xafd594d0) at log.c:1021
#6  0x08083eb7 in addpackages (target=0x80b77b8, database=0x80b9250, 
    packagename=0x80cb368 "bds-triton-cert", 
    controlchunk=0x80cec78 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., 
    oldcontrolchunk=0x80c69d8 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., 
    version=0x80cbc60 "3.1~test1", oldversion=0x80cb0e0 "3.1~test1", 
files=0x80cb350, 
    oldfiles=0xafd594d0, logger=0x80b7108, dereferencedfilekeys=0xafd59680, 
    trackingdata=0x0, filetype=ft_SOURCE, oldsource=0x0, oldsversion=0x0) at 
target.c:349
#7  0x080843ff in target_addpackage (target=0x80b77b8, logger=0x80b7108, 
    database=0x80b9250, name=0x80cb368 "bds-triton-cert", version=0x80cbc60 
"3.1~test1", 
    control=0x80cec78 "Package: bds-triton-cert\nFormat: 1.0\nVersion: 
3.1~test1\nBinary: bds-triton-cert\nMaintainer: paul cannon <[EMAIL 
PROTECTED]>\nArchitecture: all\nStandards-Version: 3.6.1\nBuild-Depends: 
debhelper (>= "..., filekeys=0x80cb350, 
    usedmarker=0x0, downgrade=true, dereferencedfilekeys=0xafd59680, 
trackingdata=0x0, 
    filetype=ft_SOURCE) at target.c:451
#8  0x0804b116 in package_add (database=0x80b9250, into=0x80b7330, tracks=0x0, 
    target=0x80b77b8, package=0x80cb328, dereferencedfilekeys=0xafd59680)
    at copypackages.c:276
#9  0x0804b286 in packagelist_add (database=0x80b9250, into=0x80b7330, 
list=0xafd595e4, 
    dereferencedfilekeys=0xafd59680) at copypackages.c:322
#10 0x0804b9e1 in copy_by_source (database=0x80b9250, into=0x80b7330, 
from=0x80b7e20, 
    argc=1, argv=0xafd59828, component=0x0, architecture=0x0, packagetype=0x0, 
    dereferenced=0xafd59680) at copypackages.c:505
#11 0x0808a957 in action_d_y_n_copysrc (alldistributions=0x80b7330, 
database=0x80b9250, 
    dereferenced=0xafd59680, dummy_section=0x0, dummy_priority=0x0, 
architecture=0x0, 
    component=0x0, packagetype=0x0, argc=4, argv=0xafd5981c) at main.c:1233
#12 0x0808dde8 in callaction (action=0x80b0358, argc=4, argv=0xafd5981c) at 
main.c:2557
#13 0x0808f57b in main (argc=6, argv=0xafd59814) at main.c:3151
(gdb) up
#1  0xa7cadb6a in putenv () from /lib/tls/i686/cmov/libc.so.6
(gdb) up
#2  0xa7cadf03 in setenv () from /lib/tls/i686/cmov/libc.so.6
(gdb) up
#3  0x0805c296 in startchild () at log.c:567
567                             setenv("REPREPRO_CAUSING_FILE", p->causingfile, 
true);
(gdb) p p->causingfile
$4 = 0x632d6e6f <Address 0x632d6e6f out of bounds>
----------------------------

Looks like when notification_process instances are created (log.c:826), they
aren't zeroed, and if there isn't a causingfile, that member never gets set
(for standard notification processes only. Notification processes for
.changes files do properly set it to 0 in this case).

Short patch:

============================
--- log.c       2008-04-13 04:43:09.000000000 -0600
+++ ../log.c    2008-05-12 18:14:54.000000000 -0600
@@ -833,7 +833,8 @@
                        free(p);
                        return RET_ERROR_OOM;
                }
-       }
+       } else
+               p->causingfile = NULL;
        p->arguments = arguments;
        p->next = NULL;
        p->child = 0;
============================

-- 
paul

(Yeah, I know I suck for investigating this bug on an oldstable machine
with backports scattered around, but it was the only convenient place.
Pretty sure the bug is still valid anywhere else.)

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.17-2-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages reprepro depends on:
ii  libarchive1        1.2.53-2etch1~bpo31+1 Single library to read/write tar, 
ii  libbz2-1.0         1.0.2-7               high-quality block-sorting file co
ii  libc6              2.3.2.ds1-22sarge6    GNU C Library: Shared libraries an
ii  libdb4.3           4.3.27-2              Berkeley v4.3 Database Libraries [
ii  libgpg-error0      1.0-1                 library for common error values an
ii  libgpgme11         1.0.2-1               GPGME - GnuPG Made Easy
ii  zlib1g             1:1.2.2-4.sarge.2     compression library - runtime

-- no debconf information

Attachment: pgphyreBAM13w.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: reprepro
Source-Version: 3.4.2-1

We believe that the bug you reported is fixed in the latest version of
reprepro, which is due to be installed in the Debian FTP archive:

reprepro_3.4.2-1.diff.gz
  to pool/main/r/reprepro/reprepro_3.4.2-1.diff.gz
reprepro_3.4.2-1.dsc
  to pool/main/r/reprepro/reprepro_3.4.2-1.dsc
reprepro_3.4.2-1_sparc.deb
  to pool/main/r/reprepro/reprepro_3.4.2-1_sparc.deb
reprepro_3.4.2.orig.tar.gz
  to pool/main/r/reprepro/reprepro_3.4.2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bernhard R. Link <[EMAIL PROTECTED]> (supplier of updated reprepro package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 16 May 2008 18:40:11 CEST
Source: reprepro
Binary: reprepro
Architecture: source sparc
Version: 3.4.2-1
Distribution: unstable
Urgency: high
Maintainer: Bernhard R. Link <[EMAIL PROTECTED]>
Changed-By: Bernhard R. Link <[EMAIL PROTECTED]>
Description:
 reprepro   - Debian package repository producer
Closes: 480993
Changes:
 reprepro (3.4.2-1) unstable; urgency=high
 .
   * new bugfix release
   - do not segfault uppong remove with Log-script (closes: 480993)
Checksums-Sha1: 
 23cd86e7e06a6136b3fd70641681727912716b0d 1343 reprepro_3.4.2-1.dsc
 1b5b0ff8568a56c9c8d30bc2cc84fba7505616eb 442330 reprepro_3.4.2.orig.tar.gz
 3f0ea59c556aaeba627da595d2f4f4fd53671cb7 8507 reprepro_3.4.2-1.diff.gz
 058a8203135c081f53cfb35d34f30692f652b4df 327372 reprepro_3.4.2-1_sparc.deb
Checksums-Sha256:
 ad178bca6fe8ae4a097cde4459b9e2c38818aab4ee809946796fcdee5e836b36 1343 
reprepro_3.4.2-1.dsc
 dcac01a3b8e7ed47afb4e24ed7118271788c6b91f4621a3a7b7bd2dbd5da208c 442330 
reprepro_3.4.2.orig.tar.gz
 e8e7af823e691b707975c793a1cb3a9c836b89c216fd6c03d985320b6de0f3c3 8507 
reprepro_3.4.2-1.diff.gz
 2f3242fe10649eaec6890e16e6d99c9df0439e04825ebeb34d354fda7a75ec7e 327372 
reprepro_3.4.2-1_sparc.deb
Files: 
 71b0e2f4c6552a2ac9fa28d83940c86a 1343 utils extra reprepro_3.4.2-1.dsc
 a983b5892596caa1af45d70790b43140 442330 utils extra reprepro_3.4.2.orig.tar.gz
 2d195bf4bff1e88f8714fccf87cde880 8507 utils extra reprepro_3.4.2-1.diff.gz
 419d35afaa8d32ddd60424dad2d24870 327372 utils extra reprepro_3.4.2-1_sparc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQCVAwUBSC6oZFsyKVgPHZLaAQI0tAQAnc8pS/ANh//tGlpT6pfV43N7TF3AW9Wm
tGepOWMjcat8UEUrp0s52BTtbgUy0DWSzFk+53uH/SS5/8rLpKwTfzTeJnZ4Q90u
QSVbbcLBPEK70yf2Kaz3XVBxqeEe+sPlfRy+BdWY1RUT4oCSy79scr3RKYIGZVFk
PhIro9mvSjA=
=KgUm
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to