Your message dated Mon, 02 Jun 2008 19:47:12 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#483815: fixed in xosview 1.8.3+debian-7 has caused the Debian Bug report #483815, regarding xosview crashes if interrupt numbers exceed 1024 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 483815: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483815 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: xosview Version: 1.8.3+debian-6 Severity: normal Tags: patch xosview has a fixed-size array mapping numbers from /proc/interrupts to interrupt indicator positions. The size of this map is 1024. On some x86-64 system (and probably modern i386 systems too) with PCI express, the interrupt numbers the kernel uses for the Message Signalled Interrupt might well exceed 1024. The appended patch makes xosview use a dynamic map instead of an static array. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable'), (490, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.25 (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages xosview depends on: ii libc6 2.7-10 GNU C Library: Shared libraries ii libgcc1 1:4.3.0-3 GCC support library ii libstdc++6 4.3.0-3 The GNU Standard C++ Library v3 ii libx11-6 2:1.0.3-7 X11 client-side library xosview recommends no packages. -- no debconf information #! /bin/sh /usr/share/dpatch/dpatch-run ## handle_high_irq_numbers.dpatch by <[EMAIL PROTECTED]> ## ## Uses a dynamic map instead of a fixed-size array for interrupt mapping, ## as some x86-64 systems have the MSI interrupts way beyond 1024. @DPATCH@ diff -urNad xosview-1.8.3+debian~/linux/intmeter.cc xosview-1.8.3+debian/linux/intmeter.cc --- xosview-1.8.3+debian~/linux/intmeter.cc 2008-05-31 12:25:04.656454148 +0200 +++ xosview-1.8.3+debian/linux/intmeter.cc 2008-05-31 12:27:10.861106922 +0200 @@ -11,13 +11,14 @@ #include "cpumeter.h" #include <fstream> #include <sstream> +#include <map> #include <stdlib.h> static const char *INTFILE = "/proc/interrupts"; static const char *VERSIONFILE = "/proc/version"; -static int realintnum[1024]; +std::map<int,int> realintnum; IntMeter::IntMeter( XOSView *parent, int cpu) : BitMeter( parent, "INTS", "", 1, @@ -114,10 +115,11 @@ setNumBits(n+1); std::ostringstream os; - os << "INTs (0-16" ; - for (int i=16; i<1024; i++) { - if (realintnum[i]) - os << ", " << (i) ; + os << "INTs (0-15" ; + for (std::map<int,int>::const_iterator it = realintnum.upper_bound(15), + end = realintnum.end(); + it != end; ++it) { + os << ", " << it->first ; } os << ")" << std::ends; @@ -161,11 +163,8 @@ } if (!_old) { - for (i=0; i<1024; i++) // init index into int array - if (i < 16) // first 16 map directly - realintnum[i] = i; - else - realintnum[i] = 0; + for (i=0; i<16; i++) // Map first 16 interrupts directly + realintnum[i] = i; intfile.ignore(1024, '\n'); }
--- End Message ---
--- Begin Message ---Source: xosview Source-Version: 1.8.3+debian-7 We believe that the bug you reported is fixed in the latest version of xosview, which is due to be installed in the Debian FTP archive: xosview_1.8.3+debian-7.diff.gz to pool/main/x/xosview/xosview_1.8.3+debian-7.diff.gz xosview_1.8.3+debian-7.dsc to pool/main/x/xosview/xosview_1.8.3+debian-7.dsc xosview_1.8.3+debian-7_amd64.deb to pool/main/x/xosview/xosview_1.8.3+debian-7_amd64.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Kartik Mistry <[EMAIL PROTECTED]> (supplier of updated xosview package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Mon, 02 Jun 2008 19:44:59 +0530 Source: xosview Binary: xosview Architecture: source amd64 Version: 1.8.3+debian-7 Distribution: unstable Urgency: low Maintainer: Kartik Mistry <[EMAIL PROTECTED]> Changed-By: Kartik Mistry <[EMAIL PROTECTED]> Description: xosview - X based system monitor Closes: 483815 483975 Changes: xosview (1.8.3+debian-7) unstable; urgency=low . * debian/patches/18_handle_high_irq_numbers.dpatch: + Added patch to fix crash due to high irq numbers, Thanks to Michael Karcher <[EMAIL PROTECTED]> for patch (Closes: #483815) * debian/patches/19_ + Added patch to fix interrupt indicator shows a "dead" place before last IRQ, Thanks to Michael Karcher <[EMAIL PROTECTED]> for patch (Closes: #483975) * debian/rules: + Do not include config.sub/config.guess in diff.gz by placing its section before ./configure call Checksums-Sha1: b33276e29e6f798b5ff66f7e25066785eb0820bf 1110 xosview_1.8.3+debian-7.dsc efe890e9116e5bbfd1ddd03b660c4e3bde691c49 26010 xosview_1.8.3+debian-7.diff.gz b1e08a447c1ce55745883ddb161ff1014cd16c38 102552 xosview_1.8.3+debian-7_amd64.deb Checksums-Sha256: fc630d54f227f1c81082ddfa4eb5563f0f8ec9697aec67f59d69e7992291eeec 1110 xosview_1.8.3+debian-7.dsc 63bd046fc34bfe8a251641dcf272fbb7d23ae6f03627f74b657644cc4c8fc89e 26010 xosview_1.8.3+debian-7.diff.gz 46870695591887188d999e469499f5abefb4e6ba30fe34e0fd80f768cefc5656 102552 xosview_1.8.3+debian-7_amd64.deb Files: 9e910f7679673ca8aa0162d15da962ca 1110 utils optional xosview_1.8.3+debian-7.dsc 9db1fa6ccde97b9e8c26611836426145 26010 utils optional xosview_1.8.3+debian-7.diff.gz 9fa28770773bd1388d5a69c35aaa20a7 102552 utils optional xosview_1.8.3+debian-7_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIREn02A7zWou1J68RAqDQAJ9Evl9bPzdEExtvyih9Z6nmwJbhpQCcDVV5 Wi6fnNOrG+1r9hQrDEZlQMQ= =raOG -----END PGP SIGNATURE-----
--- End Message ---
