Your message dated Tue, 03 Jun 2008 20:47:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#440035: fixed in awstats 6.7.dfsg-2
has caused the Debian Bug report #440035,
regarding awstats: nested includes always fail with "Perl versions before 5.6 
cannot handle nested includes"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
440035: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=440035
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: awstats
Version: 6.5+dfsg-1
Severity: normal
Tags: patch

I attempted to create a multi-site config which makes use of two levels
of Include config files:

Site config "awstats.mysite.conf"
which first Includes "awstats.default.conf" (a copy of awstats.conf as issued)
which itself Includes "awstats.conf.local"

Awstats rejects this with the message "Perl versions before 5.6 cannot
handle nested includes" even though I am running on Perl 5.8.  I don't
see any test for the Perl version in the section of code that produces
this message (line 1203 in my awstats.pl).

The code appears to be trying to handle nested includes OK but bails
out in the middle due to this test, which I therefore think is erroneous.

I could move the Includes around but it would suit me better to use multi
level Includes as it avoids editing the standard awstats.conf on updates.
I can simply copy it (after review of course) to awstats.default.conf.

I've attached a patch for your review.  This allows nested includes
(up to awstats' predefined limit of 10 levels) and on my 2-level testing
they appear to work fine under Apache 2.2, mod_perl and Perl 5.8.

Nick

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (600, 'stable'), (500, 'oldstable'), (3, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-k7
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages awstats depends on:
ii  perl [libstorable-perl]       5.8.8-7    Larry Wall's Practical Extraction 

Versions of packages awstats recommends:
ii  libnet-xwhois-perl            0.90-3     Whois Client Interface for Perl5

-- no debconf information
--- /usr/lib/cgi-bin/awstats.pl.orig	2006-11-04 21:17:24.000000000 +0000
+++ /usr/lib/cgi-bin/awstats.pl	2007-08-29 11:41:50.000000000 +0100
@@ -1199,7 +1199,7 @@
 			    # Correct relative include files
 				if ($FileConfig =~ /^(.*[\\\/])[^\\\/]*$/) { $includeFile = "$1$includeFile"; }
 			}
-			if ($level > 1) {
+			if ($level > 1 && $^V lt v5.6.0) {
 				warning("Warning: Perl versions before 5.6 cannot handle nested includes");
 				next;
 			}

--- End Message ---
--- Begin Message ---
Source: awstats
Source-Version: 6.7.dfsg-2

We believe that the bug you reported is fixed in the latest version of
awstats, which is due to be installed in the Debian FTP archive:

awstats_6.7.dfsg-2.diff.gz
  to pool/main/a/awstats/awstats_6.7.dfsg-2.diff.gz
awstats_6.7.dfsg-2.dsc
  to pool/main/a/awstats/awstats_6.7.dfsg-2.dsc
awstats_6.7.dfsg-2_all.deb
  to pool/main/a/awstats/awstats_6.7.dfsg-2_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Henriksson <[EMAIL PROTECTED]> (supplier of updated awstats package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 03 Jun 2008 22:20:45 +0200
Source: awstats
Binary: awstats
Architecture: source all
Version: 6.7.dfsg-2
Distribution: unstable
Urgency: low
Maintainer: Debian AWStats Team <[EMAIL PROTECTED]>
Changed-By: Andreas Henriksson <[EMAIL PROTECTED]>
Description: 
 awstats    - powerful and featureful web server log analyzer
Closes: 432096 440035 478968
Changes: 
 awstats (6.7.dfsg-2) unstable; urgency=low
 .
   [ Andreas Henriksson ]
   * Add debian/patches/1005_at-amp-t.patch (Closes: #478968)
   * Add myself to Uploaders.
   * Fix lintian warnings:
     + doc-base: Apps/Net -> Network/Monitoring
   * Bump to debian-policy 3.7.3
 .
   [ Charles Fry ]
   * Disable warnings for Perl < 5.6 (Closes: #432096, #440035)
 .
   [ Jonas Smedegaard ]
   * Move Homepage to own field (from pseudo-field in long description).
   * Use Vcs-* fields (and not XS-Vcs-* ones).
   * Update cdbs tweaks:
     + update-tarball needs cdbs 0.4.39 or newer (only relevant for
       backports).
     + Support zip in upstream-tarball.mk (unneeded here).
     + Use ~ as repackaging delimiter by default in upstream-tarball.mk
       to make room for point releases and cleaned up rerelease.
     + Rename top srcdir in repackaged tarball to $pkg-$ver.orig to
       comply with Developers Reference 6.7.8.2.
     + Support mangling upstream version string in upstream-tarball.mk.
     + Major rewrite of copyright-check.mk.  Update copyright_hints.
     + Drop wget options broken with recent versions of wget in
       update-tarball.mk.
     + Drop buildcore.mk override (set DEB_AUTO_UPDATE_DEBIAN_CONTROL
       manually when needed instead)
     + Misc. updates to README.cdbs-tweaks.
   * Rewrite config tweak in debian/rules in perl (instead of sed).
   * Fix dollar signs in perl-in-shell-in-make code in debian/rules.
   * Update build-dependency cosmetics in debian/rules, and semi-auto-
     update debian/control:
     DEB_AUTO_UPDATE_DEBIAN_CONTROL=yes fakeroot debian/rules
Checksums-Sha1: 
 cc8c5f921a60433a840cebc67403c4a1829e1946 1364 awstats_6.7.dfsg-2.dsc
 db3bef269723e85ea5de1512f920b91e7c09349b 28209 awstats_6.7.dfsg-2.diff.gz
 39c47db750a41e53b9846cfd479380de04f6cc4a 917480 awstats_6.7.dfsg-2_all.deb
Checksums-Sha256: 
 80f68ca9830c2a2b98cc88abc77f710c08ffc18a439db56c0913da19ccb07ece 1364 
awstats_6.7.dfsg-2.dsc
 d5f76ed018f108be40ed6a240aea2dfa5f9232697bd610288a99be64d8ecba79 28209 
awstats_6.7.dfsg-2.diff.gz
 7a0d8628879b39828f9650da1d8d661ba98af85084f06283ea9c349214346796 917480 
awstats_6.7.dfsg-2_all.deb
Files: 
 a85b8b8f8cb0f3139cb83b1a2bf9af4b 1364 web optional awstats_6.7.dfsg-2.dsc
 df7612afeed9619669dd4cd0aae371a2 28209 web optional awstats_6.7.dfsg-2.diff.gz
 e07a47f8634a4895c1673712db810975 917480 web optional awstats_6.7.dfsg-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIRasmcgQ2cL3l8e4RApeVAJ4l2R6CY0vOlCeUW0q+FwbaVNZvqgCeMVZ3
gUMmUO+j8l2MngzdecUH1pI=
=0HVv
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to