Your message dated Sat, 07 Jun 2008 18:32:33 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#482444: fixed in gitpkg 0.7
has caused the Debian Bug report #482444,
regarding gitpkg: git-debimport does not work with absolute paths
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
482444: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482444
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: gitpkg
Version: 0.6
Severity: important
Tags: patch

When I run git-debimport with an absolute path, I get the error shown below:

$ git-debimport /absolute/path/to/package
Initialized empty Git repository in .git/
Initial import of /absolute/path/to/package/package_1.0.orig.tar.gz
tar: ..//absolute/path/to/package/package_1.0.orig.tar.gz: Cannot
open: No such file or directory
tar: Error is not recoverable: exiting now

But it works when I git-debimport it for the same directory location
but with a relative path.

git-debimport ../../../path/to/package

It appears that ../ is prefixed always in the get-debimport script
when looking up the original tar ball, which caused it to fail for
absolute paths.

I've attached a patch that fixes this and I've tested it for both
relative and absolute directories, and it seems to work. Appreciate if
you could review, and consider this for inclusion. Thanks.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

-- no debconf information

-- 
Anuradha Weeraman
http://www.linux.lk/~anu/
http://www.gnuromancer.org
--- git-debimport	2008-05-22 15:50:08.000000000 -0400
+++ git-debimport.new	2008-05-22 15:49:52.000000000 -0400
@@ -63,6 +63,11 @@
 PACKAGE_NAME="${1##*/}"
 PACKAGE_DIFFS="$(find $PACKAGES_DIR -type f -name ${PACKAGE_NAME}_*.diff.gz | sort)"
 CACHE_DIR="../${PACKAGE_NAME}-import-cache"
+FIRST_CH=`echo "$PACKAGES_DIR" | head -c 1`
+
+if [ "$FIRST_CH" != "/" ]; then
+	PREFIX="../"
+fi
 
 if [ -z "$PACKAGE_DIFFS" ]; then
     echo "No ${1}_*.diff.gz files found, aborting."
@@ -130,7 +135,7 @@
 
 	rm -rf "$CACHE_DIR"
 	mkdir -p "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig"
-	tar -xf "../$PACKAGES_DIR/${PACKAGE_NAME}_${UPSTREAM_VERSION}.orig.tar.gz" \
+	tar -xf "${PREFIX}$PACKAGES_DIR/${PACKAGE_NAME}_${UPSTREAM_VERSION}.orig.tar.gz" \
 	     -C "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig" --strip 1
 	for i in $(ls -A "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig"); do
 	    cp -al "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig/$i" .
@@ -183,7 +188,7 @@
     for i in $(ls -A "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig"); do
 	cp -al "$CACHE_DIR/${PACKAGE_NAME}-${UPSTREAM_VERSION}.orig/$i" .
     done
-    zcat "../$f" | patch -p1
+    zcat "${PREFIX}$f" | patch -p1
     chmod 755 debian/rules
 
     DATE=$(dpkg-parsechangelog | sed -n 's/Date: //p')

--- End Message ---
--- Begin Message ---
Source: gitpkg
Source-Version: 0.7

We believe that the bug you reported is fixed in the latest version of
gitpkg, which is due to be installed in the Debian FTP archive:

gitpkg_0.7.dsc
  to pool/main/g/gitpkg/gitpkg_0.7.dsc
gitpkg_0.7.tar.gz
  to pool/main/g/gitpkg/gitpkg_0.7.tar.gz
gitpkg_0.7_all.deb
  to pool/main/g/gitpkg/gitpkg_0.7_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ron Lee <[EMAIL PROTECTED]> (supplier of updated gitpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 08 Jun 2008 03:06:19 +0930
Source: gitpkg
Binary: gitpkg
Architecture: source all
Version: 0.7
Distribution: unstable
Urgency: low
Maintainer: Ron Lee <[EMAIL PROTECTED]>
Changed-By: Ron Lee <[EMAIL PROTECTED]>
Description: 
 gitpkg     - helper scripts for maintaining packages with git
Closes: 482444
Changes: 
 gitpkg (0.7) unstable; urgency=low
 .
   * Add support for an absolute path to the packages for git-debimport.
     Thanks to Anuradha Weeraman for the poke to fix this and an initial
     partial patch.  Closes: #482444
   * Add Vcs- headers to control.
Checksums-Sha1: 
 c1721d45d62bc3efb5ffc62cb04a49793f141157 773 gitpkg_0.7.dsc
 820d4778c90904fc2623d588ec77b4ed4df5cea8 8332 gitpkg_0.7.tar.gz
 a96cccf9408fda1071c2d72355d3c05da2cd8333 10608 gitpkg_0.7_all.deb
Checksums-Sha256: 
 0a1cdf92e8bc9a09193c343b7417efdf206fe658cfa563984964de43ed5f41ea 773 
gitpkg_0.7.dsc
 bd1181fe639fbddb3c7c6644ff077710079d9ec484936937966cd2600de08603 8332 
gitpkg_0.7.tar.gz
 aedcf9f676627b34161010df6f26fa7cd31aa46fe5f9a3c7ae01ae5588adb394 10608 
gitpkg_0.7_all.deb
Files: 
 c29f01da6c003269ca6f085799fa9663 773 devel optional gitpkg_0.7.dsc
 f2f370b05f8b216cb0cfe744af56bf28 8332 devel optional gitpkg_0.7.tar.gz
 efd05331e3726c0d166048d522d3d823 10608 devel optional gitpkg_0.7_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIStMTp4BCHGgCHOQRAnFzAJ9/5uj9NmgU/k0B/3F1KATLdf995wCeKaEE
bhucAtEkxo5y94YPBDmUYIg=
=jx1w
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to