Your message dated Sun, 15 Jun 2008 21:17:15 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#468309: fixed in check 0.9.5-4
has caused the Debian Bug report #468309,
regarding check: Broken statistics on failure in setup code
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
468309: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468309
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: check
Version: 0.9.5-3
Severity: normal
Hi,
when I have setup functions that fail (e.g., with fail_unless()), this
leads to broken statistics, e.g.:
-66%: Checks: 9, Failures: 15, Errors: 0
This comes from src/check_run.c:167:
if ((tr->ctx == CK_CTX_TEST) || (tr->ctx == CK_CTX_TEARDOWN))
sr->stats->n_checked++;
If we are still in CK_CTX_SETUP (==0), this iteration is not counted in
n_checked, but as failure, as can be seen above.
I propose removing the first quoted line, doing the "++"
unconditionally. I tried it and it works for me. I checked the Check
SVN, and the respective patch (rev. 182) "Fixed setup bug from forum,
failure in setup did not abort test in nofork mode." - explicitly should
fix a failure condition in setup. But the above described line is a bug,
IMHO.
Thanks for considering,
Roland
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-rt1 (SMP w/1 CPU core; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/bash
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: check
Source-Version: 0.9.5-4
We believe that the bug you reported is fixed in the latest version of
check, which is due to be installed in the Debian FTP archive:
check_0.9.5-4.diff.gz
to pool/main/c/check/check_0.9.5-4.diff.gz
check_0.9.5-4.dsc
to pool/main/c/check/check_0.9.5-4.dsc
check_0.9.5-4_amd64.deb
to pool/main/c/check/check_0.9.5-4_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Robert Lemmen <[EMAIL PROTECTED]> (supplier of updated check package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 15 Jun 2008 19:04:43 +0100
Source: check
Binary: check
Architecture: source amd64
Version: 0.9.5-4
Distribution: unstable
Urgency: low
Maintainer: [EMAIL PROTECTED]
Changed-By: Robert Lemmen <[EMAIL PROTECTED]>
Description:
check - unit test framework for C
Closes: 468309
Changes:
check (0.9.5-4) unstable; urgency=low
.
* Added patch by Roland Stigge (closes: #468309)
* Bumped standards version
* Added Homepage field
Checksums-Sha1:
414b64f96266893f83c65a1343d1be9b8877409d 952 check_0.9.5-4.dsc
aba7f1e36df6c53f5b9250439bcdcf8e4a6d17b9 5388 check_0.9.5-4.diff.gz
5bcd87978ea0393c93b816cd96732562f2155340 101946 check_0.9.5-4_amd64.deb
Checksums-Sha256:
bc529037401380786b143ad3b9b0a80c9b45127167913f76e9ba266f2c543aa6 952
check_0.9.5-4.dsc
f4b9425cd99a1ce30f8a7ee521ccd85167ed77c78579aba040e2240557d2a046 5388
check_0.9.5-4.diff.gz
ae36e3ce3b4ff45e9b7b5c37fe43ec77e5d562f8dfa48f23c0056e3916b6c734 101946
check_0.9.5-4_amd64.deb
Files:
275c22dc89d41aae0b62cfb59bc22f0a 952 devel optional check_0.9.5-4.dsc
6dc284901ffe063ffb794cdbd03aeaa6 5388 devel optional check_0.9.5-4.diff.gz
caadfbea4614e3496846dde81381e1fe 101946 devel optional check_0.9.5-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIVXyhS6AOchRbaWYRAs5tAKCjYy4NQ51vfu8O0rI8R7kMKfH67wCeKwSb
3jzLwUTaaoqQfTZ3C5nU3jU=
=uUsY
-----END PGP SIGNATURE-----
--- End Message ---
