Your message dated Thu, 3 Jul 2008 03:04:44 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Re: Bug#480068: Does not call plugin_stop when restarting
has caused the Debian Bug report #480068,
regarding Does not call plugin_stop when restarting
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
480068: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480068
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: arno-iptables-firewall
Version: 1.8.8.o-2
Tags: patch

Hi,

Although plugins can implement a 'plugin_stop' method so that changes can be
removed on "restart" or "stop" events, the script seems to omit calling them.

A patch is attached.


Regards,

-- 
Chris Lamb, UK                                       [EMAIL PROTECTED]
                                                            GPG: 0x634F9A20
diff -urNad arno-iptables-firewall-1.8.8.o.orig/arno-iptables-firewall 
arno-iptables-firewall-1.8.8.o/arno-iptables-firewall
--- arno-iptables-firewall-1.8.8.o.orig/arno-iptables-firewall  2008-05-08 
00:26:14.000000000 +0100
+++ arno-iptables-firewall-1.8.8.o/arno-iptables-firewall       2008-05-08 
00:27:12.000000000 +0100
@@ -3874,6 +3874,9 @@
 
         # Source the plugin:
         . "$plugin"
+
+        # Call stop function
+        plugin_stop
       fi
     done
   fi

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Arno wrote:

>  You probably missed the plugin stop() below...

I don't think I did, but I was clearly doing something else wrong. :)

Closing this bug; I cannot reproduce it now (or since your last mail).


Regards,

-- 
Chris Lamb, UK                                       [EMAIL PROTECTED]
                                                            GPG: 0x634F9A20

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to