Your message dated Sat, 19 Jul 2008 13:40:17 +0200
with message-id <[EMAIL PROTECTED]>
and subject line fixed
has caused the Debian Bug report #481488,
regarding home directory readonly makes bip segfault
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
481488: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=481488
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: bip
Version: 0.7.1-1
Severity: minor
Tags: patch
When run with a read-only $HOME directory, bip segfaults as it tries to
create the ~/.oidentd.conf due to improper return value check.
The attached patch fixes the issue.
It also remove the warning 'users logs will be mixed' when only one user
is configured.
--
jj
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.21.1-grsec
Locale: LANG=C, LC_CTYPE=fr_FR (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to
C)
Shell: /bin/sh linked to /bin/bash
Versions of packages bip depends on:
ii adduser 3.107 add and remove users and groups
ii libc6 2.7-11 GNU C Library: Shared libraries
ii libssl0.9.8 0.9.8g-10 SSL shared libraries
ii lsb-base 3.2-12 Linux Standard Base 3.2 init scrip
bip recommends no packages.
-- no debconf information
diff -ur bip-0.7.1-old/src/bip.c bip-0.7.1-new/src/bip.c
--- bip-0.7.1-old/src/bip.c 2008-04-02 23:49:48.000000000 +0200
+++ bip-0.7.1-new/src/bip.c 2008-05-16 14:53:31.000000000 +0200
@@ -848,7 +848,9 @@
}
}
- if (strstr(conf_log_format, "%u") == NULL)
+ hash_it_init(&bip->users, &it);
+ hash_it_next(&it);
+ if (hash_it_item(&it) && !strstr(conf_log_format, "%u"))
mylog(LOG_WARN, "log_format does not contain %%u, all users'"
" logs will be mixed !");
return r;
diff -ur bip-0.7.1-old/src/irc.c bip-0.7.1-new/src/irc.c
--- bip-0.7.1-old/src/irc.c 2008-04-02 23:49:48.000000000 +0200
+++ bip-0.7.1-new/src/irc.c 2008-05-16 15:08:50.000000000 +0200
@@ -2121,8 +2121,7 @@
char tag_written = 0;
if (stat(bip->oidentdpath, &stats) == -1) {
- if (errno == ENOENT) {
- f = fopen(bip->oidentdpath, "w+");
+ if (errno == ENOENT && (f = fopen(bip->oidentdpath, "w+")))
fchmod(fileno(f), 0644);
} else {
mylog(LOG_WARN, "Can't open/create %s",
@@ -2130,6 +2129,7 @@
return;
}
} else {
+ /* strip previously autogenerated content */
char *content;
f = fopen(bip->oidentdpath, "r+");
@@ -2143,7 +2143,7 @@
if (content == NULL){
fatal("out of memory");
- return;
+ goto clean_oidentd;
}
if (fread(content, 1, stats.st_size, f) !=
--- End Message ---
--- Begin Message ---
patch merged in current sid, bip.
thanks
--- End Message ---
