Your message dated Sun, 20 Jul 2008 23:17:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#482672: fixed in dkim-milter 2.6.0.dfsg-1
has caused the Debian Bug report #482672,
regarding dkim-filter: Lack of proper config file support in init script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
482672: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482672
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: dkim-filter
Version: 2.5.5.dfsg-1+b2
Severity: important
Tags: patch
Although dkim-filter moved entirely to a .conf file, the init script makes
this harder than it should be. SOCKET is explicitly specified in the init
script, which causes DAEMON_OPTS to be populated, and subsequently overrides
any SOCKET settings from the config file (thus making it impossible to run a
TCP listener for instance). Since I was not sure if removing the line
SOCKET=local:$RUNDIR/$NAME.sock would violate any policies, and didn't want to
fiddle with the init file itself, I edited /etc/default/dkim-filter to contain:
DAEMON_OPTS=""
SOCKET=""
which should have signaled to the script that I want to rely on the config file
entirely. However due to lack of proper quoting throughout the entire script the
thing blew up. I am attaching a patch for the quoting only (since it has to be
there anyway), although I believe SOCKET has no place in the init script at all.
Cheers
Peter
--- dkim-filter.dpkg-dist 2008-05-12 17:18:07.000000000 -0400
+++ dkim-filter 2008-05-24 07:10:52.000000000 -0400
@@ -40,27 +40,27 @@
start() {
# Create the run directory if it doesn't exist
- if [ ! -d $RUNDIR ]; then
- install -o $USER -g $GROUP -m 755 -d $RUNDIR || return 2
+ if [ ! -d "$RUNDIR" ]; then
+ install -o "$USER" -g "$GROUP" -m 755 -d "$RUNDIR" || return 2
fi
# Clean up stale sockets
- if [ -f $PIDFILE ]; then
+ if [ -f "$PIDFILE" ]; then
pid=`cat $PIDFILE`
- if ! ps -C $DAEMON -s $pid >/dev/null; then
- rm $PIDFILE
+ if ! ps -C "$DAEMON" -s "$pid" >/dev/null; then
+ rm "$PIDFILE"
# UNIX sockets may be specified with or without the
# local: prefix; handle both
t=`echo $SOCKET | cut -d: -f1`
s=`echo $SOCKET | cut -d: -f2`
- if [ -e $s -a -S $s ]; then
+ if [ -e "$s" -a -S "$s" ]; then
if [ "$t" = "$s" -o "$t" = "local" ]; then
- rm $s
+ rm "$s"
fi
fi
fi
fi
- start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --
$DAEMON_OPTS
- # Detect exit status 64 (configuration error)
+ start-stop-daemon --start --quiet --pidfile "$PIDFILE" --exec "$DAEMON"
-- $DAEMON_OPTS
+ # Detect exit status 78 (configuration error)
ret=$?
if [ $ret -eq 78 ]; then
echo "See /usr/share/doc/dkim-filter/README.Debian or
dkim-filter.conf(5) for help"
@@ -71,11 +71,11 @@
}
stop() {
- start-stop-daemon --stop --retry $stoptimeout --exec $DAEMON
+ start-stop-daemon --stop --retry "$stoptimeout" --exec "$DAEMON"
}
reload() {
- start-stop-daemon --stop --signal USR1 --exec $DAEMON
+ start-stop-daemon --stop --signal USR1 --exec "$DAEMON"
}
case "$1" in
--- End Message ---
--- Begin Message ---
Source: dkim-milter
Source-Version: 2.6.0.dfsg-1
We believe that the bug you reported is fixed in the latest version of
dkim-milter, which is due to be installed in the Debian FTP archive:
dkim-filter_2.6.0.dfsg-1_i386.deb
to pool/main/d/dkim-milter/dkim-filter_2.6.0.dfsg-1_i386.deb
dkim-milter_2.6.0.dfsg-1.diff.gz
to pool/main/d/dkim-milter/dkim-milter_2.6.0.dfsg-1.diff.gz
dkim-milter_2.6.0.dfsg-1.dsc
to pool/main/d/dkim-milter/dkim-milter_2.6.0.dfsg-1.dsc
dkim-milter_2.6.0.dfsg.orig.tar.gz
to pool/main/d/dkim-milter/dkim-milter_2.6.0.dfsg.orig.tar.gz
libsmdkim-dev_2.6.0.dfsg-1_i386.deb
to pool/main/d/dkim-milter/libsmdkim-dev_2.6.0.dfsg-1_i386.deb
libsmdkim2_2.6.0.dfsg-1_i386.deb
to pool/main/d/dkim-milter/libsmdkim2_2.6.0.dfsg-1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Markley <[EMAIL PROTECTED]> (supplier of updated dkim-milter package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 20 Jul 2008 15:46:37 -0700
Source: dkim-milter
Binary: dkim-filter libsmdkim2 libsmdkim-dev
Architecture: source i386
Version: 2.6.0.dfsg-1
Distribution: unstable
Urgency: low
Maintainer: Mike Markley <[EMAIL PROTECTED]>
Changed-By: Mike Markley <[EMAIL PROTECTED]>
Description:
dkim-filter - DomainKeys Identified Mail (DKIM) Milter implementation
libsmdkim-dev - DomainKeys Identified Mail (DKIM) library implementation
libsmdkim2 - DomainKeys Identified Mail (DKIM) library implementation
Closes: 482672 490276
Changes:
dkim-milter (2.6.0.dfsg-1) unstable; urgency=low
.
* New upstream version.
* Removed gentxt.csh from README.Debian and added reference to
dkim-genkey.
* Added note in NEWS.Debian about keys generated with compromised
versions of OpenSSL requiring recreation.
* Added quoting to dkim-filter.init and cleaned up the logic around
$SOCKET. Closes: #482672
* Applied patch from Scott Kitterman/Ubuntu to start in verify-only
mode when no keys are configured.
* UseASPDiscard has been once again renamed, this time to ASPDiscard.
* Fixed some config file entries in the default dkim-filter.conf.
Closes: #490276
Checksums-Sha1:
92e9e9d4bc78081fdf78f06d060ead10f0c6a5d4 1089 dkim-milter_2.6.0.dfsg-1.dsc
d8c833ccf4b1c496566344b6e0c7a8b2cbdbc8c2 554381
dkim-milter_2.6.0.dfsg.orig.tar.gz
25aa1361474028c48c6c9b7c05e818d7547c24f6 10928 dkim-milter_2.6.0.dfsg-1.diff.gz
0cd4e881485d2cf4376eb5dc47356d0528fb8395 247968
dkim-filter_2.6.0.dfsg-1_i386.deb
3ea58665413c991505a2570b6dca2882a479a209 71236 libsmdkim2_2.6.0.dfsg-1_i386.deb
e3323e1572c3b9b7d5c0bb5e06ea884ea4af29f5 88968
libsmdkim-dev_2.6.0.dfsg-1_i386.deb
Checksums-Sha256:
b50d9e428dedb5c80433b448c31bc055788d9a67de83c9b5743b48b78bf0f4ea 1089
dkim-milter_2.6.0.dfsg-1.dsc
7d2da562fa40982a520688bcec587b8d5eff426c84148544a8fdd9cbf9ab9ccc 554381
dkim-milter_2.6.0.dfsg.orig.tar.gz
c8a70429fba1ca765492ed7cd346dc6d61c903aa3e169a6b3e0b832f9d3db173 10928
dkim-milter_2.6.0.dfsg-1.diff.gz
d1ef2f5eced961a9ebe52e75fcb119cde3cfffeac2f51af950b02a1eb4325030 247968
dkim-filter_2.6.0.dfsg-1_i386.deb
407df722a666c9ce5113bc5fee090144350fee0554592152111c7353f834d00d 71236
libsmdkim2_2.6.0.dfsg-1_i386.deb
2f23a57b79eb2affd2dd2409ed4e412df4101cc229c42c3d79ab9645a0fb59d2 88968
libsmdkim-dev_2.6.0.dfsg-1_i386.deb
Files:
2a0e1f9dcafc8222ee1a052ee9ea786b 1089 mail extra dkim-milter_2.6.0.dfsg-1.dsc
a9520ac897c00f100d2b9036f97e925d 554381 mail extra
dkim-milter_2.6.0.dfsg.orig.tar.gz
331fbc17916b8671d207fdb1dcc0cd5a 10928 mail extra
dkim-milter_2.6.0.dfsg-1.diff.gz
e7f4c2134bd292f4a556f0125c754899 247968 mail extra
dkim-filter_2.6.0.dfsg-1_i386.deb
554b8d92a14ca139564d1b02e90dd323 71236 libs extra
libsmdkim2_2.6.0.dfsg-1_i386.deb
07dad44222d005ad8db18cd971810b84 88968 libdevel extra
libsmdkim-dev_2.6.0.dfsg-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIg8Nrd6jzajsEcIQRAp/3AJ4sRSc5hVyVtq+XV/7PwXwwkHsD4gCfd9MS
y3om0vPDRobTCa54k5h0+6Y=
=00p2
-----END PGP SIGNATURE-----
--- End Message ---
