Your message dated Sat, 26 Jul 2008 17:32:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#492240: fixed in reportbug 3.44
has caused the Debian Bug report #492240,
regarding reportbug: Can't include non ascii files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
492240: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492240
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: reportbug
Version: 3.43
Severity: normal
Tags: patch


Don't know if this is related to bug number 491869, since i cannot
reproduce that bug

Trying to include a file with non ascii contents or filename in a bug
report raises an uncaught exception:

$ cat test¼
some strange chars here:
¼ € ¢ æ

$ reportbug -i test¼ reportbug
Detected character set: UTF-8
Please change your locale if this is incorrect.

Using 'Flavio Grossi <[EMAIL PROTECTED]>' as your from address.
Traceback (most recent call last):
File "/usr/bin/reportbug", line 1823, in <module>
  main()
File "/usr/bin/reportbug", line 848, in main
  return iface.user_interface()
File "/usr/bin/reportbug", line 1065, in user_interface
  incfiles = u'%s\n*** %s\n%s' % (incfiles, f, fp.read().decode('utf-8', 
'replace'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 4: ordinal 
not in range(128)

Using the gui interface, choosing "Include a text file" option and
selecting the same file, raises

Traceback (most recent call last):
File "/usr/bin/reportbug", line 1823, in <module>
  main()
File "/usr/bin/reportbug", line 848, in main
  return iface.user_interface()
File "/usr/bin/reportbug", line 1764, in user_interface
  charset=charset)
File "/usr/bin/reportbug", line 227, in handle_editing
  attachfile, inline=inline)
File "/usr/bin/reportbug", line 126, in include_file_in_report
  message += '\n*** %s\n%s' % (include_filename, fp.read())
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 9: ordinal 
not in range(128)

Attached is a patch that should fix both problems.


-- Package-specific info:
** Environment settings:
INTERFACE="urwid"

** /home/flavio/.reportbugrc:
reportbug_version "3.43"
mode standard
ui urwid
realname "Flavio Grossi"
email "[EMAIL PROTECTED]"
no-cc
header "X-Debbugs-CC: [EMAIL PROTECTED]"
smtphost bugs.debian.org

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-custom.1 (SMP w/1 CPU core)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages reportbug depends on:
ii  apt                           0.7.14+b1  Advanced front-end for dpkg
ii  python                        2.5.2-1    An interactive high-level object-o
ii  python-central                0.6.8      register and build utility for Pyt

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  debconf-utils                 <none>     (no description available)
pn  debsums                       <none>     (no description available)
pn  dlocate                       <none>     (no description available)
ii  exim4-daemon-light [mail-tran 4.69-6     lightweight Exim MTA (v4) daemon
ii  file                          4.25-1     Determines file type using "magic"
ii  gnupg                         1.4.9-2    GNU privacy guard - a free PGP rep
ii  python-urwid                  0.9.8.3-1  curses-based UI/widget library for

-- no debconf information
--- /usr/bin/reportbug  2008-07-17 20:21:47.000000000 +0200
+++ reportbug_fixed     2008-07-24 17:45:55.000000000 +0200
@@ -96,7 +96,7 @@
 
 def include_file_in_report(message, message_filename,
                            attachment_filenames, package_name,
-                           include_filename, inline=False):
+                           include_filename, charset, inline=False):
     """ Include a file in the report.
 
         :parameters:
@@ -123,11 +123,13 @@
     if inline:
         try:
             fp = file(include_filename)
-            message += '\n*** %s\n%s' % (include_filename, fp.read())
+            message += '\n*** %s\n%s' % (
+                       include_filename.decode(charset, 'replace'),
+                       fp.read().decode(charset, 'replace'))
             fp.close()
             fp, temp_filename = TempFile(
                 prefix=tempfile_prefix(package_name))
-            fp.write(message)
+            fp.write(message.encode(charset, 'replace'))
             fp.close()
             os.unlink(message_filename)
             message_filename = temp_filename
@@ -224,7 +226,7 @@
                         inline = (x == 'i')
                         (message, filename, attachments) = 
include_file_in_report(
                             message, filename, attachments, package,
-                            attachfile, inline=inline)
+                            attachfile, charset, inline=inline)
                         if not inline:
                             skip_editing = True
                     else:
@@ -1062,7 +1064,9 @@
             for f in self.options.include:
                 if os.path.exists(f):
                     fp = file(f)
-                    incfiles = u'%s\n*** %s\n%s' % (incfiles, f, 
fp.read().decode('utf-8', 'replace'))
+                    incfiles = u'%s\n*** %s\n%s' % (
+                               incfiles, f.decode('utf-8', 'replace'),
+                               fp.read().decode('utf-8', 'replace'))
                     fp.close()
                 else:
                     ewrite("Can't find %s to include!\n", f)

--- End Message ---
--- Begin Message ---
Source: reportbug
Source-Version: 3.44

We believe that the bug you reported is fixed in the latest version of
reportbug, which is due to be installed in the Debian FTP archive:

reportbug_3.44.dsc
  to pool/main/r/reportbug/reportbug_3.44.dsc
reportbug_3.44.tar.gz
  to pool/main/r/reportbug/reportbug_3.44.tar.gz
reportbug_3.44_all.deb
  to pool/main/r/reportbug/reportbug_3.44_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sandro Tosi <[EMAIL PROTECTED]> (supplier of updated reportbug package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 26 Jul 2008 19:17:44 +0200
Source: reportbug
Binary: reportbug
Architecture: source all
Version: 3.44
Distribution: unstable
Urgency: medium
Maintainer: Reportbug Maintainers <[EMAIL PROTECTED]>
Changed-By: Sandro Tosi <[EMAIL PROTECTED]>
Description: 
 reportbug  - reports bugs in the Debian distribution
Closes: 492240 492490
Changes: 
 reportbug (3.44) unstable; urgency=medium
 .
   [ Chris Lawrence ]
   * reportbug
     + Yet another character set issue fix.  (Closes: #492240)
 .
   [ Sandro Tosi ]
   * debian/control
     - changed build-dep-indep from python-dev to python
     - bump required Python version to >= 2.5; thanks to Gilles Sadowski for
       the report; Closes: #492490 (RC bug, hence urgency set to medium)
Checksums-Sha1: 
 618f4bed4eed9b5f594040ff24b5e08991f22903 1170 reportbug_3.44.dsc
 1a92decb661e9b0802b254bee64eb10475671102 175176 reportbug_3.44.tar.gz
 9cdf48fb1c3db6f245f59f8806c92535cd5218db 157346 reportbug_3.44_all.deb
Checksums-Sha256: 
 68130157e302f22d5c418a993707340f7c3ea7db5167bd6bd19bd3db8e980283 1170 
reportbug_3.44.dsc
 f4743c8e99afc00fc3088e9064f68078729c6f6a3680046c0aa510767865b8d4 175176 
reportbug_3.44.tar.gz
 b7c100be341c487066d822c219dfe3e76d253f1a1d7ba8d4d4d4335ef463fbcc 157346 
reportbug_3.44_all.deb
Files: 
 b69519d543f8de59da6075fc320c696a 1170 utils standard reportbug_3.44.dsc
 34f64c01e42b48183cafc1c68378750f 175176 utils standard reportbug_3.44.tar.gz
 b4b5e99e93ba95deefaf4b3dee8d970b 157346 utils standard reportbug_3.44_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiLXXkACgkQAukwV0RN2VAM0ACaAroFLZDIBDpgCb+vvLMkWcsk
b/IAn0kWC8m1V7GwRfnNy1yOJPSJudTy
=O3je
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to