Your message dated Thu, 31 Jul 2008 09:17:11 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#493064: fixed in libtree-redblack-perl 0.3-9
has caused the Debian Bug report #493064,
regarding libtree-redblack-perl: broken insert with custom comparison function
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
493064: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493064
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: libtree-redblack-perl
Version: 0.3-6
Severity: important
Tags: upstream patch
Forwarded: http://rt.cpan.org/Ticket/Display.html?id=19431
[dam: I am resending this as a proper bug report]
Hello,
There's a serious flaw in this RedBlack.pm implementation. Specifically, on
line 140:
140: if ($this->{'cmp'} ? $this->{'cmp'}->($key, $node->key) < 0
141: : $key lt $parent->key) {
142: $parent->left($node);
If you are using a custom compare function, it needs to compare $key
to $parent->key, not $node->key. This causes errors in insertion,
which makes the tree completely useless.
Hopefully someone can fix this in a future release!
Thanks,
Craig
This is reported[1] upstream two years ago and the report has a patch.
I am going to apply it and upload soon.
[1] http://rt.cpan.org/Ticket/Display.html?id=19431
Thanks for the headsup,
dam
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: libtree-redblack-perl
Source-Version: 0.3-9
We believe that the bug you reported is fixed in the latest version of
libtree-redblack-perl, which is due to be installed in the Debian FTP archive:
libtree-redblack-perl_0.3-9.diff.gz
to pool/main/libt/libtree-redblack-perl/libtree-redblack-perl_0.3-9.diff.gz
libtree-redblack-perl_0.3-9.dsc
to pool/main/libt/libtree-redblack-perl/libtree-redblack-perl_0.3-9.dsc
libtree-redblack-perl_0.3-9_all.deb
to pool/main/libt/libtree-redblack-perl/libtree-redblack-perl_0.3-9_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Damyan Ivanov <[EMAIL PROTECTED]> (supplier of updated libtree-redblack-perl
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 31 Jul 2008 09:53:33 +0300
Source: libtree-redblack-perl
Binary: libtree-redblack-perl
Architecture: source all
Version: 0.3-9
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <[EMAIL PROTECTED]>
Changed-By: Damyan Ivanov <[EMAIL PROTECTED]>
Description:
libtree-redblack-perl - Perl implementation of Red/Black tree, a balanced tree
Closes: 493064
Changes:
libtree-redblack-perl (0.3-9) unstable; urgency=low
.
* add fix_broken_insert_with_custom_compare.patch; Closes: #493064
Thanks to Craig Soules for reporting and Andre Lucas for the patch.
+ add quilt to the build process
* add README.source documenting quilt usage
+ Standards-Version: 3.8.0
* add myself to Uploaders
* trim down debian/rules using debhelper 7
Checksums-Sha1:
09652267592383948f31c793d4bfdbdc0d8f8e26 1442 libtree-redblack-perl_0.3-9.dsc
0d217974f1659d3e383fa4cda5b7450c41393c6d 3511
libtree-redblack-perl_0.3-9.diff.gz
f3f842112a750c5eb66524e88cde311c1e37b0a5 14686
libtree-redblack-perl_0.3-9_all.deb
Checksums-Sha256:
70bc13b6f26d8bd15f5c7c07508007764fe1e93e4d2dd96124334ee36f2fb72a 1442
libtree-redblack-perl_0.3-9.dsc
ad516d21ab4f268a7bfa1af661231043bb461233c58c06f8a1ca2b1cf8e33ad2 3511
libtree-redblack-perl_0.3-9.diff.gz
a88921a6108d89975ac02820d40393fbbd89e937b9307f70d07a620d96f7c618 14686
libtree-redblack-perl_0.3-9_all.deb
Files:
a72a5f9b489dd3546429d2cfc05dae11 1442 perl optional
libtree-redblack-perl_0.3-9.dsc
61242193a6fee83fc5eb446492145b2d 3511 perl optional
libtree-redblack-perl_0.3-9.diff.gz
e6770d58d4db53878739dcfb75448791 14686 perl optional
libtree-redblack-perl_0.3-9_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiRdfYACgkQHqjlqpcl9jvhgwCfRXYKoyrx99orGKM+tRUScXkV
MasAnRNdwbSmZJD7Hqq/GfnJ8I3ryJHo
=QMGF
-----END PGP SIGNATURE-----
--- End Message ---
